Re: [dm-devel] [PATCH 15/18] scsi: allocate scsi_cmnd structures as part of struct request

2017-01-28 Thread h...@lst.de
On Fri, Jan 27, 2017 at 06:39:46PM +, Bart Van Assche wrote: > Why have the scsi_release_buffers() and scsi_put_command(cmd) calls been > moved up? I haven't found an explanation for this change in the patch > description. Because they reference the scsi_cmnd, which are now part of the request

Re: [dm-devel] [PATCH 15/18] scsi: allocate scsi_cmnd structures as part of struct request

2017-01-27 Thread Bart Van Assche
On Wed, 2017-01-25 at 18:25 +0100, Christoph Hellwig wrote: > -unsigned char *scsi_alloc_sense_buffer(struct Scsi_Host *shost, gfp_t > gfp_mask, > -   int numa_node) > +static unsigned char *scsi_alloc_sense_buffer(struct Scsi_Host *shost, > +   gfp_t gfp_mask, int numa_node) >  {

Re: [dm-devel] [PATCH 15/18] scsi: allocate scsi_cmnd structures as part of struct request

2017-01-25 Thread Martin K. Petersen
> "Christoph" == Christoph Hellwig writes: Christoph> Rely on the new block layer functionality to allocate Christoph> additional driver specific data behind struct request instead Christoph> of implementing it in SCSI itѕelf. Acked-by: Martin K. Petersen -- Martin K. Petersen Oracle

[dm-devel] [PATCH 15/18] scsi: allocate scsi_cmnd structures as part of struct request

2017-01-25 Thread Christoph Hellwig
Rely on the new block layer functionality to allocate additional driver specific data behind struct request instead of implementing it in SCSI itѕelf. Signed-off-by: Christoph Hellwig Reviewed-by: Hannes Reinecke --- drivers/scsi/hosts.c | 20 +-- drivers/scsi/scsi.c | 319 -