Re: [dm-devel] [PATCH 18/21] libmultipath: keep bindings in memory

2023-09-11 Thread Benjamin Marzinski
On Mon, Sep 11, 2023 at 08:25:05AM +0200, Martin Wilck wrote: > On Fri, 2023-09-08 at 12:22 -0500, Benjamin Marzinski wrote: > > On Thu, Sep 07, 2023 at 10:43:27PM +0200, Martin Wilck wrote:  > > > Our bindings list is now partially sorted, which is an improvement > > > wrt > > > the previous

Re: [dm-devel] [PATCH 18/21] libmultipath: keep bindings in memory

2023-09-11 Thread Martin Wilck
On Fri, 2023-09-08 at 12:22 -0500, Benjamin Marzinski wrote: > On Thu, Sep 07, 2023 at 10:43:27PM +0200, Martin Wilck wrote:  > > Our bindings list is now partially sorted, which is an improvement > > wrt > > the previous situation. "missing the gap" is not really an awful > > problem [*]. Perhaps

Re: [dm-devel] [PATCH 18/21] libmultipath: keep bindings in memory

2023-09-08 Thread Benjamin Marzinski
On Thu, Sep 07, 2023 at 10:43:27PM +0200, Martin Wilck wrote: > On Thu, 2023-09-07 at 15:02 -0500, Benjamin Marzinski wrote: > > On Thu, Sep 07, 2023 at 02:14:04PM -0500, Benjamin Marzinski wrote: > > > On Thu, Sep 07, 2023 at 12:30:53PM +0200, Martin Wilck wrote: > > > > On Wed, 2023-09-06 at

Re: [dm-devel] [PATCH 18/21] libmultipath: keep bindings in memory

2023-09-07 Thread Martin Wilck
On Thu, 2023-09-07 at 15:02 -0500, Benjamin Marzinski wrote: > On Thu, Sep 07, 2023 at 02:14:04PM -0500, Benjamin Marzinski wrote: > > On Thu, Sep 07, 2023 at 12:30:53PM +0200, Martin Wilck wrote: > > > On Wed, 2023-09-06 at 17:47 -0500, Benjamin Marzinski wrote: > > > > On Fri, Sep 01, 2023 at

Re: [dm-devel] [PATCH 18/21] libmultipath: keep bindings in memory

2023-09-07 Thread Benjamin Marzinski
On Thu, Sep 07, 2023 at 02:14:04PM -0500, Benjamin Marzinski wrote: > On Thu, Sep 07, 2023 at 12:30:53PM +0200, Martin Wilck wrote: > > On Wed, 2023-09-06 at 17:47 -0500, Benjamin Marzinski wrote: > > > On Fri, Sep 01, 2023 at 08:02:31PM +0200, mwi...@suse.com wrote: > > > > From: Martin Wilck >

Re: [dm-devel] [PATCH 18/21] libmultipath: keep bindings in memory

2023-09-07 Thread Benjamin Marzinski
On Thu, Sep 07, 2023 at 12:30:53PM +0200, Martin Wilck wrote: > On Wed, 2023-09-06 at 17:47 -0500, Benjamin Marzinski wrote: > > On Fri, Sep 01, 2023 at 08:02:31PM +0200, mwi...@suse.com wrote: > > > From: Martin Wilck > > > > > > +   vector_foreach_slot(bindings, bdg, i) { > > > +  

Re: [dm-devel] [PATCH 18/21] libmultipath: keep bindings in memory

2023-09-07 Thread Martin Wilck
On Wed, 2023-09-06 at 17:47 -0500, Benjamin Marzinski wrote: > On Fri, Sep 01, 2023 at 08:02:31PM +0200, mwi...@suse.com wrote: > > From: Martin Wilck > > > > Rather than opening the bindings file every time we must retrieve > > a binding, keep the contents in memory and write the file only > >

Re: [dm-devel] [PATCH 18/21] libmultipath: keep bindings in memory

2023-09-06 Thread Benjamin Marzinski
On Fri, Sep 01, 2023 at 08:02:31PM +0200, mwi...@suse.com wrote: > From: Martin Wilck > > Rather than opening the bindings file every time we must retrieve > a binding, keep the contents in memory and write the file only > if additions have been made. This simplifies the code, and should speed

[dm-devel] [PATCH 18/21] libmultipath: keep bindings in memory

2023-09-01 Thread mwilck
From: Martin Wilck Rather than opening the bindings file every time we must retrieve a binding, keep the contents in memory and write the file only if additions have been made. This simplifies the code, and should speed up alias lookups significantly. As a side effect, the aliases will be stored