Re: [dm-devel] [PATCH 3/4] btrfs: zoned: fail mount if the device does not support zone append

2021-04-20 Thread David Sterba
On Mon, Apr 19, 2021 at 09:46:36AM +, Damien Le Moal wrote: > On 2021/04/19 18:41, h...@infradead.org wrote: > > On Mon, Apr 19, 2021 at 09:35:37AM +, Damien Le Moal wrote: > >> This is only to avoid someone from running zoned-btrfs on top of dm-crypt. > >> Without this patch, mount will

Re: [dm-devel] [PATCH 3/4] btrfs: zoned: fail mount if the device does not support zone append

2021-04-19 Thread David Sterba
On Fri, Apr 16, 2021 at 12:05:27PM +0900, Damien Le Moal wrote: > From: Johannes Thumshirn > > For zoned btrfs, zone append is mandatory to write to a sequential write > only zone, otherwise parallel writes to the same zone could result in > unaligned write errors. > > If a zoned block device

Re: [dm-devel] [PATCH 3/4] btrfs: zoned: fail mount if the device does not support zone append

2021-04-19 Thread Damien Le Moal
On 2021/04/19 18:41, h...@infradead.org wrote: > On Mon, Apr 19, 2021 at 09:35:37AM +, Damien Le Moal wrote: >> This is only to avoid someone from running zoned-btrfs on top of dm-crypt. >> Without this patch, mount will be OK and file data writes will also actually >> be >> OK. But all reads

Re: [dm-devel] [PATCH 3/4] btrfs: zoned: fail mount if the device does not support zone append

2021-04-19 Thread Christoph Hellwig
On Fri, Apr 16, 2021 at 06:17:21PM +0200, David Sterba wrote: > On Fri, Apr 16, 2021 at 12:05:27PM +0900, Damien Le Moal wrote: > > From: Johannes Thumshirn > > > > For zoned btrfs, zone append is mandatory to write to a sequential write > > only zone, otherwise parallel writes to the same zone

Re: [dm-devel] [PATCH 3/4] btrfs: zoned: fail mount if the device does not support zone append

2021-04-19 Thread h...@infradead.org
On Mon, Apr 19, 2021 at 09:35:37AM +, Damien Le Moal wrote: > This is only to avoid someone from running zoned-btrfs on top of dm-crypt. > Without this patch, mount will be OK and file data writes will also actually > be > OK. But all reads will miserably fail... I would rather have this

Re: [dm-devel] [PATCH 3/4] btrfs: zoned: fail mount if the device does not support zone append

2021-04-19 Thread Johannes Thumshirn
On 19/04/2021 11:29, Christoph Hellwig wrote: > On Fri, Apr 16, 2021 at 06:17:21PM +0200, David Sterba wrote: >> On Fri, Apr 16, 2021 at 12:05:27PM +0900, Damien Le Moal wrote: >>> From: Johannes Thumshirn >>> >>> For zoned btrfs, zone append is mandatory to write to a sequential write >>> only

Re: [dm-devel] [PATCH 3/4] btrfs: zoned: fail mount if the device does not support zone append

2021-04-19 Thread Damien Le Moal
On 2021/04/19 18:29, Christoph Hellwig wrote: > On Fri, Apr 16, 2021 at 06:17:21PM +0200, David Sterba wrote: >> On Fri, Apr 16, 2021 at 12:05:27PM +0900, Damien Le Moal wrote: >>> From: Johannes Thumshirn >>> >>> For zoned btrfs, zone append is mandatory to write to a sequential write >>> only

[dm-devel] [PATCH 3/4] btrfs: zoned: fail mount if the device does not support zone append

2021-04-15 Thread Damien Le Moal
From: Johannes Thumshirn For zoned btrfs, zone append is mandatory to write to a sequential write only zone, otherwise parallel writes to the same zone could result in unaligned write errors. If a zoned block device does not support zone append (e.g. a dm-crypt zoned device using a non-NULL IV