Re: [dm-devel] [PATCH 56/57] multipathd: push down lock in checkerloop()

2016-05-03 Thread Hannes Reinecke
On 05/04/2016 01:24 AM, Benjamin Marzinski wrote: > On Tue, May 03, 2016 at 05:17:34PM -0500, Benjamin Marzinski wrote: >> On Wed, Apr 27, 2016 at 01:10:57PM +0200, Hannes Reinecke wrote: >>> Instead of grabbing the lock at the start of the checkerloop >>> and releasing it at the end we should be h

Re: [dm-devel] [PATCH 56/57] multipathd: push down lock in checkerloop()

2016-05-03 Thread Hannes Reinecke
On 05/04/2016 12:17 AM, Benjamin Marzinski wrote: > On Wed, Apr 27, 2016 at 01:10:57PM +0200, Hannes Reinecke wrote: >> Instead of grabbing the lock at the start of the checkerloop >> and releasing it at the end we should be holding it only >> during the time when we actually need it. > > I'm pret

Re: [dm-devel] [PATCH 56/57] multipathd: push down lock in checkerloop()

2016-05-03 Thread Benjamin Marzinski
On Tue, May 03, 2016 at 05:17:34PM -0500, Benjamin Marzinski wrote: > On Wed, Apr 27, 2016 at 01:10:57PM +0200, Hannes Reinecke wrote: > > Instead of grabbing the lock at the start of the checkerloop > > and releasing it at the end we should be holding it only > > during the time when we actually n

Re: [dm-devel] [PATCH 56/57] multipathd: push down lock in checkerloop()

2016-05-03 Thread Benjamin Marzinski
On Wed, Apr 27, 2016 at 01:10:57PM +0200, Hannes Reinecke wrote: > Instead of grabbing the lock at the start of the checkerloop > and releasing it at the end we should be holding it only > during the time when we actually need it. I'm pretty sure that this can cause crashes if multipathd reconfigu

[dm-devel] [PATCH 56/57] multipathd: push down lock in checkerloop()

2016-04-27 Thread Hannes Reinecke
Instead of grabbing the lock at the start of the checkerloop and releasing it at the end we should be holding it only during the time when we actually need it. Signed-off-by: Hannes Reinecke --- multipathd/main.c | 136 ++ 1 file changed, 87 in