Re: [dm-devel] [PATCH v2] libmultipath: is_path_valid(): check if device is in use

2022-12-22 Thread Martin Wilck
On Tue, 2022-12-13 at 22:35 +0100, Martin Wilck wrote: > On Tue, 2022-12-13 at 11:50 -0600, Benjamin Marzinski wrote: > > On Tue, Dec 13, 2022 at 08:46:28AM +0100, Martin Wilck wrote: > > > On Tue, 2022-12-06 at 18:37 -0600, Benjamin Marzinski wrote: > > > > > > > is set to "smart", the common

Re: [dm-devel] [PATCH v2] libmultipath: is_path_valid(): check if device is in use

2022-12-13 Thread Martin Wilck
On Tue, 2022-12-13 at 11:50 -0600, Benjamin Marzinski wrote: > On Tue, Dec 13, 2022 at 08:46:28AM +0100, Martin Wilck wrote: > > On Tue, 2022-12-06 at 18:37 -0600, Benjamin Marzinski wrote: > > > > > is set to "smart", the common case will still be > > > that > > > the device is in the wwids

Re: [dm-devel] [PATCH v2] libmultipath: is_path_valid(): check if device is in use

2022-12-13 Thread Benjamin Marzinski
On Tue, Dec 13, 2022 at 08:46:28AM +0100, Martin Wilck wrote: > On Tue, 2022-12-06 at 18:37 -0600, Benjamin Marzinski wrote: > > On Sat, Dec 03, 2022 at 12:43:38AM +0100, mwi...@suse.com wrote: > > > From: Martin Wilck > > > > > > To check whether we will be able to add a given device can be

Re: [dm-devel] [PATCH v2] libmultipath: is_path_valid(): check if device is in use

2022-12-12 Thread Martin Wilck
On Tue, 2022-12-06 at 18:37 -0600, Benjamin Marzinski wrote: > On Sat, Dec 03, 2022 at 12:43:38AM +0100, mwi...@suse.com wrote: > > From: Martin Wilck > > > > To check whether we will be able to add a given device can be part > > of a multipath map, we have two tests in check_path_valid(): > >

Re: [dm-devel] [PATCH v2] libmultipath: is_path_valid(): check if device is in use

2022-12-06 Thread Benjamin Marzinski
On Sat, Dec 03, 2022 at 12:43:38AM +0100, mwi...@suse.com wrote: > From: Martin Wilck > > To check whether we will be able to add a given device can be part > of a multipath map, we have two tests in check_path_valid(): > released_to_systemd() and the O_EXCL test. The former isn't helpful > if

Re: [dm-devel] [PATCH v2] libmultipath: is_path_valid(): check if device is in use

2022-12-05 Thread Martin Wilck
On Sat, 2022-12-03 at 00:43 +0100, mwi...@suse.com wrote: > From: Martin Wilck > > To check whether we will be able to add a given device can be part > of a multipath map, we have two tests in check_path_valid(): > released_to_systemd() and the O_EXCL test. The former isn't helpful > if

[dm-devel] [PATCH v2] libmultipath: is_path_valid(): check if device is in use

2022-12-02 Thread mwilck
From: Martin Wilck To check whether we will be able to add a given device can be part of a multipath map, we have two tests in check_path_valid(): released_to_systemd() and the O_EXCL test. The former isn't helpful if "multipath -u" is called for the first time for a given device, and the latter