Re: [dm-devel] [PATCH v3] dm: don't allow ioctls to targets that don't map to whole devices

2017-02-03 Thread Bart Van Assche
On Fri, 2017-02-03 at 19:17 +0100, Johannes Thumshirn wrote: > Forgotten git add? git commit --amend without git add is such a classic > mistake on my side as well :-/ Are you familiar with the -a option of git commit? Just run git commit -a --amend Bart. -- dm-devel mailing list

Re: [dm-devel] [PATCH v3] dm: don't allow ioctls to targets that don't map to whole devices

2017-02-03 Thread Johannes Thumshirn
On 02/03/2017 05:41 PM, Christoph Hellwig wrote: On Fri, Feb 03, 2017 at 11:39:22AM -0500, Mike Snitzer wrote: I assume you meant for v3 to remove the newline? ;) I did. And I swear I did edit the file, but I guess the ammend didn't work. I guess it's time for the weekend.. I'll resend

Re: [dm-devel] [PATCH v3] dm: don't allow ioctls to targets that don't map to whole devices

2017-02-03 Thread Paolo Bonzini
On 03/02/2017 08:37, Christoph Hellwig wrote: > .. at least for unprivileged users. Before we called into the SCSI > ioctl code to allow excemptions for a few SCSI passthrough ioctls, > but this is pretty unsafe and except for this call dm knows nothing > about SCSI ioctls. > > As the SCSI

Re: [dm-devel] [PATCH v3] dm: don't allow ioctls to targets that don't map to whole devices

2017-02-03 Thread Christoph Hellwig
On Fri, Feb 03, 2017 at 11:39:22AM -0500, Mike Snitzer wrote: > I assume you meant for v3 to remove the newline? ;) I did. And I swear I did edit the file, but I guess the ammend didn't work. I guess it's time for the weekend.. I'll resend after I got some rest. -- dm-devel mailing list

Re: [dm-devel] [PATCH v3] dm: don't allow ioctls to targets that don't map to whole devices

2017-02-03 Thread Mike Snitzer
On Fri, Feb 03 2017 at 11:37am -0500, Christoph Hellwig wrote: > .. at least for unprivileged users. Before we called into the SCSI > ioctl code to allow excemptions for a few SCSI passthrough ioctls, > but this is pretty unsafe and except for this call dm knows nothing > about

[dm-devel] [PATCH v3] dm: don't allow ioctls to targets that don't map to whole devices

2017-02-03 Thread Christoph Hellwig
.. at least for unprivileged users. Before we called into the SCSI ioctl code to allow excemptions for a few SCSI passthrough ioctls, but this is pretty unsafe and except for this call dm knows nothing about SCSI ioctls. As the SCSI ioctl code is now optional, we really don't want to drag it in