Re: [dm-devel] [PATCH v3 2/3] LoadPin: Enable loading from trusted dm-verity devices

2022-05-17 Thread Matthias Kaehlcke
On Mon, May 16, 2022 at 08:44:37PM -0700, Kees Cook wrote: > On Mon, May 16, 2022 at 11:17:44AM -0700, Matthias Kaehlcke wrote: > > On Fri, May 13, 2022 at 03:36:26PM -0700, Kees Cook wrote: > > > > > > > > > On May 4, 2022 12:54:18 PM PDT, Matthias Kaehlcke > > > wrote: > > > >Extend LoadPin t

Re: [dm-devel] [PATCH v3 2/3] LoadPin: Enable loading from trusted dm-verity devices

2022-05-16 Thread Kees Cook
On Mon, May 16, 2022 at 11:17:44AM -0700, Matthias Kaehlcke wrote: > On Fri, May 13, 2022 at 03:36:26PM -0700, Kees Cook wrote: > > > > > > On May 4, 2022 12:54:18 PM PDT, Matthias Kaehlcke wrote: > > >Extend LoadPin to allow loading of kernel files from trusted dm-verity [1] > > >devices. > > >

Re: [dm-devel] [PATCH v3 2/3] LoadPin: Enable loading from trusted dm-verity devices

2022-05-16 Thread Matthias Kaehlcke
Hi Kees, thanks for the review! On Fri, May 13, 2022 at 03:36:26PM -0700, Kees Cook wrote: > > > On May 4, 2022 12:54:18 PM PDT, Matthias Kaehlcke wrote: > >Extend LoadPin to allow loading of kernel files from trusted dm-verity [1] > >devices. > > > >This change adds the concept of trusted ver

Re: [dm-devel] [PATCH v3 2/3] LoadPin: Enable loading from trusted dm-verity devices

2022-05-13 Thread Kees Cook
On May 4, 2022 12:54:18 PM PDT, Matthias Kaehlcke wrote: >Extend LoadPin to allow loading of kernel files from trusted dm-verity [1] >devices. > >This change adds the concept of trusted verity devices to LoadPin. LoadPin >maintains a list of root digests of verity devices it considers trusted.

Re: [dm-devel] [PATCH v3 2/3] LoadPin: Enable loading from trusted dm-verity devices

2022-05-13 Thread Kees Cook
On May 13, 2022 9:32:12 AM PDT, Mike Snitzer wrote: >On Wed, May 04 2022 at 3:54P -0400, >Matthias Kaehlcke wrote: > >> Extend LoadPin to allow loading of kernel files from trusted dm-verity [1] >> devices. >> >> This change adds the concept of trusted verity devices to LoadPin. LoadPin >> m

Re: [dm-devel] [PATCH v3 2/3] LoadPin: Enable loading from trusted dm-verity devices

2022-05-13 Thread Matthias Kaehlcke
On Fri, May 13, 2022 at 12:32:12PM -0400, Mike Snitzer wrote: > On Wed, May 04 2022 at 3:54P -0400, > Matthias Kaehlcke wrote: > > > Extend LoadPin to allow loading of kernel files from trusted dm-verity [1] > > devices. > > > > This change adds the concept of trusted verity devices to LoadPin.

Re: [dm-devel] [PATCH v3 2/3] LoadPin: Enable loading from trusted dm-verity devices

2022-05-13 Thread Mike Snitzer
On Wed, May 04 2022 at 3:54P -0400, Matthias Kaehlcke wrote: > Extend LoadPin to allow loading of kernel files from trusted dm-verity [1] > devices. > > This change adds the concept of trusted verity devices to LoadPin. LoadPin > maintains a list of root digests of verity devices it considers t

Re: [dm-devel] [PATCH v3 2/3] LoadPin: Enable loading from trusted dm-verity devices

2022-05-04 Thread kernel test robot
Hi Matthias, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on device-mapper-dm/for-next] [also build test WARNING on song-md/md-next kees/for-next/pstore linus/master v5.18-rc5 next-20220504] [If your patch is applied to the wrong git tree, kindly drop us a note

[dm-devel] [PATCH v3 2/3] LoadPin: Enable loading from trusted dm-verity devices

2022-05-04 Thread Matthias Kaehlcke
Extend LoadPin to allow loading of kernel files from trusted dm-verity [1] devices. This change adds the concept of trusted verity devices to LoadPin. LoadPin maintains a list of root digests of verity devices it considers trusted. Userspace can populate this list through an ioctl on the new LoadP