Re: [dm-devel] [PATCH v7 1/3] block: add blk_mq_is_queue_frozen()

2021-03-15 Thread Sergei Shtepa
The 03/14/2021 12:14, Christoph Hellwig wrote: > On Fri, Mar 12, 2021 at 02:06:41PM -0500, Mike Snitzer wrote: > > This is returning a frozen state that is immediately stale. I don't > > think any code calling this is providing the guarantees you think it > > does due to the racey nature of this

Re: [dm-devel] [PATCH v7 1/3] block: add blk_mq_is_queue_frozen()

2021-03-14 Thread Christoph Hellwig
On Fri, Mar 12, 2021 at 02:06:41PM -0500, Mike Snitzer wrote: > This is returning a frozen state that is immediately stale. I don't > think any code calling this is providing the guarantees you think it > does due to the racey nature of this state once the mutex is dropped. The code only uses it

[dm-devel] [PATCH v7 1/3] block: add blk_mq_is_queue_frozen()

2021-03-12 Thread Sergei Shtepa
blk_mq_is_queue_frozen() allow to assert that the queue is frozen. Signed-off-by: Sergei Shtepa --- block/blk-mq.c | 13 + include/linux/blk-mq.h | 1 + 2 files changed, 14 insertions(+) diff --git a/block/blk-mq.c b/block/blk-mq.c index d4d7c1caa439..2f188a865024 100644

Re: [dm-devel] [PATCH v7 1/3] block: add blk_mq_is_queue_frozen()

2021-03-12 Thread Mike Snitzer
On Fri, Mar 12 2021 at 10:44am -0500, Sergei Shtepa wrote: > blk_mq_is_queue_frozen() allow to assert that the queue is frozen. > > Signed-off-by: Sergei Shtepa > --- > block/blk-mq.c | 13 + > include/linux/blk-mq.h | 1 + > 2 files changed, 14 insertions(+) > > diff