Re: [dm-devel] [RFC PATCH 08/11] block: use per-task poll context to implement bio based io poll

2021-03-18 Thread Mike Snitzer
On Wed, Mar 17 2021 at 3:19am -0400, Ming Lei wrote: > On Wed, Mar 17, 2021 at 11:49:00AM +0800, JeffleXu wrote: > > > > > > On 3/16/21 7:00 PM, JeffleXu wrote: > > > > > > > > > On 3/16/21 3:17 PM, Ming Lei wrote: > > >> On Tue, Mar 16, 2021 at 02:46:08PM +0800, JeffleXu wrote: > > >>> It

Re: [dm-devel] [RFC PATCH 08/11] block: use per-task poll context to implement bio based io poll

2021-03-18 Thread JeffleXu
On 3/17/21 10:54 AM, Ming Lei wrote: > On Tue, Mar 16, 2021 at 04:52:36PM +0800, JeffleXu wrote: >> >> >> On 3/16/21 3:17 PM, Ming Lei wrote: >>> On Tue, Mar 16, 2021 at 02:46:08PM +0800, JeffleXu wrote: It is a giant progress to gather all split bios that need to be polled in a

Re: [dm-devel] [RFC PATCH 08/11] block: use per-task poll context to implement bio based io poll

2021-03-18 Thread JeffleXu
On 3/16/21 7:00 PM, JeffleXu wrote: > > > On 3/16/21 3:17 PM, Ming Lei wrote: >> On Tue, Mar 16, 2021 at 02:46:08PM +0800, JeffleXu wrote: >>> It is a giant progress to gather all split bios that need to be polled >>> in a per-task queue. Still some comments below. >>> >>> >>> On 3/16/21

Re: [dm-devel] [RFC PATCH 08/11] block: use per-task poll context to implement bio based io poll

2021-03-17 Thread Ming Lei
On Wed, Mar 17, 2021 at 11:49:00AM +0800, JeffleXu wrote: > > > On 3/16/21 7:00 PM, JeffleXu wrote: > > > > > > On 3/16/21 3:17 PM, Ming Lei wrote: > >> On Tue, Mar 16, 2021 at 02:46:08PM +0800, JeffleXu wrote: > >>> It is a giant progress to gather all split bios that need to be polled > >>>

Re: [dm-devel] [RFC PATCH 08/11] block: use per-task poll context to implement bio based io poll

2021-03-17 Thread Ming Lei
On Wed, Mar 17, 2021 at 11:53:12AM +0800, JeffleXu wrote: > > > On 3/17/21 10:54 AM, Ming Lei wrote: > > On Tue, Mar 16, 2021 at 04:52:36PM +0800, JeffleXu wrote: > >> > >> > >> On 3/16/21 3:17 PM, Ming Lei wrote: > >>> On Tue, Mar 16, 2021 at 02:46:08PM +0800, JeffleXu wrote: > It is a

Re: [dm-devel] [RFC PATCH 08/11] block: use per-task poll context to implement bio based io poll

2021-03-16 Thread Ming Lei
On Tue, Mar 16, 2021 at 07:00:49PM +0800, JeffleXu wrote: > > > On 3/16/21 3:17 PM, Ming Lei wrote: > > On Tue, Mar 16, 2021 at 02:46:08PM +0800, JeffleXu wrote: > >> It is a giant progress to gather all split bios that need to be polled > >> in a per-task queue. Still some comments below. > >>

Re: [dm-devel] [RFC PATCH 08/11] block: use per-task poll context to implement bio based io poll

2021-03-16 Thread Ming Lei
On Tue, Mar 16, 2021 at 04:52:36PM +0800, JeffleXu wrote: > > > On 3/16/21 3:17 PM, Ming Lei wrote: > > On Tue, Mar 16, 2021 at 02:46:08PM +0800, JeffleXu wrote: > >> It is a giant progress to gather all split bios that need to be polled > >> in a per-task queue. Still some comments below. > >>

Re: [dm-devel] [RFC PATCH 08/11] block: use per-task poll context to implement bio based io poll

2021-03-16 Thread JeffleXu
On 3/16/21 3:17 PM, Ming Lei wrote: > On Tue, Mar 16, 2021 at 02:46:08PM +0800, JeffleXu wrote: >> It is a giant progress to gather all split bios that need to be polled >> in a per-task queue. Still some comments below. >> >> >> On 3/16/21 11:15 AM, Ming Lei wrote: >>> Currently bio based IO

Re: [dm-devel] [RFC PATCH 08/11] block: use per-task poll context to implement bio based io poll

2021-03-16 Thread JeffleXu
On 3/16/21 3:17 PM, Ming Lei wrote: > On Tue, Mar 16, 2021 at 02:46:08PM +0800, JeffleXu wrote: >> It is a giant progress to gather all split bios that need to be polled >> in a per-task queue. Still some comments below. >> >> >> On 3/16/21 11:15 AM, Ming Lei wrote: >>> Currently bio based IO

Re: [dm-devel] [RFC PATCH 08/11] block: use per-task poll context to implement bio based io poll

2021-03-16 Thread Ming Lei
On Tue, Mar 16, 2021 at 02:46:08PM +0800, JeffleXu wrote: > It is a giant progress to gather all split bios that need to be polled > in a per-task queue. Still some comments below. > > > On 3/16/21 11:15 AM, Ming Lei wrote: > > Currently bio based IO poll needs to poll all hw queue blindly, this

Re: [dm-devel] [RFC PATCH 08/11] block: use per-task poll context to implement bio based io poll

2021-03-16 Thread JeffleXu
It is a giant progress to gather all split bios that need to be polled in a per-task queue. Still some comments below. On 3/16/21 11:15 AM, Ming Lei wrote: > Currently bio based IO poll needs to poll all hw queue blindly, this way > is very inefficient, and the big reason is that we can't pass

[dm-devel] [RFC PATCH 08/11] block: use per-task poll context to implement bio based io poll

2021-03-15 Thread Ming Lei
Currently bio based IO poll needs to poll all hw queue blindly, this way is very inefficient, and the big reason is that we can't pass bio submission result to io poll task. In IO submission context, store associated underlying bios into the submission queue and save 'cookie' poll data in