Re: [dm-devel] device mapper and the BLKFLSBUF ioctl

2016-10-25 Thread Christoph Hellwig
I think the right fix is to kill off the BLKFLSBUF special case in brd. Yes, it break compatibility - but in this case the compatibility breaks more than it helps. -- dm-devel mailing list dm-devel@redhat.com https://www.redhat.com/mailman/listinfo/dm-devel

Re: [dm-devel] device mapper and the BLKFLSBUF ioctl

2016-10-24 Thread Mike Snitzer
On Fri, Oct 21 2016 at 4:18P -0400, Mikulas Patocka wrote: > > > On Fri, 21 Oct 2016, Mike Snitzer wrote: > > > On Fri, Oct 21 2016 at 2:33pm -0400, > > Mikulas Patocka wrote: > > > > > Hi > > > > > > I found a bug in dm regarding the BLKFLSBUF ioctl. > > > > > > The BLKFLSBUF ioctl can

Re: [dm-devel] device mapper and the BLKFLSBUF ioctl

2016-10-21 Thread Mikulas Patocka
On Fri, 21 Oct 2016, Mike Snitzer wrote: > On Fri, Oct 21 2016 at 2:33pm -0400, > Mikulas Patocka wrote: > > > Hi > > > > I found a bug in dm regarding the BLKFLSBUF ioctl. > > > > The BLKFLSBUF ioctl can be called on a block device and it flushes the > > buffer cache. There is one excepti

Re: [dm-devel] device mapper and the BLKFLSBUF ioctl

2016-10-21 Thread Mike Snitzer
On Fri, Oct 21 2016 at 2:33pm -0400, Mikulas Patocka wrote: > Hi > > I found a bug in dm regarding the BLKFLSBUF ioctl. > > The BLKFLSBUF ioctl can be called on a block device and it flushes the > buffer cache. There is one exception - when it is called on ramdisk, it > actually destroys all

[dm-devel] device mapper and the BLKFLSBUF ioctl

2016-10-21 Thread Mikulas Patocka
Hi I found a bug in dm regarding the BLKFLSBUF ioctl. The BLKFLSBUF ioctl can be called on a block device and it flushes the buffer cache. There is one exception - when it is called on ramdisk, it actually destroys all ramdisk data (it works like a discard on the full device). The device mapp