Re: [dm-devel] dm-integrity: Fix flush with external metadata device

2021-01-08 Thread Mikulas Patocka
On Fri, 8 Jan 2021, Mike Snitzer wrote: > > > Seems like a pretty bad oversight... but shouldn't you also make sure to > > > flush the data device _before_ the metadata is flushed? > > > > > > Mike > > > > I think, ordering is not a problem. > > > > A disk may flush its cache spontaneously

Re: [dm-devel] dm-integrity: Fix flush with external metadata device

2021-01-08 Thread Mike Snitzer
On Fri, Jan 08 2021 at 11:12am -0500, Mikulas Patocka wrote: > > > On Mon, 4 Jan 2021, Mike Snitzer wrote: > > > On Sun, Dec 20 2020 at 8:02am -0500, > > Lukas Straub wrote: > > > > > With an external metadata device, flush requests aren't passed down > > > to the data device. > > > > > >

Re: [dm-devel] dm-integrity: Fix flush with external metadata device

2021-01-08 Thread Mikulas Patocka
On Mon, 4 Jan 2021, Mike Snitzer wrote: > On Sun, Dec 20 2020 at 8:02am -0500, > Lukas Straub wrote: > > > With an external metadata device, flush requests aren't passed down > > to the data device. > > > > Fix this by issuing flush in the right places: In integrity_commit > > when not in

Re: [dm-devel] dm-integrity: Fix flush with external metadata device

2021-01-04 Thread Mike Snitzer
On Sun, Dec 20 2020 at 8:02am -0500, Lukas Straub wrote: > With an external metadata device, flush requests aren't passed down > to the data device. > > Fix this by issuing flush in the right places: In integrity_commit > when not in journal mode, in do_journal_write after writing the >