Re: [dm-devel] dm table: add support for secure erase forwarding [was: Re: Adaptation secure erase forwarding for 4.1x kernels]

2018-03-28 Thread Denis Semakin
Hi. >> Also, will it be usefully to add a "get...()" function for >> num_secure_erase_bios? Let's say get_num_secure_erase_bios(struct dm_target >> ); >> As it's done for num_discard_bios... > >Yes, it is required. I'll share a link to the final patch shortly, I've >still attributed the work to

Re: [dm-devel] dm table: add support for secure erase forwarding [was: Re: Adaptation secure erase forwarding for 4.1x kernels]

2018-03-28 Thread Denis Semakin
>> >> BTW, please look into your text editor's settings: seems your patches >> are using spaces rather than tabs (and you aren't even using 8 spaces?) > > It's not blame of editor (I prefer to use git), it's email client re-formats > a message. I prefer to use vim of course > Next time I'll

Re: [dm-devel] dm table: add support for secure erase forwarding [was: Re: Adaptation secure erase forwarding for 4.1x kernels]

2018-03-27 Thread Denis Semakin
Also, will it be usefully to add a "get...()" function for num_secure_erase_bios? Let's say get_num_secure_erase_bios(struct dm_target ); As it's done for num_discard_bios... - Исходное сообщение - От: "snitzer" Кому: "Denis Semakin" Копия: "dm-devel"

Re: [dm-devel] dm table: add support for secure erase forwarding [was: Re: Adaptation secure erase forwarding for 4.1x kernels]

2018-03-26 Thread Mike Snitzer
On Mon, Mar 26 2018 at 10:12am -0400, Denis Semakin wrote: > Also, will it be usefully to add a "get...()" function for > num_secure_erase_bios? Let's say get_num_secure_erase_bios(struct dm_target > ); > As it's done for num_discard_bios... Yes, it is required. I'll

Re: [dm-devel] dm table: add support for secure erase forwarding [was: Re: Adaptation secure erase forwarding for 4.1x kernels]

2018-03-26 Thread Denis Semakin
Hi. Here is a full patch for adding num_secure_erase_bios field in struct dm_targer for linear DMs and QUEUE_FLAG_SECERASE forwarding. Could you please review. Thanks. diff --git a/drivers/md/dm-linear.c b/drivers/md/dm-linear.c index d5f8eff..ff751b0 100644 --- a/drivers/md/dm-linear.c +++

Re: [dm-devel] dm table: add support for secure erase forwarding [was: Re: Adaptation secure erase forwarding for 4.1x kernels]

2018-03-26 Thread Denis Semakin
Hi, sorry for my misunderstanding. >Thinking further, it is absolutely needed, otherwise dm-stripe.c won't >be able to use the optimization I mentioned above. In addition, other >targets shouldn't be getting REQ_OP_SECURE_ERASE unless there is a real >need. ti->num_secure_erase_bios will allow

Re: [dm-devel] dm table: add support for secure erase forwarding [was: Re: Adaptation secure erase forwarding for 4.1x kernels]

2018-03-23 Thread Mike Snitzer
On Fri, Mar 23 2018 at 10:47am -0400, Denis Semakin wrote: > >I'd feel safer about having targets opt-in with setting (a new) > >ti->num_secure_erase_bios. > May be add a new field "bool secure_erase_supported:1" in dm_target structure > instead? > And set up it "true"

Re: [dm-devel] dm table: add support for secure erase forwarding [was: Re: Adaptation secure erase forwarding for 4.1x kernels]

2018-03-23 Thread Mike Snitzer
On Fri, Mar 23 2018 at 4:14am -0400, Denis Semakin wrote: > Hi. > Soon or later everybody start to think about security. > One of the most frequently requirement is 100% reliable data deletion from > any device in case of compromising or loss or theft. > > For this,