Re: [dm-devel] why does __split_and_process_bio use bio_clone_bioset?

2018-06-16 Thread Christoph Hellwig
On Fri, Jun 15, 2018 at 02:26:31PM -0400, Mike Snitzer wrote: > Yes. Already queued, likely won't send to Linus until end of next week > though.. unless you want it upstream sooner? We only really need it as a baseline for the multi-page bio work, so no real rush. I think I'll just include it wi

Re: [dm-devel] why does __split_and_process_bio use bio_clone_bioset?

2018-06-15 Thread Mike Snitzer
On Fri, Jun 15 2018 at 3:38am -0400, Christoph Hellwig wrote: > On Thu, Jun 14, 2018 at 04:08:09PM -0400, Mike Snitzer wrote: > > The patch below seems to work fine (given quick testing).. It also has a > > side-effect of not breaking integrity support (which commit 18a25da8 > > appears to do be

Re: [dm-devel] why does __split_and_process_bio use bio_clone_bioset?

2018-06-15 Thread Christoph Hellwig
On Thu, Jun 14, 2018 at 04:08:09PM -0400, Mike Snitzer wrote: > The patch below seems to work fine (given quick testing).. It also has a > side-effect of not breaking integrity support (which commit 18a25da8 > appears to do because it isn't accounting for any of the integrity stuff > bio_split, or

Re: [dm-devel] why does __split_and_process_bio use bio_clone_bioset?

2018-06-14 Thread NeilBrown
On Thu, Jun 14 2018, Mike Snitzer wrote: > On Thu, Jun 14 2018 at 2:12P -0400, > Mike Snitzer wrote: > >> On Thu, Jun 14 2018 at 4:19am -0400, >> Christoph Hellwig wrote: >> >> > Hi Neil, >> > >> > In commit 18a25da8 ("dm: ensure bio submission follows a depth-first >> > tree walk") you've a

Re: [dm-devel] why does __split_and_process_bio use bio_clone_bioset?

2018-06-14 Thread Mike Snitzer
On Thu, Jun 14 2018 at 2:12P -0400, Mike Snitzer wrote: > On Thu, Jun 14 2018 at 4:19am -0400, > Christoph Hellwig wrote: > > > Hi Neil, > > > > In commit 18a25da8 ("dm: ensure bio submission follows a depth-first > > tree walk") you've added a call to bio_clone_bioset to > > __split_and_pro

Re: [dm-devel] why does __split_and_process_bio use bio_clone_bioset?

2018-06-14 Thread Mike Snitzer
On Thu, Jun 14 2018 at 4:19am -0400, Christoph Hellwig wrote: > Hi Neil, > > In commit 18a25da8 ("dm: ensure bio submission follows a depth-first > tree walk") you've added a call to bio_clone_bioset to > __split_and_process_bio. Unlike all other bio splitting code this > actually allocates a

[dm-devel] why does __split_and_process_bio use bio_clone_bioset?

2018-06-14 Thread Christoph Hellwig
Hi Neil, In commit 18a25da8 ("dm: ensure bio submission follows a depth-first tree walk") you've added a call to bio_clone_bioset to __split_and_process_bio. Unlike all other bio splitting code this actually allocates a new bio_vec array instead of just splitting the bio and the iterator. I can'