Re: [RFC PATCH v5 1/1] Add dm verity root hash pkcs7 sig validation.

2019-08-13 Thread Jaskaran Singh Khurana
Hello Mike, On Tue, 25 Jun 2019, Mike Snitzer wrote: On Wed, Jun 19 2019 at 3:10pm -0400, Jaskaran Khurana wrote: The verification is to support cases where the roothash is not secured by Trusted Boot, UEFI Secureboot or similar technologies. One of the use cases for this is for dm-verity

Re: [RFC PATCH v5 1/1] Add dm verity root hash pkcs7 sig validation.

2019-06-27 Thread Milan Broz
On 28/06/2019 05:00, Eric Biggers wrote: >> Hello Eric, >> >> This started with a config (see V4). We didnot want scripts that pass this >> parameter to suddenly stop working if for some reason the verification is >> turned off so the optional parameter was just parsed and no validation >>

Re: [RFC PATCH v5 1/1] Add dm verity root hash pkcs7 sig validation.

2019-06-27 Thread Eric Biggers
Hi Jaskaran, On Thu, Jun 27, 2019 at 06:49:58PM -0700, Jaskaran Singh Khurana wrote: > > > On Thu, 27 Jun 2019, Eric Biggers wrote: > > > Hi Jaskaran, one comment (I haven't reviewed this in detail): > > > > On Wed, Jun 19, 2019 at 12:10:48PM -0700, Jaskaran Khurana wrote: > > > diff --git

Re: [RFC PATCH v5 1/1] Add dm verity root hash pkcs7 sig validation.

2019-06-27 Thread Jaskaran Singh Khurana
On Thu, 27 Jun 2019, Eric Biggers wrote: Hi Jaskaran, one comment (I haven't reviewed this in detail): On Wed, Jun 19, 2019 at 12:10:48PM -0700, Jaskaran Khurana wrote: diff --git a/drivers/md/Kconfig b/drivers/md/Kconfig index db269a348b20..2d658a3512cb 100644 --- a/drivers/md/Kconfig +++

Re: [RFC PATCH v5 1/1] Add dm verity root hash pkcs7 sig validation.

2019-06-27 Thread Milan Broz
Hi, I tried to test test the patch, two comments below. On 19/06/2019 21:10, Jaskaran Khurana wrote: > The verification is to support cases where the roothash is not secured by > Trusted Boot, UEFI Secureboot or similar technologies. > One of the use cases for this is for dm-verity volumes

Re: [RFC PATCH v5 1/1] Add dm verity root hash pkcs7 sig validation.

2019-06-25 Thread Milan Broz
On 25/06/2019 20:20, Mike Snitzer wrote: > On Wed, Jun 19 2019 at 3:10pm -0400, > Jaskaran Khurana wrote: > >> The verification is to support cases where the roothash is not secured by >> Trusted Boot, UEFI Secureboot or similar technologies. >> One of the use cases for this is for dm-verity

Re: [RFC PATCH v5 1/1] Add dm verity root hash pkcs7 sig validation.

2019-06-25 Thread Mike Snitzer
On Wed, Jun 19 2019 at 3:10pm -0400, Jaskaran Khurana wrote: > The verification is to support cases where the roothash is not secured by > Trusted Boot, UEFI Secureboot or similar technologies. > One of the use cases for this is for dm-verity volumes mounted after boot, > the root hash provided