Re: [dm-devel] [PATCH 0/2] multipath-tools/libmultipath: Support for the native NVMe Ioctl command and add args min_avg_latency for path_latency.

2017-07-18 Thread Yang Feng
Hi Xose, Thanks for your reviews The up-to-date patch will be sent later. Regards! -Yang On 2017/7/18 7:00, Xose Vazquez Perez wrote: > On 07/17/2017 04:23 AM, Yang Feng wrote: > >> I think there is a mistake: >> 1. In fact, the tur checker feature has never been removed. The tur checker >>

Re: [dm-devel] [PATCH 0/2] multipath-tools/libmultipath: Support for the native NVMe Ioctl command and add args min_avg_latency for path_latency.

2017-07-16 Thread Yang Feng
Hi Martin, Thanks for your reviews. I think there is a mistake: 1. In fact, the tur checker feature has never been removed. The tur checker has just been renamed to "ping" checker and the keep alive command checker feature is added into this checker. So, the renamed checker remains "tur" and add

Re: [dm-devel] [PATCH 0/2] multipath-tools/libmultipath: Support for the native NVMe Ioctl command and add args min_avg_latency for path_latency.

2017-07-14 Thread Martin Wilck
On Fri, 2017-07-14 at 09:47 +0800, Yang Feng wrote: > Hi Xose, > > But tur can not support NVMe device, and if the default checker > change to ping, > then it can support NVMe device by a keep alive command and SCSI > device by a > tur command. I agree with Xose. This is what we have the hwtable

Re: [dm-devel] [PATCH 0/2] multipath-tools/libmultipath: Support for the native NVMe Ioctl command and add args min_avg_latency for path_latency.

2017-07-13 Thread Yang Feng
Hi Xose, But tur can not support NVMe device, and if the default checker change to ping, then it can support NVMe device by a keep alive command and SCSI device by a tur command. Regards! -Yang On 2017/7/14 0:44, Xose Vazquez Perez wrote: > On 07/13/2017 09:51 AM, Yang Feng wrote: > >> [...]

Re: [dm-devel] [PATCH 0/2] multipath-tools/libmultipath: Support for the native NVMe Ioctl command and add args min_avg_latency for path_latency.

2017-07-13 Thread Xose Vazquez Perez
On 07/13/2017 09:51 AM, Yang Feng wrote: > [...] >In the checkers, delete the file tur.c and create the new file ping.c: > ping.c can support the native NVMe Keep Alive Ioctl command to the nvme > device, and can support the SG TUR Ioctl command to the scsi device. > [...] > delete mode