Re: [dm-devel] [PATCH 3/3] dm-ioctl: report event number in DM_LIST_DEVICES

2017-09-19 Thread Andy Grover
On 09/16/2017 07:41 PM, Eugene Syromiatnikov wrote: + event_nr = align_ptr(((void *) (nl + 1)) + strlen(hc->name) + 1); If my understanding is correct, (nl + 1) differs between 32-bit and 64-bit kernels (as the structure contains of one 8-byte and one 4-byte field), so

Re: [dm-devel] [PATCH 3/3] dm-ioctl: report event number in DM_LIST_DEVICES

2017-09-18 Thread Eugene Syromiatnikov
> + event_nr = align_ptr(((void *) (nl + 1)) + > strlen(hc->name) + 1); If my understanding is correct, (nl + 1) differs between 32-bit and 64-bit kernels (as the structure contains of one 8-byte and one 4-byte field), so this logic is probably broken for compat. -- dm-devel