Re: [dm-devel] [PATCH 56/57] multipathd: push down lock in checkerloop()

2016-05-04 Thread Hannes Reinecke
On 05/04/2016 01:24 AM, Benjamin Marzinski wrote: > On Tue, May 03, 2016 at 05:17:34PM -0500, Benjamin Marzinski wrote: >> On Wed, Apr 27, 2016 at 01:10:57PM +0200, Hannes Reinecke wrote: >>> Instead of grabbing the lock at the start of the checkerloop >>> and releasing it at the end we should be

Re: [dm-devel] [PATCH 56/57] multipathd: push down lock in checkerloop()

2016-05-03 Thread Benjamin Marzinski
On Tue, May 03, 2016 at 05:17:34PM -0500, Benjamin Marzinski wrote: > On Wed, Apr 27, 2016 at 01:10:57PM +0200, Hannes Reinecke wrote: > > Instead of grabbing the lock at the start of the checkerloop > > and releasing it at the end we should be holding it only > > during the time when we actually

Re: [dm-devel] [PATCH 56/57] multipathd: push down lock in checkerloop()

2016-05-03 Thread Benjamin Marzinski
On Wed, Apr 27, 2016 at 01:10:57PM +0200, Hannes Reinecke wrote: > Instead of grabbing the lock at the start of the checkerloop > and releasing it at the end we should be holding it only > during the time when we actually need it. I'm pretty sure that this can cause crashes if multipathd