Re: [dm-devel] [PATCH v2 5/5] Input: evdev - Switch to bitmap_zalloc()

2018-06-21 Thread Dmitry Torokhov
On Wed, Jun 20, 2018 at 11:13:21AM +0300, Yury Norov wrote: > On Tue, Jun 19, 2018 at 11:33:16AM -0700, Dmitry Torokhov wrote: > > External Email > > > > On Sat, Jun 16, 2018 at 12:42:31AM +0300, Yury Norov wrote: > > > Hi Andy, > > > > > > On Fri, Jun 15, 2018 at 04:20:17PM +0300, Andy

Re: [dm-devel] [PATCH v2 5/5] Input: evdev - Switch to bitmap_zalloc()

2018-06-20 Thread Dmitry Torokhov
On Sat, Jun 16, 2018 at 12:42:31AM +0300, Yury Norov wrote: > Hi Andy, > > On Fri, Jun 15, 2018 at 04:20:17PM +0300, Andy Shevchenko wrote: > > Switch to bitmap_zalloc() to show clearly what we are allocating. > > Besides that it returns pointer of bitmap type instead of opaque void *. > > > >

Re: [dm-devel] [PATCH v2 5/5] Input: evdev - Switch to bitmap_zalloc()

2018-06-20 Thread Yury Norov
On Tue, Jun 19, 2018 at 11:33:16AM -0700, Dmitry Torokhov wrote: > External Email > > On Sat, Jun 16, 2018 at 12:42:31AM +0300, Yury Norov wrote: > > Hi Andy, > > > > On Fri, Jun 15, 2018 at 04:20:17PM +0300, Andy Shevchenko wrote: > > > Switch to bitmap_zalloc() to show clearly what we are

Re: [dm-devel] [PATCH v2 5/5] Input: evdev - Switch to bitmap_zalloc()

2018-06-19 Thread Andy Shevchenko
On Sat, 2018-06-16 at 12:16 -0700, Joe Perches wrote: > On Sat, 2018-06-16 at 21:45 +0300, Andy Shevchenko wrote: > > On Sat, Jun 16, 2018 at 12:46 AM Yury Norov > om> wrote: > > > On Fri, Jun 15, 2018 at 04:20:17PM +0300, Andy Shevchenko wrote: > > > > Switch to bitmap_zalloc() to show clearly

Re: [dm-devel] [PATCH v2 5/5] Input: evdev - Switch to bitmap_zalloc()

2018-06-18 Thread Joe Perches
On Mon, 2018-06-18 at 22:56 +0300, Andy Shevchenko wrote: > On Mon, Jun 18, 2018 at 6:49 PM, Joe Perches wrote: > > Perhaps bitmap_dup_user [or some better name] could or should > > be one of the helpers. > > Can you help with estimation how many existing users need this kind of > functionality?

Re: [dm-devel] [PATCH v2 5/5] Input: evdev - Switch to bitmap_zalloc()

2018-06-18 Thread Joe Perches
On Mon, 2018-06-18 at 15:02 +0300, Andy Shevchenko wrote: > On Sat, 2018-06-16 at 12:16 -0700, Joe Perches wrote: > > On Sat, 2018-06-16 at 21:45 +0300, Andy Shevchenko wrote: > > > On Sat, Jun 16, 2018 at 12:46 AM Yury Norov > > om> wrote: > > > > On Fri, Jun 15, 2018 at 04:20:17PM +0300, Andy

Re: [dm-devel] [PATCH v2 5/5] Input: evdev - Switch to bitmap_zalloc()

2018-06-18 Thread Andy Shevchenko
On Sat, Jun 16, 2018 at 12:46 AM Yury Norov wrote: > On Fri, Jun 15, 2018 at 04:20:17PM +0300, Andy Shevchenko wrote: > > Switch to bitmap_zalloc() to show clearly what we are allocating. > > Besides that it returns pointer of bitmap type instead of opaque void *. > > + mem =

Re: [dm-devel] [PATCH v2 5/5] Input: evdev - Switch to bitmap_zalloc()

2018-06-18 Thread Yury Norov
Hi Andy, On Fri, Jun 15, 2018 at 04:20:17PM +0300, Andy Shevchenko wrote: > Switch to bitmap_zalloc() to show clearly what we are allocating. > Besides that it returns pointer of bitmap type instead of opaque void *. > > Acked-by: Dmitry Torokhov > Signed-off-by: Andy Shevchenko > --- >

Re: [dm-devel] [PATCH v2 5/5] Input: evdev - Switch to bitmap_zalloc()

2018-06-16 Thread Joe Perches
On Sat, 2018-06-16 at 21:45 +0300, Andy Shevchenko wrote: > On Sat, Jun 16, 2018 at 12:46 AM Yury Norov wrote: > > On Fri, Jun 15, 2018 at 04:20:17PM +0300, Andy Shevchenko wrote: > > > Switch to bitmap_zalloc() to show clearly what we are allocating. > > > Besides that it returns pointer of