Re: [dm-devel] [PATCH v4 07/18] nvme: Fix reservation status related structs

2023-03-21 Thread Mike Christie
On 3/15/23 12:40 AM, Christoph Hellwig wrote: > On Tue, Mar 14, 2023 at 05:23:16PM -0500, Mike Christie wrote: >> We could do separate structs though: > > I suspect that's probably better in the long run, as the [0] notation > is on its way out. Ok. I was able to use the separate structs and then

Re: [dm-devel] [PATCH v4 07/18] nvme: Fix reservation status related structs

2023-03-15 Thread Mike Christie
On 3/14/23 12:15 PM, Christoph Hellwig wrote: > On Fri, Feb 24, 2023 at 11:44:51AM -0600, Mike Christie wrote: >> +__u8resv10[14]; >> +union { >> +struct { >> +__u8rsvd24[40]; >> +struct nvme_registered_ctrl_ext regctl_eds[0]; >> +

Re: [dm-devel] [PATCH v4 07/18] nvme: Fix reservation status related structs

2023-03-14 Thread Christoph Hellwig
On Tue, Mar 14, 2023 at 05:23:16PM -0500, Mike Christie wrote: > We could do separate structs though: I suspect that's probably better in the long run, as the [0] notation is on its way out. -- dm-devel mailing list dm-devel@redhat.com https://listman.redhat.com/mailman/listinfo/dm-devel

Re: [dm-devel] [PATCH v4 07/18] nvme: Fix reservation status related structs

2023-03-14 Thread Christoph Hellwig
On Fri, Feb 24, 2023 at 11:44:51AM -0600, Mike Christie wrote: > + __u8resv10[14]; > + union { > + struct { > + __u8rsvd24[40]; > + struct nvme_registered_ctrl_ext regctl_eds[0]; > + }; > + struct nvme_regis

Re: [dm-devel] [PATCH v4 07/18] nvme: Fix reservation status related structs

2023-03-14 Thread Christoph Hellwig
Looks good: Reviewed-by: Christoph Hellwig -- dm-devel mailing list dm-devel@redhat.com https://listman.redhat.com/mailman/listinfo/dm-devel

Re: [dm-devel] [PATCH v4 07/18] nvme: Fix reservation status related structs

2023-03-05 Thread Chaitanya Kulkarni
On 2/24/2023 9:44 AM, Mike Christie wrote: > This fixes the following issues with the reservation status structs: > > 1. resv10 is bytes 23:10 so it should be 14 bytes. > 2. regctl_ds only supports 64 bit host IDs. > > These are not currently used, but will be in this patchset which adds > suppor