Re: [dm-devel] [RFC PATCH 13/20] libmultipath: print: convert API to generic data type

2018-02-28 Thread Benjamin Marzinski
On Tue, Feb 20, 2018 at 02:26:51PM +0100, Martin Wilck wrote: > Convert higher level API (snprint_multipath_topology() etc) to > using the generic multipath API. This will allow "foreign" > multipath objects that implement the generic API to be printed > exactly like native multipathd objects. >

Re: [dm-devel] [RFC PATCH 17/20] libmultipath/foreign: nvme foreign library

2018-02-28 Thread Benjamin Marzinski
On Tue, Feb 20, 2018 at 02:26:55PM +0100, Martin Wilck wrote: > This still contains stubs for path handling and checking, but it's functional > for printing already. > > Signed-off-by: Martin Wilck > --- > Makefile | 1 + > libmultipath/foreign/Makefile |

Re: [dm-devel] [RFC PATCH 18/20] multipath: use foreign API

2018-02-28 Thread Benjamin Marzinski
On Tue, Feb 20, 2018 at 02:26:56PM +0100, Martin Wilck wrote: > Use the "foreign" code to print information about multipath maps > owned by foreign libraries in print mode (multipath -ll, -l). > It's not a big deal, but I assume your is_claimed_by_foreign() call in pathinfo() from your next

Re: [dm-devel] [RFC PATCH 19/20] multipathd: use foreign API

2018-02-28 Thread Benjamin Marzinski
On Tue, Feb 20, 2018 at 02:26:57PM +0100, Martin Wilck wrote: > Call into the foreign library code when paths are discovered, uevents > are received, and in the checker loop. Furthermore, use the foreign > code to print information in the "multipathd show paths", "multipathd > show maps", and

Re: [dm-devel] [RFC PATCH 20/20] libmultipath: foreign/nvme: implement path display

2018-02-28 Thread Benjamin Marzinski
On Tue, Feb 20, 2018 at 02:26:58PM +0100, Martin Wilck wrote: > implement display of path information for NVMe foreign paths and maps. > With this patch, I get output like this for Linux NVMe soft targets: > > multipathd show topology > sys0:NQN:subsysname