Re: [dm-devel] [patch 4/4] dm-writecache: use new API for flushing

2018-05-31 Thread Mikulas Patocka
On Wed, 30 May 2018, Dan Williams wrote: > > Great find! Thanks for the due diligence. Feel free to add: > > > > Acked-by: Dan Williams > > > > ...on the reworks to unify ARM and x86. > > One more note. The side effect of not using dax_flush() is that you > may end up flushing caches on

Re: [dm-devel] [PATCH] md: dm-crypt: Add Inline Encryption support for dmcrypt

2018-05-31 Thread Ladvine D Almeida
On Monday 28 May 2018 05:33 PM, Milan Broz wrote: > On 05/28/2018 03:01 PM, Ladvine D Almeida wrote: >> This patch adds new option >> -- perform_inline_encrypt >> that set the option inside dmcrypt to use inline encryption for >> the configured mapping. I want to introduce inline encryption

Re: [dm-devel] [patch 4/4] dm-writecache: use new API for flushing

2018-05-31 Thread Mikulas Patocka
On Wed, 30 May 2018, Mike Snitzer wrote: > On Wed, May 30 2018 at 10:09P -0400, > Mikulas Patocka wrote: > > > And what about this? > > #define WC_MODE_PMEM(wc)((wc)->pmem_mode) > > > > The code that I had just allowed the compiler to optimize out > >

Re: [dm-devel] [patch 4/4] dm-writecache: use new API for flushing

2018-05-31 Thread Mike Snitzer
On Thu, May 31 2018 at 4:16am -0400, Mikulas Patocka wrote: > > > On Wed, 30 May 2018, Mike Snitzer wrote: > > > On Wed, May 30 2018 at 10:09P -0400, > > Mikulas Patocka wrote: > > > > > And what about this? > > > #define WC_MODE_PMEM(wc)((wc)->pmem_mode) > > > >

Re: [dm-devel] [patch 4/4] dm-writecache: use new API for flushing

2018-05-31 Thread Dan Williams
On Thu, May 31, 2018 at 8:31 AM, Mikulas Patocka wrote: > > > On Thu, 31 May 2018, Dan Williams wrote: > >> On Thu, May 31, 2018 at 1:19 AM, Mikulas Patocka wrote: >> > >> > >> > On Wed, 30 May 2018, Dan Williams wrote: >> > >> >> > Great find! Thanks for the due diligence. Feel free to add: >>

Re: [dm-devel] [PATCH v2 2/7] dax: change bdev_dax_supported() to support boolean returns

2018-05-31 Thread Darrick J. Wong
On Tue, May 29, 2018 at 04:01:14PM -0600, Ross Zwisler wrote: > On Tue, May 29, 2018 at 02:25:10PM -0700, Darrick J. Wong wrote: > > On Tue, May 29, 2018 at 01:51:01PM -0600, Ross Zwisler wrote: > > > From: Dave Jiang > > > > > > The function return values are confusing with the way the function

Re: [dm-devel] [PATCH -next] dm writecache: fix return value check in writecache_ctr()

2018-05-31 Thread Mike Snitzer
On Thu, May 31 2018 at 7:53am -0400, Wei Yongjun wrote: > Function dm_io_client_create() and dm_kcopyd_client_create() return > ERR_PTR() not NULL in case of error. The NULL test in the return value > check should be replaced with IS_ERR() > > Fixes: 2105231db61b ("dm: add writecache target")

Re: [dm-devel] [PATCH -next] dm writecache: fix return value check in writecache_ctr()

2018-05-31 Thread Mike Snitzer
On Thu, May 31 2018 at 12:02pm -0400, Mike Snitzer wrote: > On Thu, May 31 2018 at 7:53am -0400, > Wei Yongjun wrote: > > > Function dm_io_client_create() and dm_kcopyd_client_create() return > > ERR_PTR() not NULL in case of error. The NULL test in the return value > > check should be

Re: [dm-devel] [PATCH v2 2/7] dax: change bdev_dax_supported() to support boolean returns

2018-05-31 Thread Dave Chinner
On Thu, May 31, 2018 at 06:57:33PM -0700, Dan Williams wrote: > On Thu, May 31, 2018 at 6:26 PM, Dave Chinner wrote: > > On Thu, May 31, 2018 at 12:13:32PM -0700, Darrick J. Wong wrote: > >> On Tue, May 29, 2018 at 04:01:14PM -0600, Ross Zwisler wrote: > >> > On Tue, May 29, 2018 at 02:25:10PM

Re: [dm-devel] [PATCH v2 2/7] dax: change bdev_dax_supported() to support boolean returns

2018-05-31 Thread Dan Williams
On Thu, May 31, 2018 at 6:26 PM, Dave Chinner wrote: > On Thu, May 31, 2018 at 12:13:32PM -0700, Darrick J. Wong wrote: >> On Tue, May 29, 2018 at 04:01:14PM -0600, Ross Zwisler wrote: >> > On Tue, May 29, 2018 at 02:25:10PM -0700, Darrick J. Wong wrote: >> > > On Tue, May 29, 2018 at 01:51:01PM

Re: [dm-devel] [PATCH v2 2/7] dax: change bdev_dax_supported() to support boolean returns

2018-05-31 Thread Dan Williams
On Thu, May 31, 2018 at 7:24 PM, Dave Chinner wrote: > On Thu, May 31, 2018 at 06:57:33PM -0700, Dan Williams wrote: >> On Thu, May 31, 2018 at 6:26 PM, Dave Chinner wrote: >> > On Thu, May 31, 2018 at 12:13:32PM -0700, Darrick J. Wong wrote: >> >> On Tue, May 29, 2018 at 04:01:14PM -0600, Ross

Re: [dm-devel] [PATCH v2 2/7] dax: change bdev_dax_supported() to support boolean returns

2018-05-31 Thread Dave Chinner
On Thu, May 31, 2018 at 12:13:32PM -0700, Darrick J. Wong wrote: > On Tue, May 29, 2018 at 04:01:14PM -0600, Ross Zwisler wrote: > > On Tue, May 29, 2018 at 02:25:10PM -0700, Darrick J. Wong wrote: > > > On Tue, May 29, 2018 at 01:51:01PM -0600, Ross Zwisler wrote: > > > > From: Dave Jiang > > >

Re: [dm-devel] [PATCH v2 2/7] dax: change bdev_dax_supported() to support boolean returns

2018-05-31 Thread Mike Snitzer
On Thu, May 31 2018 at 3:13pm -0400, Darrick J. Wong wrote: > On Tue, May 29, 2018 at 04:01:14PM -0600, Ross Zwisler wrote: > > On Tue, May 29, 2018 at 02:25:10PM -0700, Darrick J. Wong wrote: > > > On Tue, May 29, 2018 at 01:51:01PM -0600, Ross Zwisler wrote: > > > > From: Dave Jiang > > > >

Re: [dm-devel] [PATCH v2 2/7] dax: change bdev_dax_supported() to support boolean returns

2018-05-31 Thread Dan Williams
On Thu, May 31, 2018 at 12:13 PM, Darrick J. Wong wrote: > On Tue, May 29, 2018 at 04:01:14PM -0600, Ross Zwisler wrote: >> On Tue, May 29, 2018 at 02:25:10PM -0700, Darrick J. Wong wrote: >> > On Tue, May 29, 2018 at 01:51:01PM -0600, Ross Zwisler wrote: >> > > From: Dave Jiang >> > > >> > >

Re: [dm-devel] [PATCH v2 2/7] dax: change bdev_dax_supported() to support boolean returns

2018-05-31 Thread Darrick J. Wong
On Thu, May 31, 2018 at 04:52:06PM -0400, Mike Snitzer wrote: > On Thu, May 31 2018 at 3:13pm -0400, > Darrick J. Wong wrote: > > > On Tue, May 29, 2018 at 04:01:14PM -0600, Ross Zwisler wrote: > > > On Tue, May 29, 2018 at 02:25:10PM -0700, Darrick J. Wong wrote: > > > > On Tue, May 29, 2018

Re: [dm-devel] [patch 4/4] dm-writecache: use new API for flushing

2018-05-31 Thread Dan Williams
On Thu, May 31, 2018 at 1:19 AM, Mikulas Patocka wrote: > > > On Wed, 30 May 2018, Dan Williams wrote: > >> > Great find! Thanks for the due diligence. Feel free to add: >> > >> > Acked-by: Dan Williams >> > >> > ...on the reworks to unify ARM and x86. >> >> One more note. The side effect of

Re: [dm-devel] [patch 4/4] dm-writecache: use new API for flushing

2018-05-31 Thread Mikulas Patocka
On Thu, 31 May 2018, Dan Williams wrote: > On Thu, May 31, 2018 at 1:19 AM, Mikulas Patocka wrote: > > > > > > On Wed, 30 May 2018, Dan Williams wrote: > > > >> > Great find! Thanks for the due diligence. Feel free to add: > >> > > >> > Acked-by: Dan Williams > >> > > >> > ...on the