Re: [dm-devel] [PATCH 2/9] libmultipath: strbuf: simple api for growing string buffers

2021-07-26 Thread Benjamin Marzinski
On Thu, Jul 15, 2021 at 12:52:16PM +0200, mwi...@suse.com wrote: > From: Martin Wilck > > Add an API for string buffers that grow in size as text is added. > This API will be useful in several places of the multipath-tools code > base. Add unit tests for these helpers, too. > This looks good.

Re: [dm-devel] [PATCH] dm io: fix comments to align with on-stack plugging

2021-07-26 Thread Xianting Tian
Could I get the comments for the patch?  thanks 在 2021/7/17 下午11:54, Xianting Tian 写道: From: Xianting Tian Ther is no unplugging timer now, on-stack io plugging is used: struct blk_plug plug; blk_start_plug(); submit_batch_of_io(); blk_finish_plug(); So

[dm-devel] [RFC PATCH v1 1/4] keys: introduce key_extract_material helper

2021-07-26 Thread Ahmad Fatoum
While keys of differing type have a common struct key definition, there is no common scheme to the payload and key material extraction differs. For kernel functionality that supports different key types, this means duplicated code for key material extraction and because key type is discriminated

[dm-devel] [RFC PATCH v1 2/4] dm: crypt: use new key_extract_material helper

2021-07-26 Thread Ahmad Fatoum
There is a common function now to extract key material out of a few different key types, which includes all types currently supported by dm-crypt. Make use of it. Signed-off-by: Ahmad Fatoum --- To: David Howells To: Jarkko Sakkinen To: James Morris To: "Serge E. Hallyn" To: Alasdair Kergon

[dm-devel] [RFC PATCH v1 3/4] ubifs: auth: remove never hit key type error check

2021-07-26 Thread Ahmad Fatoum
key_request accepts a key type as its first argument. If it returns a valid pointer, it should always have this same requested key type. Indeed other request_key users surveyed such as dm-crypt, ecryptfs and fscrypt v1 also don't check the key type. Therefore drop the apparently unneeded check.

[dm-devel] [RFC PATCH v1 4/4] ubifs: auth: consult encrypted and trusted keys if no logon key was found

2021-07-26 Thread Ahmad Fatoum
Currently, UBIFS auth_key can only be a logon key: This is a user key that's provided to the kernel in plaintext and that then remains within the kernel. Linux also supports trusted and encrypted keys, which have stronger guarantees: They are only exposed to userspace in encrypted form and, in the

Re: [dm-devel] [Question] multipathd.service start failed when /var/run isn't mount

2021-07-26 Thread lixiaokeng
>> After sdb mounted to /var, we can start multipathd service successfully. > > But when the binaries were compiled, if /var/run existed and was a > symlink in your build environment, then RUN should equal "run", and > multipath should should be using /run instead of /var/run, right? > > This

[dm-devel] [RFC PATCH v1 0/4] keys: introduce key_extract_material helper

2021-07-26 Thread Ahmad Fatoum
While keys of differing type have a common struct key definition, there is no common scheme to the payload and key material extraction differs. For kernel functionality that supports different key types, this means duplicated code for key material extraction and because key type is discriminated

Re: [dm-devel] [PATCH 7/7] dm: add documentation for IMA measurement support

2021-07-26 Thread Mimi Zohar
Hi Tushar, On Sat, 2021-07-24 at 00:25 -0700, Tushar Sugandhi wrote: > Hi Mimi, > > > > Missing from the document is a way of validating the template data. > > For example, in the original case of file measurements, the template > > data contains the file hash, which can be recalculated or

Re: [dm-devel] [Question] multipathd.service start failed when /var/run isn't mount

2021-07-26 Thread Benjamin Marzinski
On Mon, Jul 26, 2021 at 08:22:49PM +0800, lixiaokeng wrote: > > >> After sdb mounted to /var, we can start multipathd service successfully. > > > > But when the binaries were compiled, if /var/run existed and was a > > symlink in your build environment, then RUN should equal "run", and > >

Re: [dm-devel] [PATCH 1/9] libmultipath: variable-size parameters in dm_get_map()

2021-07-26 Thread Benjamin Marzinski
On Thu, Jul 15, 2021 at 12:52:15PM +0200, mwi...@suse.com wrote: > From: Martin Wilck > > We've seen a crash of multipath in disassemble_map because of a params > string exceeding PARAMS_SIZE. While the crash could have been fixed by > a simple error check, I believe multipath should be able to

Re: [dm-devel] [PATCH 7/7] dm: add documentation for IMA measurement support

2021-07-26 Thread Tushar Sugandhi
Hi Mimi, On 7/26/21 9:33 AM, Mimi Zohar wrote: Hi Tushar, On Sat, 2021-07-24 at 00:25 -0700, Tushar Sugandhi wrote: Hi Mimi, Missing from the document is a way of validating the template data. For example, in the original case of file measurements, the template data contains the file hash,