Re: [dm-devel] [PATCH 7/7] block: remove REQ_OP_WRITE_SAME support

2022-02-22 Thread Martin K. Petersen
Christoph, > The maybe fold this in? Done, thanks! -- Martin K. Petersen Oracle Linux Engineering -- dm-devel mailing list dm-devel@redhat.com https://listman.redhat.com/mailman/listinfo/dm-devel

Re: [dm-devel] [PATCH RESEND v2] dm: Fix use-after-free in dm_cleanup_zoned_dev()

2022-02-22 Thread Mike Snitzer
On Thu, Feb 17, 2022 at 5:49 AM Damien Le Moal wrote: > > On 2/17/22 19:13, Kirill Tkhai wrote: > > > > dm_cleanup_zoned_dev() uses queue, so it must be called > > before blk_cleanup_disk() starts its killing: > > > > blk_cleanup_disk->blk_cleanup_queue()->kobject_put()->blk_release_queue()-> > >

Re: [dm-devel] [PATCH] kpartx: Add -P option for partition scanning

2022-02-22 Thread Ritika Srivastava
Ben, Thank you for reviewing this. On 2/22/22, 11:32 AM, "Benjamin Marzinski" wrote: > And I'm trying to figure out why you want to create /dev/loop0p1 if you > already have /dev/mapper/loop0p1? The ability of kpartx to create > partitioned loop devices predates the existance "kpartx

Re: [dm-devel] [PATCH] udev-md-raid-assembly.rules: skip if DM_UDEV_DISABLE_OTHER_RULES_FLAG

2022-02-22 Thread NeilBrown
On Wed, 23 Feb 2022, Martin Wilck wrote: > Neil, > > On Tue, 2022-02-22 at 10:36 +1100, NeilBrown wrote: > > > > > The flags that DM use for udev were introduced before systemd > > > project > > > even existed. We needed to introduce the > > > DM_UDEV_DISABLE_OTHER_RULES_FLAG > > > to have a

Re: [dm-devel] [PATCH v3 02/10] block: Introduce queue limits for copy-offload support

2022-02-22 Thread Luis Chamberlain
On Thu, Feb 17, 2022 at 06:29:01PM +0530, Nitesh Shetty wrote: > Thu, Feb 17, 2022 at 01:07:00AM -0800, Luis Chamberlain wrote: > > The subject says limits for copy-offload... > > > > On Mon, Feb 14, 2022 at 01:29:52PM +0530, Nitesh Shetty wrote: > > > Add device limits as sysfs entries, > > >

Re: [dm-devel] [PATCH v3 00/10] Add Copy offload support

2022-02-22 Thread Dave Chinner
On Thu, Feb 17, 2022 at 06:32:15PM +0530, Nitesh Shetty wrote: > Tue, Feb 15, 2022 at 09:08:12AM +1100, Dave Chinner wrote: > > On Mon, Feb 14, 2022 at 01:29:50PM +0530, Nitesh Shetty wrote: > > > [LSF/MM/BFP TOPIC] Storage: Copy Offload[0]. > > The biggest missing piece - and arguably the single

Re: [dm-devel] Intel QAT on A2SDi-8C-HLN4F causes massive data corruption with dm-crypt + xfs

2022-02-22 Thread Giovanni Cabiddu
Hi Kyle, The issue is that the implementations of aead and skcipher in the QAT driver are not properly supporting requests with the CRYPTO_TFM_REQ_MAY_BACKLOG flag set. If the HW queue is full, the driver returns -EBUSY [1] but does not enqueues the request as dm-crypt expects [2]. Dm-crypt ends

Re: [dm-devel] [EXT] Re: a potential issue for bow_target after "dm: delay registering the gendisk" applied

2022-02-22 Thread Faqiang Zhu
Thank you. I just noticed that this is an out-of-tree module. + Paul Lawrence & Eric Biggers Best Regards, Zhu Faqiang. -Original Message- From: Mike Snitzer Sent: 2022年2月22日 0:43 To: Faqiang Zhu Cc: h...@lst.de; a...@redhat.com; dm-devel@redhat.com Subject: [EXT] Re: a potential

[dm-devel] [regression] a potential issue for bow_target after "dm: delay registering the gendisk" applied

2022-02-22 Thread Faqiang Zhu
Hi Christoph, Recently when I use kernel5.15 with android, an issue related to bow_target is found with below log: [8.935429][T1] kobject_add_internal failed for bow (error: -2 parent: (null)) The call trace to the preceding log is as below: dm_ctl_ioctl -> ctl_ioctl ->

Re: [dm-devel] [PATCH v3 08/10] dm: Add support for copy offload.

2022-02-22 Thread Mike Snitzer
On Mon, Feb 14 2022 at 2:59P -0500, Nitesh Shetty wrote: > Before enabling copy for dm target, check if underlying devices and > dm target support copy. Avoid split happening inside dm target. > Fail early if the request needs split, currently splitting copy > request is not supported. > >

Re: [dm-devel] [PATCH] kpartx: Add -P option for partition scanning

2022-02-22 Thread Benjamin Marzinski
On Fri, Feb 11, 2022 at 12:41:48PM -0800, Ritika Srivastava wrote: > Add -P, partition scanning option to kpartx which would set > LO_FLAGS_PARTSCAN flag during loop device creation. > This option is same as losetup -P option. I'm confused here. What's the benefit of doing this? Doesn't this

Re: [dm-devel] dm: make sure dm_table is binded before queue request

2022-02-22 Thread Mike Snitzer
On Wed, Feb 09 2022 at 4:37P -0500, Zhang Yi wrote: > We found a NULL pointer dereference problem when using dm-mpath target. > The problem is if we submit IO between loading and binding the table, > we could neither get a valid dm_target nor a valid dm table when > submitting request in

Re: [dm-devel] [PATCH] kpartx: Add -P option for partition scanning

2022-02-22 Thread Ritika Srivastava
Hi, Gentle ping Please help review this. -- Thanks, Ritika On 2/11/22, 3:51 PM, Ritika Srivastava wrote: Add -P, partition scanning option to kpartx which would set LO_FLAGS_PARTSCAN flag during loop device creation. This option is same as losetup -P option.

Re: [dm-devel] dm: introduce a DM_ENFORCE_OPEN_COUNT flag.

2022-02-22 Thread Mike Snitzer
On Wed, Feb 02 2022 at 9:42P -0500, Christoph Hellwig wrote: > Withmy block hat on: nak to this. No block driver has any business at > all rejecting "too many openers". In fact any opener but the first of > a partition is already not counted as an opener, and I plan to complete > hide the

Re: [dm-devel] [PATCH] kpartx: Add -P option for partition scanning

2022-02-22 Thread Benjamin Marzinski
On Tue, Feb 22, 2022 at 06:59:10PM +, Ritika Srivastava wrote: > On 2/22/22, 10:28 AM, "Benjamin Marzinski" wrote: > > On Fri, Feb 11, 2022 at 12:41:48PM -0800, Ritika Srivastava wrote: > >> Add -P, partition scanning option to kpartx which would set > >> LO_FLAGS_PARTSCAN flag

Re: [dm-devel] [PATCH] kpartx: Add -P option for partition scanning

2022-02-22 Thread Ritika Srivastava
On 2/22/22, 10:28 AM, "Benjamin Marzinski" wrote: On Fri, Feb 11, 2022 at 12:41:48PM -0800, Ritika Srivastava wrote: >> Add -P, partition scanning option to kpartx which would set >> LO_FLAGS_PARTSCAN flag during loop device creation. >> This option is same as losetup -P option.