Re: [dm-devel] [PATCH] multipath-tools Consider making 'smart' the default

2023-03-20 Thread Brian Bunker
> On Mar 20, 2023, at 12:41 PM, Benjamin Marzinski wrote: > > On Mon, Mar 20, 2023 at 03:18:37PM +0100, Martin Wilck wrote: >> On Thu, 2023-03-16 at 14:47 -0700, Brian Bunker wrote: >>> As a target vendor, it is nice to be able control initiator >>> behavior from the target without relying on

[dm-devel] [PATCH] multipath-tools Makefiles: handle dependency files correctly

2023-03-20 Thread mwilck
From: Martin Wilck Some generated .d files were not correctly included, and not removed with "make dep_clean". Fix it. Reported-by: Xose Vazquez Perez Signed-off-by: Martin Wilck --- libmultipath/Makefile | 4 ++-- multipathd/Makefile | 4 ++-- 2 files changed, 4 insertions(+), 4

Re: [dm-devel] [PATCH v2] dm verity: fix error handling for check_at_most_once on FEC

2023-03-20 Thread Eric Biggers
On Mon, Mar 20, 2023 at 03:59:32PM +0900, Yeongjin Gil wrote: > In verity_end_io(), if bi_status is not BLK_STS_OK, it can be return > directly. But if FEC configured, it is desired to correct the data page > through verity_verify_io. And the return value will be converted to > blk_status and

[dm-devel] [PATCH] libmultipathd Avoid parsing errors due to unsupported designators

2023-03-20 Thread Brian Bunker
Unsupported designators, even if they are correct, will result in parsing errors. Add support for these two: Logical Unit Group (0x6) Vendor Specific (0x0) Mar 20 13:37:35 init107-18 multipath[45016]: parse_vpd_pg83: invalid device designator at offset 87: 01060004 Mar 20 13:37:35 init107-18

Re: [dm-devel] [PATCH] libmultipath: limit paths that can get wwid from environment

2023-03-20 Thread Benjamin Marzinski
On Mon, Mar 20, 2023 at 02:53:20PM +, Martin Wilck wrote: > On Thu, 2023-02-09 at 11:28 -0600, Benjamin Marzinski wrote: > > Currently, whenever getting the uid_attribute from the udev database > > fails, multipath will try to get it from the environment variables. > > This > > normally isn't

Re: [dm-devel] [PATCH] multipath-tools Consider making 'smart' the default

2023-03-20 Thread Benjamin Marzinski
On Mon, Mar 20, 2023 at 03:18:37PM +0100, Martin Wilck wrote: > On Thu, 2023-03-16 at 14:47 -0700, Brian Bunker wrote: > > As a target vendor, it is nice to be able control initiator > > behavior from the target without relying on user intervention > > on the initiator. There could be a very large

Re: [dm-devel] [PATCH v4 02/18] block: Rename BLK_STS_NEXUS to BLK_STS_RESV_CONFLICT

2023-03-20 Thread Christoph Hellwig
On Thu, Mar 16, 2023 at 11:36:12AM -0500, Mike Christie wrote: > I think we are ok for dasd using BLK_STS_RESV_CONFLICT. > > It thought it sounded similar to SCSI/NVMe and userspace will still > see -EBADE because the blk_status_to_errno/errno_to_blk_status will > handle this. > > There was no

Re: [dm-devel] [PATCH] multipath-tools: delete multipathd/multipathc.d file when "make clean"

2023-03-20 Thread Martin Wilck
On Wed, 2023-03-15 at 17:01 -0500, Benjamin Marzinski wrote: > On Wed, Mar 15, 2023 at 06:02:09PM +0100, Xose Vazquez Perez wrote: > > Cc: Martin Wilck > > Cc: Benjamin Marzinski > > Cc: Christophe Varoqui > > Cc: DM-DEVEL ML > > Signed-off-by: Xose Vazquez Perez > > Shouldn't this also go

Re: [dm-devel] [PATCH] libmultipath: limit paths that can get wwid from environment

2023-03-20 Thread Martin Wilck
On Thu, 2023-02-09 at 11:28 -0600, Benjamin Marzinski wrote: > Currently, whenever getting the uid_attribute from the udev database > fails, multipath will try to get it from the environment variables. > This > normally isn't a problem, since either multipath -u is getting called > from a uevent

Re: [dm-devel] [PATCH] multipath-tools Consider making 'smart' the default

2023-03-20 Thread Martin Wilck
On Thu, 2023-03-16 at 14:47 -0700, Brian Bunker wrote: > As a target vendor, it is nice to be able control initiator > behavior from the target without relying on user intervention > on the initiator. There could be a very large number of initiators > at a site. > > When ACLs are first added for