Re: [dm-devel] [dm-6.4 PATCH 1/8] dm: split discards further if target sets max_discard_granularity

2023-03-23 Thread Joe Thornber
Also nacking this patch since you refused to test it. I said I'd test since you haven't, but you couldn't wait. - Joe On Wed, Mar 22, 2023 at 6:19 PM Mike Snitzer wrote: > The block core (bio_split_discard) will already split discards based > on the 'discard_granularity' and 'max_discard_secto

[dm-devel] [PATCH] tests: fix quoting of CFLAGS in Makefile

2023-03-23 Thread Sam James
Otherwise, when CFLAGS/CPPFLAGS have multiple entries (like "-O2 -pipe"), we get an error: ``` make[1]: Entering directory '/var/tmp/portage/sys-fs/multipath-tools-0.9.4/work/multipath-tools-0.9.4/tests' /bin/sh: line 1: -pipe: command not found make[1]: *** [Makefile:115: libmultipath.so.0] Error

Re: [dm-devel] [dm-6.4 PATCH 1/8] dm: split discards further if target sets max_discard_granularity

2023-03-23 Thread Mike Snitzer
On Thu, Mar 23 2023 at 4:00P -0400, Joe Thornber wrote: > Also nacking this patch since you refused to test it. I said I'd test > since you haven't, but you couldn't wait. [Pleaase don't top-post.] That's fine. I had already dropped this patch from linux-next due to my testing showing it does

Re: [dm-devel] [dm-6.4 PATCH 5/8] dm bufio: improve concurrent IO performance

2023-03-23 Thread Mike Snitzer
On Thu, Mar 23 2023 at 3:51P -0400, Joe Thornber wrote: > Mike, > > I'm Nacking this patch here. You've taken the comment from my latest > patch, and attached it to something else. I don't know if you've taken an > older patch and updated it, or taken the latest patch and downgraded it. I le

Re: [dm-devel] [PATCH] multipath-tools Makefiles: handle dependency files correctly

2023-03-23 Thread Martin Wilck
Xose, Ben, when this gets a Reviewed-by, I'd prepare a new submission to Christophe (unless someone objects). Martin On Mon, 2023-03-20 at 16:55 +0100, mwi...@suse.com wrote: > From: Martin Wilck > > Some generated .d files were not correctly included, and not > removed with "make dep_clean".

Re: [dm-devel] [PATCH] multipath-tools Makefiles: handle dependency files correctly

2023-03-23 Thread Benjamin Marzinski
On Mon, Mar 20, 2023 at 04:55:50PM +0100, mwi...@suse.com wrote: > From: Martin Wilck > > Some generated .d files were not correctly included, and not > removed with "make dep_clean". Fix it. > > Reported-by: Xose Vazquez Perez > Signed-off-by: Martin Wilck Reviewed-by: Benjamin Marzinski >

Re: [dm-devel] [PATCH] multipath-tools Makefiles: handle dependency files correctly

2023-03-23 Thread Xose Vazquez Perez
On 3/20/23 16:55, mwi...@suse.com wrote: From: Martin Wilck Some generated .d files were not correctly included, and not removed with "make dep_clean". Fix it. Reported-by: Xose Vazquez Perez Signed-off-by: Martin Wilck Tested-by: Xose Vazquez Perez --- libmultipath/Makefile | 4 ++--

Re: [dm-devel] [PATCH] multipath-tools Makefiles: handle dependency files correctly

2023-03-23 Thread Xose Vazquez Perez
On 3/23/23 12:53, Martin Wilck wrote: Xose, Ben, when this gets a Reviewed-by, I'd prepare a new submission to Christophe (unless someone objects). There is a pending Gentoo patch from Sam James: https://listman.redhat.com/archives/dm-devel/2023-March/053587.html -- dm-devel mailing list dm-

[dm-devel] [PATCH] dm-bufio: fix integer casts

2023-03-23 Thread Mikulas Patocka
Fix some cases where unsigned long is being cast to unsigned int. Signed-off-by: Mikulas Patocka --- drivers/md/dm-bufio.c | 16 1 file changed, 8 insertions(+), 8 deletions(-) Index: linux-2.6/drivers/md/dm-bufio.c ===

[dm-devel] [PATCH] dm-bufio: use waitqueue_active in __free_buffer_wake

2023-03-23 Thread Mikulas Patocka
Save one spinlock by using waitqueue_active. We hold the bufio lock at this place, so no one can add entries to the waitqueue at this point. Signed-off-by: Mikulas Patocka --- drivers/md/dm-bufio.c |7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) Index: linux-2.6/drivers/md/dm-bu

Re: [dm-devel] [PATCH] tests: fix quoting of CFLAGS in Makefile

2023-03-23 Thread Martin Wilck
On Thu, 2023-03-23 at 08:12 +, Sam James wrote: > Otherwise, when CFLAGS/CPPFLAGS have multiple entries (like "-O2 - > pipe"), we > get an error: > ``` > make[1]: Entering directory '/var/tmp/portage/sys-fs/multipath-tools- > 0.9.4/work/multipath-tools-0.9.4/tests' > /bin/sh: line 1: -pipe: com

Re: [dm-devel] [PATCH] libmultipathd Avoid parsing errors due to unsupported designators

2023-03-23 Thread Martin Wilck
On Mon, 2023-03-20 at 12:22 -0700, Brian Bunker wrote: > Unsupported designators, even if they are correct, will result > in parsing errors. Add support for these two: > > Logical Unit Group (0x6) > Vendor Specific (0x0) > > Mar 20 13:37:35 init107-18 multipath[45016]: parse_vpd_pg83: > invalid d

[dm-devel] [PATCH] libmultipath: use directio checker for LIO targets

2023-03-23 Thread mwilck
From: Martin Wilck LIO always responds with GOOD status to TUR. Thus TUR is not useful as path checker for LIO targets. Fixes https://github.com/opensvc/multipath-tools/issues/54 Signed-off-by: Martin Wilck --- libmultipath/hwtable.c | 1 + 1 file changed, 1 insertion(+) diff --git a/libmult