On Tue, Jun 06, 2023 at 09:39:23AM +0200, Christoph Hellwig wrote:
> cdrom_close_write is empty, and the for_data flag it is keyed off is
> never set. Remove all this clutter.
>
> Signed-off-by: Christoph Hellwig
> ---
Looks good to me,
Acked-by: Christian Brauner
--
dm-devel mailing list
On Tue, Jun 06, 2023 at 09:39:41AM +0200, Christoph Hellwig wrote:
> Instead of passing a fmode_t and only checking it fo0r FMODE_WRITE, pass
> a bool open_for_write to prepare for callers that won't have the fmode_t.
>
> Signed-off-by: Christoph Hellwig
> ---
Looks good to me,
Acked-by:
On Tue, Jun 06, 2023 at 09:39:46AM +0200, Christoph Hellwig wrote:
> A few ioctl handlers have fmode_t arguments that are entirely unused,
> remove them.
>
> Signed-off-by: Christoph Hellwig
> ---
Looks good to me,
Acked-by: Christian Brauner
--
dm-devel mailing list
dm-devel@redhat.com
On Tue, Jun 06, 2023 at 09:39:24AM +0200, Christoph Hellwig wrote:
> Set a flag when a cdrom_device_info is opened for writing, instead of
> trying to figure out this at release time. This will allow to eventually
> remove the mode argument to the ->release block_device_operation as
> nothing but
On Tue, Jun 6, 2023 at 9:41 AM Christoph Hellwig wrote:
>
> Stop passing the fmode_t around and just use a simple bool to track if
> an export is read-only.
>
> Signed-off-by: Christoph Hellwig
Acked-by: Jack Wang
> ---
> drivers/block/rnbd/rnbd-srv-sysfs.c | 3 +--
>
On Tue, Jun 6, 2023 at 9:40 AM Christoph Hellwig wrote:
>
> The mode argument to the ->release block_device_operation is never used,
> so remove it.
>
> Signed-off-by: Christoph Hellwig
> ---
> arch/um/drivers/ubd_kern.c | 4 ++--
> arch/xtensa/platforms/iss/simdisk.c | 2 +-
>
On Tue, Jun 6, 2023 at 9:40 AM Christoph Hellwig wrote:
>
> The current interface for exclusive opens is rather confusing as it
> requires both the FMODE_EXCL flag and a holder. Remove the need to pass
> FMODE_EXCL and just key off the exclusive open off a non-NULL holder.
>
> For blkdev_put
On Tue, Jun 06, 2023 at 01:01:20PM -0400, Demi Marie Obenour wrote:
> On Tue, Jun 06, 2023 at 10:25:47AM +0200, Roger Pau Monné wrote:
> > On Tue, May 30, 2023 at 04:31:13PM -0400, Demi Marie Obenour wrote:
> > > This allows specifying a disk sequence number in XenStore. If it does
> > > not
On Tue, Jun 06, 2023 at 09:39:27AM +0200, Christoph Hellwig wrote:
> Factor the common logic between disk_check_media_change and
> disk_force_media_change into a helper.
>
> Signed-off-by: Christoph Hellwig
> ---
Looks good to me,
Acked-by: Christian Brauner
--
dm-devel mailing list
On Tue, Jun 06, 2023 at 09:39:44AM +0200, Christoph Hellwig wrote:
> This code has been dead forever, make sure it doesn't show up in code
> searches.
>
> Signed-off-by: Christoph Hellwig
> ---
Looks good to me,
Acked-by: Christian Brauner
--
dm-devel mailing list
dm-devel@redhat.com
On Tue, Jun 06, 2023 at 09:39:47AM +0200, Christoph Hellwig wrote:
> The only overlap between the block open flags mapped into the fmode_t and
> other uses of fmode_t are FMODE_READ and FMODE_WRITE. Define a new
and FMODE_EXCL afaict
> blk_mode_t instead for use in blkdev_get_by_*, ->open and
On Tue, Jun 6, 2023 at 9:40 AM Christoph Hellwig wrote:
>
> ->open is only called on the whole device. Make that explicit by
> passing a gendisk instead of the block_device.
>
> Signed-off-by: Christoph Hellwig
> ---
> arch/um/drivers/ubd_kern.c | 5 ++---
>
On Tue, Jun 06, 2023 at 09:39:35AM +0200, Christoph Hellwig wrote:
> The current interface for exclusive opens is rather confusing as it
> requires both the FMODE_EXCL flag and a holder. Remove the need to pass
> FMODE_EXCL and just key off the exclusive open off a non-NULL holder.
>
> For
On Tue, Jun 06, 2023 at 09:39:25AM +0200, Christoph Hellwig wrote:
> Signed-off-by: Christoph Hellwig
> ---
Looks good to me,
Acked-by: Christian Brauner
--
dm-devel mailing list
dm-devel@redhat.com
https://listman.redhat.com/mailman/listinfo/dm-devel
On Tue, Jun 06, 2023 at 09:39:20AM +0200, Christoph Hellwig wrote:
> For whole devices ->open is called for each open, but for partitions it
> is only called on the first open of a partition. This is problematic
> as various block drivers look at open flags and might not do all setup
> for ioctl
On Tue, Jun 06, 2023 at 09:39:49AM +0200, Christoph Hellwig wrote:
> Store the file struct used as the holder in file->private_data as an
> indicator that this file descriptor was opened exclusively to remove
> the last use of FMODE_EXCL.
>
> Signed-off-by: Christoph Hellwig
> ---
Feels a bit
On Wed, Jun 07, 2023 at 11:24:55AM +0200, Christian Brauner wrote:
> On Tue, Jun 06, 2023 at 09:39:49AM +0200, Christoph Hellwig wrote:
> > Store the file struct used as the holder in file->private_data as an
> > indicator that this file descriptor was opened exclusively to remove
> > the last
On Tue, Jun 06, 2023 at 09:39:29AM +0200, Christoph Hellwig wrote:
> The mode argument to the ->release block_device_operation is never used,
> so remove it.
>
> Signed-off-by: Christoph Hellwig
> ---
Good cleanup. Looks good to me,
Acked-by: Christian Brauner
--
dm-devel mailing list
On Tue, Jun 6, 2023 at 9:41 AM Christoph Hellwig wrote:
>
> The only overlap between the block open flags mapped into the fmode_t and
> other uses of fmode_t are FMODE_READ and FMODE_WRITE. Define a new
> blk_mode_t instead for use in blkdev_get_by_*, ->open and ->ioctl and
> stop abusing
On Tue, Jun 06, 2023 at 09:39:38AM +0200, Christoph Hellwig wrote:
> Instead of passing a fmode_t and only checking it for FMODE_WRITE, pass
> a bool open_for_write to prepare for callers that won't have the fmode_t.
>
> Signed-off-by: Christoph Hellwig
> ---
Looks good to me,
Acked-by:
On Tue, Jun 06, 2023 at 09:39:48AM +0200, Christoph Hellwig wrote:
> Always use I_BDEV(file->f_mapping->host) to find the bdev for a file to
> free up file->private_data for other uses.
>
> Signed-off-by: Christoph Hellwig
> ---
Looks good to me,
Acked-by: Christian Brauner
--
dm-devel
On Wed, Jun 07, 2023 at 11:21:24AM +0200, Christian Brauner wrote:
> On Tue, Jun 06, 2023 at 09:39:47AM +0200, Christoph Hellwig wrote:
> > The only overlap between the block open flags mapped into the fmode_t and
> > other uses of fmode_t are FMODE_READ and FMODE_WRITE. Define a new
>
> and
On Tue, Jun 6, 2023 at 9:40 AM Christoph Hellwig wrote:
>
> Passing a holder to blkdev_get_by_path when FMODE_EXCL isn't set doesn't
> make sense, so pass NULL instead.
>
> Signed-off-by: Christoph Hellwig
Acked-by: Jack Wang
> ---
> drivers/block/rnbd/rnbd-srv.c | 2 +-
> 1 file changed, 1
On Tue, Jun 06, 2023 at 09:39:33AM +0200, Christoph Hellwig wrote:
> Passing a holder to blkdev_get_by_path when FMODE_EXCL isn't set doesn't
> make sense, so pass NULL instead.
>
> Signed-off-by: Christoph Hellwig
> ---
Looks good to me,
Acked-by: Christian Brauner
--
dm-devel mailing list
On Tue, Jun 06, 2023 at 09:39:22AM +0200, Christoph Hellwig wrote:
> Signed-off-by: Christoph Hellwig
> ---
Looks good to me,
Acked-by: Christian Brauner
--
dm-devel mailing list
dm-devel@redhat.com
https://listman.redhat.com/mailman/listinfo/dm-devel
On Tue, Jun 06, 2023 at 09:39:35AM +0200, Christoph Hellwig wrote:
> The current interface for exclusive opens is rather confusing as it
> requires both the FMODE_EXCL flag and a holder. Remove the need to pass
> FMODE_EXCL and just key off the exclusive open off a non-NULL holder.
>
> For
On Tue, Jun 06, 2023 at 09:39:43AM +0200, Christoph Hellwig wrote:
> Stop passing the fmode_t around and just use a simple bool to track if
> an export is read-only.
>
> Signed-off-by: Christoph Hellwig
> ---
Looks good to me,
Acked-by: Christian Brauner
--
dm-devel mailing list
On 6/6/23 09:39, Christoph Hellwig wrote:
Store the file struct used as the holder in file->private_data as an
indicator that this file descriptor was opened exclusively to remove
the last use of FMODE_EXCL.
Signed-off-by: Christoph Hellwig
---
block/fops.c | 14 --
1 file
On Tue, Jun 06, 2023 at 09:39:42AM +0200, Christoph Hellwig wrote:
> Instead of propagating the fmode_t, just use a bool to track if a mtd
> block device was opened for writing.
>
> Signed-off-by: Christoph Hellwig
> ---
Looks good to me,
Acked-by: Christian Brauner
--
dm-devel mailing list
On Tue, Jun 06, 2023 at 09:39:34AM +0200, Christoph Hellwig wrote:
> Passing a holder to blkdev_get_by_path when FMODE_EXCL isn't set doesn't
> make sense, so pass NULL instead and remove the holder argument from the
> call chains the only end up in non-FMODE_EXCL blkdev_get_by_path calls.
Please
On Tue, Jun 06, 2023 at 09:39:28AM +0200, Christoph Hellwig wrote:
> ->open is only called on the whole device. Make that explicit by
Ok, that answers my question in
https://lore.kernel.org/all/20230607-chefsessel-angeordnet-269f0596f9b3@brauner
> passing a gendisk instead of the block_device.
On Tue, Jun 06, 2023 at 09:39:26AM +0200, Christoph Hellwig wrote:
> bdev_check_media_change should only ever be called for the whole device.
> Pass a gendisk to make that explicit and rename the function to
> disk_check_media_change.
>
> Signed-off-by: Christoph Hellwig
> ---
Under the
On Tue, Jun 06, 2023 at 01:31:25PM -0400, Demi Marie Obenour wrote:
> On Tue, Jun 06, 2023 at 11:15:37AM +0200, Roger Pau Monné wrote:
> > On Tue, May 30, 2023 at 04:31:16PM -0400, Demi Marie Obenour wrote:
> > > Set "opened" to "0" before the hotplug script is called. Once the
> > > device node
On Tue, Jun 06, 2023 at 10:40:42AM +0200, Christoph Hellwig wrote:
> On Tue, Jun 06, 2023 at 10:27:14AM +0200, Christian Brauner wrote:
> > On Tue, Jun 06, 2023 at 09:39:19AM +0200, Christoph Hellwig wrote:
> > > Hi all,
> > >
> > > this series adds a new blk_mode_t for block open flags instead
On Tue, Jun 06, 2023 at 09:39:34AM +0200, Christoph Hellwig wrote:
> Passing a holder to blkdev_get_by_path when FMODE_EXCL isn't set doesn't
> make sense, so pass NULL instead and remove the holder argument from the
> call chains the only end up in non-FMODE_EXCL blkdev_get_by_path calls.
>
>
On Tue, Jun 06, 2023 at 09:39:50AM +0200, Christoph Hellwig wrote:
> FMODE_NDELAY, FMODE_EXCL and FMODE_WRITE_IOCTL were only used for
> block internal purposed and are now entirely unused, so remove them.
>
> Signed-off-by: Christoph Hellwig
> ---
Love it,
Reviewed-by: Christian Brauner
--
On Tue, Jun 06, 2023 at 09:39:45AM +0200, Christoph Hellwig wrote:
> All these helpers are only used in core block code, so move them out of
> the public header.
>
> Signed-off-by: Christoph Hellwig
> ---
Looks good to me,
Acked-by: Christian Brauner
--
dm-devel mailing list
On Tue, Jun 06, 2023 at 09:39:36AM +0200, Christoph Hellwig wrote:
> Add a helper to return the open flags for blkdev_get_by* for passed in
> super block flags instead of open coding the logic in many places.
>
> Signed-off-by: Christoph Hellwig
> ---
Looks good to me,
Acked-by: Christian
On Tue, Jun 06, 2023 at 09:39:21AM +0200, Christoph Hellwig wrote:
> Signed-off-by: Christoph Hellwig
> ---
lgtm,
Acked-by: Christian Brauner
--
dm-devel mailing list
dm-devel@redhat.com
https://listman.redhat.com/mailman/listinfo/dm-devel
On Tue, Jun 06, 2023 at 09:39:40AM +0200, Christoph Hellwig wrote:
> Instead of passing a fmode_t and only checking it for FMODE_WRITE, pass
> a bool open_for_write to prepare for callers that won't have the fmode_t.
>
> Signed-off-by: Christoph Hellwig
> ---
Looks good to me,
Acked-by:
On Tue, Jun 06, 2023 at 09:39:39AM +0200, Christoph Hellwig wrote:
> Instead of passing a fmode_t and only checking it for FMODE_WRITE, pass
> a bool open_for_write to prepare for callers that won't have the fmode_t.
>
> Signed-off-by: Christoph Hellwig
> ---
Looks good to me,
Acked-by:
On Tue, Jun 06, 2023 at 09:39:37AM +0200, Christoph Hellwig wrote:
> There is no real need to store the open mode in the super_block now.
> It is only used by f2fs, which can easily recalculate it.
>
> Signed-off-by: Christoph Hellwig
> ---
Looks good to me,
Acked-by: Christian Brauner
--
On Tue, Jun 06, 2023 at 09:39:30AM +0200, Christoph Hellwig wrote:
> Make the function name match the method name.
>
> Signed-off-by: Christoph Hellwig
> ---
Looks good to me,
Acked-by: Christian Brauner
--
dm-devel mailing list
dm-devel@redhat.com
On Thu, Jun 08, 2023 at 09:47:27AM +0100, Phillip Potter wrote:
> Yes indeed - I was under the impression it was appropriate for a
> maintainer to signal their approval of a patch to maintained code using
> a Signed-off-by tag due to their involvement in the submission process?
> Apologies if I've
On Wed, Jun 07, 2023 at 12:00:57AM +0100, Phillip Potter wrote:
> Looks good, thanks.
>
> Signed-off-by: Phillip Potter
Hmm, these signoffs don't really make sense here. Were they intended
as Reviewed-bys?
--
dm-devel mailing list
dm-devel@redhat.com
Instead of propagating the fmode_t, just use a bool to track if a mtd
block device was opened for writing.
Signed-off-by: Christoph Hellwig
Reviewed-by: Hannes Reinecke
Acked-by: Christian Brauner
Acked-by: Richard Weinberger
---
drivers/mtd/mtd_blkdevs.c| 2 +-
drivers/mtd/mtdblock.c
A few ioctl handlers have fmode_t arguments that are entirely unused,
remove them.
Signed-off-by: Christoph Hellwig
Acked-by: Christian Brauner
Reviewed-by: Hannes Reinecke
---
block/blk-zoned.c | 4 ++--
block/blk.h | 6 +++---
block/ioctl.c | 14 +++---
3 files changed,
All these helpers are only used in core block code, so move them out of
the public header.
Signed-off-by: Christoph Hellwig
Reviewed-by: Hannes Reinecke
Acked-by: Christian Brauner
---
block/blk.h| 23 +--
include/linux/blkdev.h | 27 ---
Instead of passing a fmode_t and only checking it for FMODE_WRITE, pass
a bool open_for_write to prepare for callers that won't have the fmode_t.
Signed-off-by: Christoph Hellwig
Reviewed-by: Martin K. Petersen
Reviewed-by: Hannes Reinecke
Acked-by: Christian Brauner
---
drivers/scsi/ch.c
Stop passing the fmode_t around and just use a simple bool to track if
an export is read-only.
Signed-off-by: Christoph Hellwig
Reviewed-by: Hannes Reinecke
Acked-by: Christian Brauner
Acked-by: Jack Wang
---
drivers/block/rnbd/rnbd-srv-sysfs.c | 3 +--
drivers/block/rnbd/rnbd-srv.c |
Signed-off-by: Christoph Hellwig
Reviewed-by: Phillip Potter
Reviewed-by: Hannes Reinecke
Acked-by: Christian Brauner
---
drivers/cdrom/cdrom.c | 2 +-
drivers/cdrom/gdrom.c | 2 +-
drivers/scsi/sr.c | 2 +-
include/linux/cdrom.h | 2 +-
4 files changed, 4 insertions(+), 4 deletions(-)
There is no real need to store the open mode in the super_block now.
It is only used by f2fs, which can easily recalculate it.
Signed-off-by: Christoph Hellwig
Reviewed-by: Hannes Reinecke
Acked-by: Christian Brauner
---
fs/f2fs/super.c| 10 ++
fs/nilfs2/super.c | 1 -
Instead of passing a fmode_t and only checking it for FMODE_WRITE, pass
a bool open_for_write to prepare for callers that won't have the fmode_t.
Signed-off-by: Christoph Hellwig
Reviewed-by: Martin K. Petersen
Reviewed-by: Hannes Reinecke
Acked-by: Christian Brauner
---
Instead of passing a fmode_t and only checking it fo0r FMODE_WRITE, pass
a bool open_for_write to prepare for callers that won't have the fmode_t.
Signed-off-by: Christoph Hellwig
Reviewed-by: Hannes Reinecke
Acked-by: Christian Brauner
---
drivers/nvme/host/ioctl.c | 62
This code has been dead forever, make sure it doesn't show up in code
searches.
Signed-off-by: Christoph Hellwig
Reviewed-by: Hannes Reinecke
Acked-by: Christian Brauner
Acked-by: Richard Weinberger
---
arch/um/drivers/ubd_kern.c | 7 ---
1 file changed, 7 deletions(-)
diff --git
The current interface for exclusive opens is rather confusing as it
requires both the FMODE_EXCL flag and a holder. Remove the need to pass
FMODE_EXCL and just key off the exclusive open off a non-NULL holder.
For blkdev_put this requires adding the holder argument, which provides
better debug
Set a flag when a cdrom_device_info is opened for writing, instead of
trying to figure out this at release time. This will allow to eventually
remove the mode argument to the ->release block_device_operation as
nothing but the CDROM drivers uses that argument.
Signed-off-by: Christoph Hellwig
cdrom_close_write is empty, and the for_data flag it is keyed off is
never set. Remove all this clutter.
Signed-off-by: Christoph Hellwig
Reviewed-by: Phillip Potter
Reviewed-by: Hannes Reinecke
Acked-by: Christian Brauner
---
drivers/cdrom/cdrom.c | 15 ---
Hi all,
this series adds a new blk_mode_t for block open flags instead of abusing
fmode_t. The block open flags work very different from the normal use of
fmode_t and only share the basic READ/WRITE flags with it. None of the
other normal FMODE_* flags is used, but instead there are three
holder is just an on-stack pointer that can easily be reused by other calls,
replace it with a static variable that doesn't change.
Signed-off-by: Christoph Hellwig
Reviewed-by: Hannes Reinecke
---
kernel/power/swap.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git
Signed-off-by: Christoph Hellwig
Reviewed-by: Phillip Potter
Reviewed-by: Hannes Reinecke
Acked-by: Christian Brauner
---
drivers/cdrom/cdrom.c | 3 +--
drivers/cdrom/gdrom.c | 2 +-
drivers/scsi/sr.c | 2 +-
include/linux/cdrom.h | 3 +--
4 files changed, 4 insertions(+), 6 deletions(-)
Hi Christoph and Martin,
On 23/06/07 12:12AM, Christoph Hellwig wrote:
On Tue, Jun 06, 2023 at 05:05:35PM +0530, Nitesh Shetty wrote:
Downside will be duplicating checks which are present for read, write in
block layer, device-mapper and zoned devices.
But we can do this, shouldn't be an
Add a helper to return the open flags for blkdev_get_by* for passed in
super block flags instead of open coding the logic in many places.
Signed-off-by: Christoph Hellwig
Reviewed-by: Hannes Reinecke
Acked-by: Christian Brauner
---
fs/btrfs/super.c | 5 +
fs/nilfs2/super.c |
The only overlap between the block open flags mapped into the fmode_t and
other uses of fmode_t are FMODE_READ and FMODE_WRITE. Define a new
blk_mode_t instead for use in blkdev_get_by_{dev,path}, ->open and
->ioctl and stop abusing fmode_t.
Signed-off-by: Christoph Hellwig
Acked-by: Jack Wang
FMODE_NDELAY, FMODE_EXCL and FMODE_WRITE_IOCTL were only used for
block internal purposed and are now entirely unused, so remove them.
Signed-off-by: Christoph Hellwig
Reviewed-by: Hannes Reinecke
Reviewed-by: Christian Brauner
---
include/linux/fs.h | 7 ---
1 file changed, 7
Always use I_BDEV(file->f_mapping->host) to find the bdev for a file to
free up file->private_data for other uses.
Signed-off-by: Christoph Hellwig
Reviewed-by: Hannes Reinecke
Acked-by: Christian Brauner
---
block/fops.c | 18 --
1 file changed, 8 insertions(+), 10
bdev_check_media_change should only ever be called for the whole device.
Pass a gendisk to make that explicit and rename the function to
disk_check_media_change.
Signed-off-by: Christoph Hellwig
Reviewed-by: Hannes Reinecke
Acked-by: Christian Brauner
---
block/disk-events.c | 18
For whole devices ->open is called for each open, but for partitions it
is only called on the first open of a partition, e.g.:
open("/dev/vdb", ...)
open("/dev/vdb", ...)
- 2 call to ->open
open("/dev/vdb1", ...)
open("/dev/vdb", ...)
- 2 call to ->open
open("/dev/vdb", ...)
Passing a holder to blkdev_get_by_path when FMODE_EXCL isn't set doesn't
make sense, so pass NULL instead.
Signed-off-by: Christoph Hellwig
Reviewed-by: Hannes Reinecke
Acked-by: Christian Brauner
Acked-by: Jack Wang
---
drivers/block/rnbd/rnbd-srv.c | 2 +-
1 file changed, 1 insertion(+), 1
->open is only called on the whole device. Make that explicit by
passing a gendisk instead of the block_device.
Signed-off-by: Christoph Hellwig
Reviewed-by: Hannes Reinecke
Acked-by: Christian Brauner
Acked-by: Jack Wang [rnbd]
---
arch/um/drivers/ubd_kern.c | 5
The mode argument to the ->release block_device_operation is never used,
so remove it.
Signed-off-by: Christoph Hellwig
Reviewed-by: Hannes Reinecke
Acked-by: Christian Brauner
Acked-by: Jack Wang [rnbd]
---
arch/um/drivers/ubd_kern.c | 4 ++--
Signed-off-by: Christoph Hellwig
Reviewed-by: Phillip Potter
Reviewed-by: Hannes Reinecke
Acked-by: Christian Brauner
---
drivers/cdrom/cdrom.c | 2 +-
drivers/cdrom/gdrom.c | 2 +-
drivers/scsi/sr.c | 2 +-
include/linux/cdrom.h | 4 ++--
4 files changed, 5 insertions(+), 5 deletions(-)
sb is just an on-stack pointer that can easily be reused by other calls.
Switch to use the bcache-wide bcache_kobj instead as there is no need to
claim per-bcache device anyway.
Signed-off-by: Christoph Hellwig
Reviewed-by: Hannes Reinecke
---
drivers/md/bcache/super.c | 2 +-
1 file changed,
Passing a holder to blkdev_get_by_path when FMODE_EXCL isn't set doesn't
make sense, so pass NULL instead and remove the holder argument from the
call chains the only end up in non-FMODE_EXCL blkdev_get_by_path calls.
Exclusive mode for device scanning is not used since commit 50d281fc434c
Instead of passing a fmode_t and only checking it for FMODE_WRITE, pass
a bool open_for_write to prepare for callers that won't have the fmode_t.
Signed-off-by: Christoph Hellwig
Reviewed-by: Martin K. Petersen
Reviewed-by: Hannes Reinecke
Acked-by: Christian Brauner
---
block/bsg-lib.c
Make the function name match the method name.
Signed-off-by: Christoph Hellwig
Reviewed-by: Hannes Reinecke
Acked-by: Christian Brauner
---
block/fops.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/block/fops.c b/block/fops.c
index 6a3087b750a6cd..26af2b39c758e1
On Thu, Jun 08, 2023 at 11:11:44AM +0200, Roger Pau Monné wrote:
> On Wed, Jun 07, 2023 at 12:29:26PM -0400, Demi Marie Obenour wrote:
> > On Wed, Jun 07, 2023 at 10:44:48AM +0200, Roger Pau Monné wrote:
> > > On Tue, Jun 06, 2023 at 01:31:25PM -0400, Demi Marie Obenour wrote:
> > > > On Tue, Jun
On Thu, Jun 08, 2023 at 12:08:55PM +0200, Roger Pau Monné wrote:
> On Tue, May 30, 2023 at 04:31:16PM -0400, Demi Marie Obenour wrote:
> > Set "opened" to "0" before the hotplug script is called. Once the
> > device node has been opened, set "opened" to "1".
> >
> > "opened" is used exclusively
On Thu, Jun 08, 2023 at 10:29:18AM +0200, Roger Pau Monné wrote:
> On Wed, Jun 07, 2023 at 12:14:46PM -0400, Demi Marie Obenour wrote:
> > On Wed, Jun 07, 2023 at 10:20:08AM +0200, Roger Pau Monné wrote:
> > > On Tue, Jun 06, 2023 at 01:01:20PM -0400, Demi Marie Obenour wrote:
> > > > On Tue, Jun
On Wed, Jun 07, 2023 at 10:03:40PM -0400, Martin K. Petersen wrote:
>
> Dave,
>
> > Possibly unintentionally, I didn't call it REQ_OP_PROVISION but that's
> > what I intended - the operation does not contain data at all. It's an
> > operation like REQ_OP_DISCARD or REQ_OP_WRITE_ZEROS - it
On Wed, Jun 07, 2023 at 07:50:25PM -0400, Mike Snitzer wrote:
> Do you think you're OK to scope out, and/or implement, the XFS changes
> if you use v7 of this patchset as the starting point? (v8 should just
> be v7 minus the dm-thin.c and dm-snap.c changes). The thinp
> support in v7 will work
On Wed, Jun 7, 2023 at 7:41 PM Yu Kuai wrote:
>
> Hi,
>
> 在 2023/05/29 21:20, Yu Kuai 写道:
> > From: Yu Kuai
> >
> > Changes in v2:
> > - rebase for the latest md-next
> >
> > Patch 1 revert the commit because it will cause MD_RECOVERY_RUNNING to be
> > cleared while sync_thread is still
On Fri, May 19 2023 at 11:23P -0400,
Mike Snitzer wrote:
> On Thu, May 18 2023 at 6:33P -0400,
> Sarthak Kukreti wrote:
>
> > dm-thinpool uses the provision request to provision
> > blocks for a dm-thin device. dm-thinpool currently does not
> > pass through REQ_OP_PROVISION to underlying
On Thu, Jun 08 2023 at 5:24P -0400,
Mike Snitzer wrote:
> On Fri, May 19 2023 at 11:23P -0400,
> Mike Snitzer wrote:
>
> > On Thu, May 18 2023 at 6:33P -0400,
> > Sarthak Kukreti wrote:
> >
> > > dm-thinpool uses the provision request to provision
> > > blocks for a dm-thin device.
On Thu, Jun 08, 2023 at 05:38:17PM +0530, Nitesh Shetty wrote:
> Sure, we can do away with subsys and realign more on single namespace copy.
> We are planning to use token to store source info, such as src sector,
> len and namespace. Something like below,
>
> struct nvme_copy_token {
>
85 matches
Mail list logo
