Ben,
does this patch actually break the Red Hat integration ?
I'm inclined to merge it if not.
Thanks,
Christophe
On Tue, May 3, 2016 at 7:44 AM, Hannes Reinecke wrote:
> On 05/02/2016 05:31 PM, Benjamin Marzinski wrote:
> > On Wed, Apr 27, 2016 at 01:10:23PM +0200, Hannes Reinecke wrote:
> >>
On 05/03/2016 04:30 AM, Benjamin Marzinski wrote:
> On Wed, Apr 27, 2016 at 01:10:50PM +0200, Hannes Reinecke wrote:
>> When the daemon is started prior to udev the paths are not present
>> (yet). However, the maps themselves will be read from device-mapper.
>> This causes existing maps to be dropp
On 05/03/2016 12:23 AM, Benjamin Marzinski wrote:
> On Wed, Apr 27, 2016 at 01:10:37PM +0200, Hannes Reinecke wrote:
>> Instead of generating the cookie internally we should be
>> passing in the cookie to dm_addmap().
>
> These look like they could actually cause problems. With
> dm_addmap_create
On 05/02/2016 09:14 PM, Benjamin Marzinski wrote:
> On Wed, Apr 27, 2016 at 01:10:31PM +0200, Hannes Reinecke wrote:
>> libudev has a separate filter setting to skip uninitialized
>> devices during enumeration.
>
> So, I assume if udev filters out a device here, it's because a uevent
> should be c
On 05/02/2016 06:26 PM, Benjamin Marzinski wrote:
> On Wed, Apr 27, 2016 at 01:10:29PM +0200, Hannes Reinecke wrote:
>> udev since v214 is placing a shared lock on the device node
>> whenever it's processing the event. This introduces a race
>> condition with multipathd, as multipathd is processing
On 05/02/2016 05:43 PM, Benjamin Marzinski wrote:
> On Wed, Apr 27, 2016 at 01:10:24PM +0200, Hannes Reinecke wrote:
>
> Again. I'd prefer leaving the messages in either at a higher log level
> or with less alarming text.
>
I'm fine with moving it to log level 4.
Cheers,
Hannes
--
Dr. Hannes R
On 05/02/2016 05:40 PM, Benjamin Marzinski wrote:
> On Wed, Apr 27, 2016 at 01:10:20PM +0200, Hannes Reinecke wrote:
>> When looking up a path in the existing configuration it is perfectly
>> possible for the path not to be present.
>> This should not generate a message as it might be errorneously
On 05/02/2016 05:31 PM, Benjamin Marzinski wrote:
> On Wed, Apr 27, 2016 at 01:10:23PM +0200, Hannes Reinecke wrote:
>> multipath should be using the option '-i' to ignore the wwids
>> file when called from udev. Otherwise we might run into a race
>> condition with systemd and the system might not
On Wed, Apr 27, 2016 at 01:10:50PM +0200, Hannes Reinecke wrote:
> When the daemon is started prior to udev the paths are not present
> (yet). However, the maps themselves will be read from device-mapper.
> This causes existing maps to be dropped in coalesce_maps(), only
> to be reinstated later wh
On Wed, Apr 27, 2016 at 01:10:41PM +0200, Hannes Reinecke wrote:
I usually try to follow the lead of the cookie using-code of the lvm2
library, and that doesn't call udev_complete() on dm_task_set_cookie()
failures. However, it does look like there is a possible problem with
dm_task_set_cookie ->
On Wed, Apr 27, 2016 at 01:10:38PM +0200, Hannes Reinecke wrote:
> The 'udev_sync' attribute is pointless without a cookie, so we
> can as well use the existence of the 'cookie' argument for
> the same function.
ACK. But I do worry that dm_simplecmd is still going to confuse someone
later. Right n
On 05/02/2016 12:28 PM, Laurence Oberman wrote:
Even in the case of the ib_srp, don't we also have to still run the
eh_timeout for each of the devices that has inflight requiring error
handling serially. This means we will still have to wait to get a
path failover until all are through the timeou
On Wed, Apr 27, 2016 at 01:10:37PM +0200, Hannes Reinecke wrote:
> Instead of generating the cookie internally we should be
> passing in the cookie to dm_addmap().
These look like they could actually cause problems. With
dm_addmap_create and dm_addmap_reload, you could be in a situation where
you
Laurence Oberman
Principal Software Maintenance Engineer
Red Hat Global Support Services
- Original Message -
From: "Bart Van Assche"
To: "Laurence Oberman"
Cc: linux-bl...@vger.kernel.org, "linux-scsi" ,
"Mike Snitzer" , "James Bottomley"
, "device-mapper development"
, l...@lists.
On Wed, Apr 27, 2016 at 01:10:31PM +0200, Hannes Reinecke wrote:
> libudev has a separate filter setting to skip uninitialized
> devices during enumeration.
So, I assume if udev filters out a device here, it's because a uevent
should be coming when the device is fully initialized. correct?
The on
On 04/29/2016 05:47 PM, Laurence Oberman wrote:
From: "Bart Van Assche"
To: "Laurence Oberman"
Cc: "James Bottomley" , "linux-scsi" ,
"Mike Snitzer" , linux-bl...@vger.kernel.org, "device-mapper development"
, l...@lists.linux-foundation.org
Sent: Friday, April 29, 2016 8:36:22 PM
Subject: Re
On 05/02/2016 05:12 PM, Benjamin Marzinski wrote:
> On Mon, May 02, 2016 at 07:48:50AM +0200, Hannes Reinecke wrote:
>> On 04/30/2016 12:39 AM, Benjamin Marzinski wrote:
>>> On Wed, Apr 27, 2016 at 01:10:21PM +0200, Hannes Reinecke wrote:
When we remove a path it's totally pointless to add it
On Wed, Apr 27, 2016 at 01:10:29PM +0200, Hannes Reinecke wrote:
> udev since v214 is placing a shared lock on the device node
> whenever it's processing the event. This introduces a race
> condition with multipathd, as multipathd is processing the
> event for the block device at the same time as u
On Wed, Apr 27, 2016 at 01:10:20PM +0200, Hannes Reinecke wrote:
> When looking up a path in the existing configuration it is perfectly
> possible for the path not to be present.
> This should not generate a message as it might be errorneously
> interpreted as an error.
>
Do you feel really stron
On Wed, Apr 27, 2016 at 01:10:24PM +0200, Hannes Reinecke wrote:
Again. I'd prefer leaving the messages in either at a higher log level
or with less alarming text.
-Ben
> Signed-off-by: Hannes Reinecke
> ---
> multipath/main.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/multipath/
On Wed, Apr 27, 2016 at 01:10:23PM +0200, Hannes Reinecke wrote:
> multipath should be using the option '-i' to ignore the wwids
> file when called from udev. Otherwise we might run into a race
> condition with systemd and the system might not boot up correctly.
The race condition being? Are you t
On Mon, May 02, 2016 at 07:48:50AM +0200, Hannes Reinecke wrote:
> On 04/30/2016 12:39 AM, Benjamin Marzinski wrote:
> > On Wed, Apr 27, 2016 at 01:10:21PM +0200, Hannes Reinecke wrote:
> >> When we remove a path it's totally pointless to add it to
> >> the path list first; it'll be removed on the
Hi,
One of device mappers was lost unexpectedly:
iscsid: [warning] Connection7:0 to [target:
iqn.1992-04.xxx.xxx:cx.x.b7, portal: xxx.xxx.xx.xx,3260]
through [iface: default] is shutdown.
Just after recovering:
Entering recovery mode: max_retries=60
Before losing connection
On Fri 29-04-16 14:54:52, Mike Snitzer wrote:
> On Thu, Apr 28 2016 at 9:24am -0400,
> Michal Hocko wrote:
>
> > From: Michal Hocko
> >
> > copy_params seems to be little bit confused about which allocation flags
> > to use. It enforces GFP_NOIO even though it uses
> > memalloc_noio_{save,rest
24 matches
Mail list logo
