Re: [dm-devel] remove REQ_OP_WRITE_SAME

Christoph, > Now that we are using REQ_OP_WRITE_ZEROES for all zeroing needs in the > kernel there is very little use left for REQ_OP_WRITE_SAME. We only > have two callers left, and both just export optional protocol features > to remote systems: DRBD and the target code. While I'm not particu

Re: [dm-devel] [PATCH] Re: [Report] crash tool cannot resolve struct dm_table properly

On 04/14/2017 05:53 AM, Mikulas Patocka wrote: On Thu, 13 Apr 2017, Eric Ren wrote: Hi, On 04/13/2017 07:28 PM, Mikulas Patocka wrote: On Thu, 13 Apr 2017, Eric Ren wrote: Hi Mikulas, When inspecting on coredump with crash tool, I find that 'dm_table' cannot be resolved properly as follo

Re: [dm-devel] [PATCH] multipath-tools: replace multipath configuration output

On 04/12/2017 09:35 AM, Christophe Varoqui wrote: > Merged, No, it's missing. > On Sat, Apr 8, 2017 at 3:30 PM, Xose Vazquez Perez > wrote: > > Cc: Christophe Varoqui > > Cc: device-mapper development

Re: [dm-devel] [PATCH 0/1] Missing RDAC patch

On 04/13/2017 05:39 PM, Martin Wilck wrote: > I'm sending this on Hannes' behalf now. Sorry we didn't make it for 0.7.0. You're lucky, 0.7.0 release wasn't tagged yet. > Hannes Reinecke (1): > libmultipath/propsel: Do not select sysfs prioritizer for RDAC arrays > > libmultipath/discovery.c |

Re: [dm-devel] [PATCH 17/33] multipathd: imply -n if find_multipaths is set

On Wed, Apr 12, 2017 at 11:36:26PM +0200, Martin Wilck wrote: > On Wed, 2017-04-05 at 18:03 -0500, Benjamin Marzinski wrote: > > On Tue, Feb 28, 2017 at 05:23:13PM +0100, Martin Wilck wrote: > > > Automatic detection of new devices with find_multipaths > > > doesn't work correctly currently. Theref

[dm-devel] [PATCH] Re: [Report] crash tool cannot resolve struct dm_table properly

On Thu, 13 Apr 2017, Eric Ren wrote: > Hi, > > > On 04/13/2017 07:28 PM, Mikulas Patocka wrote: > > > > On Thu, 13 Apr 2017, Eric Ren wrote: > > > > > Hi Mikulas, > > > > > > When inspecting on coredump with crash tool, I find that 'dm_table' cannot > > > be > > > resolved properly as follo

Re: [dm-devel] [PATCH 08/25] scsi: fix fast-fail for non-passthrough requests

On Thu, 2017-04-06 at 17:39 +0200, Christoph Hellwig wrote: > Currently error is always 0 for non-passthrough requests when reaching the > scsi_noretry_cmd check in scsi_io_completion, which effectively disables > all fastfail logic. Fix this by having a single call to > __scsi_error_from_host_byt

Re: [dm-devel] [PATCH 06/25] virtio: fix spelling of virtblk_scsi_request_done

On Thu, 2017-04-06 at 17:39 +0200, Christoph Hellwig wrote: > [ ... ] Reviewed-by: Bart Van Assche -- dm-devel mailing list dm-devel@redhat.com https://www.redhat.com/mailman/listinfo/dm-devel

Re: [dm-devel] [PATCH 02/25] block: remove the blk_execute_rq return value

On Thu, 2017-04-06 at 17:39 +0200, Christoph Hellwig wrote: > diff --git a/fs/nfsd/blocklayout.c b/fs/nfsd/blocklayout.c > index 92b4b41d19d2..4b72fdf67548 100644 > --- a/fs/nfsd/blocklayout.c > +++ b/fs/nfsd/blocklayout.c > @@ -242,8 +242,8 @@ static int nfsd4_scsi_identify_device(struct block_dev

Re: [dm-devel] [PATCH 01/25] remove the mg_disk driver

On Thu, 2017-04-06 at 17:39 +0200, Christoph Hellwig wrote: > This drivers was added in 2008, but as far as a I can tell we never had a > single platform that actually registered resources for the platform driver. > > It's also been unmaintained for a long time and apparently has a ATA mode > that

Re: [dm-devel] [PATCH 7/9] multipathd: allow devices to switch from RW to RO

On Thu, Apr 13, 2017 at 04:39:45PM +0200, Martin Wilck wrote: > On Fri, 2017-04-07 at 01:16 -0500, Benjamin Marzinski wrote: > > Whenever multipathd tries to reload a device, even if it's because a > > path switched from read/write to read-only, it tries to load the > > device > > read/write first,

Re: [dm-devel] [PATCH v4 6/6] dm rq: Avoid that request processing stalls sporadically

On 04/12/17 19:20, Ming Lei wrote: > On Wed, Apr 12, 2017 at 06:38:07PM +, Bart Van Assche wrote: >> If the blk-mq core would always rerun a hardware queue if a block driver >> returns BLK_MQ_RQ_QUEUE_BUSY then that would cause 100% of a single CPU core > > It won't casue 100% CPU utilization

Re: [dm-devel] [PATCH 1/2] multipath: Merge the DELL MD3xxx device configs

On Thu, Apr 13, 2017 at 10:44:43AM +0200, Johannes Thumshirn wrote: > Hi Benjamin, > > On Wed, Apr 12, 2017 at 05:15:09PM -0500, Benjamin Marzinski wrote: > > All of the Dell MD3xxx configs are identical, so we can't just use > can? ^ Oops. Yes. Th

[dm-devel] [PATCH 1/1] libmultipath/propsel: Do not select sysfs prioritizer for RDAC arrays

From: Hannes Reinecke Recent RDAC (NetApp E-Series) firmware implemented an internal load balancer and switched to implicit ALUA. Unfortunately the load balancer relies on periodic REPORT TARGET PORT GROUPS from the host, so we cannot use the sysfs prioritizer here. References: bsc#1004858 Sign

[dm-devel] [PATCH 0/1] Missing RDAC patch

Hi Cristophe, I'm sending this on Hannes' behalf now. Sorry we didn't make it for 0.7.0. Regards, Martin Hannes Reinecke (1): libmultipath/propsel: Do not select sysfs prioritizer for RDAC arrays libmultipath/discovery.c | 2 +- libmultipath/discovery.h | 1 + libmultipath/propsel.c | 24

Re: [dm-devel] [PATCH 0/9] misc cleanups and bugfixes

On Fri, 2017-04-07 at 01:16 -0500, Benjamin Marzinski wrote: > These patches are all just small cleanup and bugfixes. > > Benjamin Marzinski (9): >   libdmmp: minor Makefile cleanup >   multipath-tools: remove incdir from Makefiles >   libdmmp: don't disconnect from multipathd twice >   multipathd

Re: [dm-devel] [PATCH 7/9] multipathd: allow devices to switch from RW to RO

On Fri, 2017-04-07 at 01:16 -0500, Benjamin Marzinski wrote: > Whenever multipathd tries to reload a device, even if it's because a > path switched from read/write to read-only, it tries to load the > device > read/write first, and then falls back to read-only. When device- > mapper > sees that mul

Re: [dm-devel] [PATCH 1/2] multipath: Merge the DELL MD3xxx device configs

On Wed, 2017-04-12 at 17:15 -0500, Benjamin Marzinski wrote: > All of the Dell MD3xxx configs are identical, so we can't just use > one config for them. > > Cc: Xose Vazquez Perez > Signed-off-by: Benjamin Marzinski > --- Reviewed-by: Martin Wilck -- Dr. Martin Wilck , Tel. +49 (0)911 74053 2

Re: [dm-devel] [PATCH 2/2] multipath: attempt at common multipath.rules

Hi Ben, > This is a proposal to try and bring the Redhat and SuSE > multipath.rules > closer. There are a couple of changes that I'd like some input on. Thanks for making this so explicit. Perhaps we should have done the same for our recent changes, in particular d7188fcd "multipathd: start daemo

Re: [dm-devel] [Report] crash tool cannot resolve struct dm_table properly

Hey! On 04/13/2017 06:29 PM, Steffen Maier wrote: On 04/13/2017 12:22 PM, Steffen Maier wrote: [...snip...] Does this help somewhat?: https://www.redhat.com/archives/dm-devel/2015-December/msg00042.html Thanks, I didn't notice that thread. Yes, it will help! As workaround for eppic script

Re: [dm-devel] [PATCH 2/9] multipath-tools: remove incdir from Makefiles

On Fri, 2017-04-07 at 01:16 -0500, Benjamin Marzinski wrote: > Makefile.in defines both incdir and includedir, and they are both the > same. This patch removes incdir, and makes all the Makefiles use > includedir. > > Signed-off-by: Benjamin Marzinski > --- To be fair, incdir was there before in

[dm-devel] [PATCH] Revert "multipathd: set timeout for CLI commands correctly"

This reverts commit a002d124723cef3f2bb4fc33899d2613bdfe3924. uxsock_timeout is in ms (argument to poll()), whereas parse_cmd() uses the value to add to tv_sec in a struct timespec. So the previous code was correct. Signed-off-by: Martin Wilck --- multipathd/main.c | 2 +- 1 file changed, 1 ins

[dm-devel] [PATCH] libmultipath: fix skip_kpartx support for removing maps

Commit 79a05a4e inadvertently removed the code necessary to support multipath maps without partitions, as introduced in b73a34ea "libmultipath: add skip_kpartx option". Revert this part of the commit, so that skip_kpartx works again. Fixes: 79a05a4e libmultipath: move suspend logic to _dm_flush_ma

Re: [dm-devel] [Report] crash tool cannot resolve struct dm_table properly

Hi, On 04/13/2017 07:28 PM, Mikulas Patocka wrote: On Thu, 13 Apr 2017, Eric Ren wrote: Hi Mikulas, When inspecting on coredump with crash tool, I find that 'dm_table' cannot be resolved properly as follows: === crash> struct dm_table struct dm_table { int undefined__; } SIZE: 4 ===

Re: [dm-devel] [Report] crash tool cannot resolve struct dm_table properly

On Thu, 13 Apr 2017, Eric Ren wrote: > Hi Mikulas, > > When inspecting on coredump with crash tool, I find that 'dm_table' cannot be > resolved properly as follows: > > === > crash> struct dm_table > struct dm_table { > int undefined__; > } > SIZE: 4 > === > > Looks this issue is introduc

Re: [dm-devel] [Report] crash tool cannot resolve struct dm_table properly

On 04/13/2017 12:22 PM, Steffen Maier wrote: On 04/13/2017 04:01 AM, Eric Ren wrote: Hi Mikulas, When inspecting on coredump with crash tool, I find that 'dm_table' cannot be resolved properly as follows: === crash> struct dm_table struct dm_table { int undefined__; } SIZE: 4 === Looks th

Re: [dm-devel] [Report] crash tool cannot resolve struct dm_table properly

On 04/13/2017 04:01 AM, Eric Ren wrote: Hi Mikulas, When inspecting on coredump with crash tool, I find that 'dm_table' cannot be resolved properly as follows: === crash> struct dm_table struct dm_table { int undefined__; } SIZE: 4 === Looks this issue is introduced by 83d5e5b (dm: optimiz

Re: [dm-devel] [PATCH 1/2] multipath: Merge the DELL MD3xxx device configs

Hi Benjamin, On Wed, Apr 12, 2017 at 05:15:09PM -0500, Benjamin Marzinski wrote: > All of the Dell MD3xxx configs are identical, so we can't just use can? ^ > one config for them. > > Cc: Xose Vazquez Perez > Signed-off-by: Benjamin Marzinski > -

Re: [dm-devel] : Multipath Setup for NVMe over Fabric

On Wed, 2017-04-12 at 14:50 +0530, Ankur Srivastava wrote: > Hi All,  > > I am working on NVMe over fabric and want to experiment the > Multipathing support for the same. > > Setup Info: > RHEL 7.2 with Kernel 4.9.3 > > > [root@localhost ~]# nvme list > Node             SN                   Mod