Re: [dm-devel] [PATCH 1/1] block: Convert hd_struct in_flight from atomic to percpu

2017-06-28 Thread Jens Axboe
On 06/28/2017 04:07 PM, Brian King wrote: > On 06/28/2017 04:59 PM, Jens Axboe wrote: >> On 06/28/2017 03:54 PM, Jens Axboe wrote: >>> On 06/28/2017 03:12 PM, Brian King wrote: -static inline int part_in_flight(struct hd_struct *part) +static inline unsigned long part_in_flight(struct hd_

Re: [dm-devel] [PATCH 1/1] block: Convert hd_struct in_flight from atomic to percpu

2017-06-28 Thread Brian King
On 06/28/2017 04:59 PM, Jens Axboe wrote: > On 06/28/2017 03:54 PM, Jens Axboe wrote: >> On 06/28/2017 03:12 PM, Brian King wrote: >>> -static inline int part_in_flight(struct hd_struct *part) >>> +static inline unsigned long part_in_flight(struct hd_struct *part) >>> { >>> - return atomic_read(

Re: [dm-devel] [PATCH 1/1] block: Convert hd_struct in_flight from atomic to percpu

2017-06-28 Thread Brian King
On 06/28/2017 04:49 PM, Jens Axboe wrote: > On 06/28/2017 03:12 PM, Brian King wrote: >> This patch converts the in_flight counter in struct hd_struct from a >> pair of atomics to a pair of percpu counters. This eliminates a couple >> of atomics from the hot path. When running this on a Power syste

Re: [dm-devel] [PATCH 1/1] block: Convert hd_struct in_flight from atomic to percpu

2017-06-28 Thread Jens Axboe
On 06/28/2017 03:54 PM, Jens Axboe wrote: > On 06/28/2017 03:12 PM, Brian King wrote: >> -static inline int part_in_flight(struct hd_struct *part) >> +static inline unsigned long part_in_flight(struct hd_struct *part) >> { >> -return atomic_read(&part->in_flight[0]) + >> atomic_read(&part->in

Re: [dm-devel] [PATCH 1/1] block: Convert hd_struct in_flight from atomic to percpu

2017-06-28 Thread Jens Axboe
On 06/28/2017 03:12 PM, Brian King wrote: > -static inline int part_in_flight(struct hd_struct *part) > +static inline unsigned long part_in_flight(struct hd_struct *part) > { > - return atomic_read(&part->in_flight[0]) + > atomic_read(&part->in_flight[1]); > + return part_stat_read(part,

Re: [dm-devel] [PATCH 1/1] block: Convert hd_struct in_flight from atomic to percpu

2017-06-28 Thread Jens Axboe
On 06/28/2017 03:12 PM, Brian King wrote: > This patch converts the in_flight counter in struct hd_struct from a > pair of atomics to a pair of percpu counters. This eliminates a couple > of atomics from the hot path. When running this on a Power system, to > a single null_blk device with 80 submis

[dm-devel] [PATCH 1/1] block: Convert hd_struct in_flight from atomic to percpu

2017-06-28 Thread Brian King
This patch converts the in_flight counter in struct hd_struct from a pair of atomics to a pair of percpu counters. This eliminates a couple of atomics from the hot path. When running this on a Power system, to a single null_blk device with 80 submission queues, irq mode 0, with 80 fio jobs, I saw

Re: [dm-devel] [PATCH] libmultipath: update 3PARdata builtin config

2017-06-28 Thread Xose Vazquez Perez
On 06/26/2017 09:03 PM, Benjamin Marzinski wrote: > This updated config comes from hp. It would be nice to have more information. Why and when is this needed? BTW: HPE 'MSA 205x' and 'StoreVirtual 3200'(LeftHand) are missing. > Signed-off-by: Benjamin Marzinski > --- > libmultipath/hwtable.c

Re: [dm-devel] [PATCH RESEND] dm-raid: Do not call BUG() in __rdev_sectors()

2017-06-28 Thread Mike Snitzer
On Wed, Jun 28 2017 at 4:04P -0400, Hannes Reinecke wrote: > __rdev_sectors() might be called for an invalid/non-existing > RAID set during raid_ctr(), which is perfectly fine and no > reason to panic. > > Signed-off-by: Hannes Reinecke > --- > drivers/md/dm-raid.c | 3 ++- > 1 file changed,

Re: [dm-devel] [PATCH 2/2] multipath: attempt at common multipath.rules

2017-06-28 Thread Martin Wilck
On Tue, 2017-06-27 at 23:41 +0200, Martin Wilck wrote: > > > The other change is the redhat multipath rules remove the partition > > device nodes for devices claimed by multipath. The udev rule will > > only > > do this one time (both to keep from running partx on every event, > > and > > so > > t

Re: [dm-devel] [PATCH] dm-raid: Do not call BUG() in __rdev_sectors()

2017-06-28 Thread Hannes Reinecke
On 06/28/2017 09:55 AM, Hannes Reinecke wrote: > __rdev_sectors() might be called for an invalid/non-existing > RAID set during raid_ctr(), which is perfectly fine and no > reason to panic. > > Signed-off-by: Hannes Reinecke > --- > drivers/md/dm-raid.c | 3 ++- > drivers/scsi/pmcraid.c

[dm-devel] [PATCH RESEND] dm-raid: Do not call BUG() in __rdev_sectors()

2017-06-28 Thread Hannes Reinecke
__rdev_sectors() might be called for an invalid/non-existing RAID set during raid_ctr(), which is perfectly fine and no reason to panic. Signed-off-by: Hannes Reinecke --- drivers/md/dm-raid.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/md/dm-raid.c b/drivers/md

Re: [dm-devel] [PATCH] dm-raid: Do not call BUG() in __rdev_sectors()

2017-06-28 Thread Johannes Thumshirn
On Wed, Jun 28, 2017 at 09:55:03AM +0200, Hannes Reinecke wrote: > __rdev_sectors() might be called for an invalid/non-existing > RAID set during raid_ctr(), which is perfectly fine and no > reason to panic. > > Signed-off-by: Hannes Reinecke > --- > drivers/md/dm-raid.c | 3 ++- > driv

[dm-devel] [PATCH] dm-raid: Do not call BUG() in __rdev_sectors()

2017-06-28 Thread Hannes Reinecke
__rdev_sectors() might be called for an invalid/non-existing RAID set during raid_ctr(), which is perfectly fine and no reason to panic. Signed-off-by: Hannes Reinecke --- drivers/md/dm-raid.c | 3 ++- drivers/scsi/pmcraid.c| 2 +- drivers/scsi/qla4xxx/ql4_os.c | 2 +- 3 files c