Re: [dm-devel] xts fuzz testing and lack of ciphertext stealing support

2019-08-09 Thread Ard Biesheuvel
On Fri, 9 Aug 2019 at 23:57, Pascal Van Leeuwen wrote: > > > -Original Message- > > From: Ard Biesheuvel > > Sent: Friday, August 9, 2019 7:49 PM > > To: Horia Geanta > > Cc: Herbert Xu ; Pascal Van Leeuwen > > ; Milan Broz ; > > dm-devel@redhat.com; linux- > > cry...@vger.kernel.org >

Re: [PATCH] direct-io: use GFP_NOIO to avoid deadlock

2019-08-09 Thread Dave Chinner
On Fri, Aug 09, 2019 at 07:30:00AM -0400, Mikulas Patocka wrote: > > > On Fri, 9 Aug 2019, Dave Chinner wrote: > > > And, FWIW, there's an argument to be made here that the underlying > > bug is dm_bufio_shrink_scan() blocking kswapd by waiting on IO > > completions while holding a mutex that

RE: [dm-devel] xts fuzz testing and lack of ciphertext stealing support

2019-08-09 Thread Pascal Van Leeuwen
> -Original Message- > From: Ard Biesheuvel > Sent: Friday, August 9, 2019 7:49 PM > To: Horia Geanta > Cc: Herbert Xu ; Pascal Van Leeuwen > ; Milan Broz ; > dm-devel@redhat.com; linux- > cry...@vger.kernel.org > Subject: Re: [dm-devel] xts fuzz testing and lack of ciphertext stealing

Re: [RFC PATCH v2] md/dm-crypt - reuse eboiv skcipher for IV generation

2019-08-09 Thread Ard Biesheuvel
On Thu, 8 Aug 2019 at 14:53, Milan Broz wrote: > > Hi, > > On 07/08/2019 07:50, Ard Biesheuvel wrote: > > Instead of instantiating a separate cipher to perform the encryption > > needed to produce the IV, reuse the skcipher used for the block data > > and invoke it one additional time for each

Re: [dm-devel] xts fuzz testing and lack of ciphertext stealing support

2019-08-09 Thread Ard Biesheuvel
On Fri, 9 Aug 2019 at 10:44, Horia Geanta wrote: > > On 8/9/2019 9:45 AM, Ard Biesheuvel wrote: > > On Fri, 9 Aug 2019 at 05:48, Herbert Xu wrote: > >> > >> On Thu, Aug 08, 2019 at 06:01:49PM +, Horia Geanta wrote: > >>> > >>> -- >8 -- > >>> > >>> Subject: [PATCH] crypto: testmgr - Add

Re: [PATCH] direct-io: use GFP_NOIO to avoid deadlock

2019-08-09 Thread Mikulas Patocka
On Fri, 9 Aug 2019, Dave Chinner wrote: > And, FWIW, there's an argument to be made here that the underlying > bug is dm_bufio_shrink_scan() blocking kswapd by waiting on IO > completions while holding a mutex that other IO-level reclaim > contexts require to make progress. > > Cheers, > >

Re: [dm-devel] [PATCH 2/2] scsi: core: fix dh and multipathing for SCSI hosts without request batching

2019-08-09 Thread kbuild test robot
Hi Steffen, I love your patch! Perhaps something to improve: [auto build test WARNING on linus/master] [cannot apply to v5.3-rc3 next-20190808] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url:

RE: [dm-devel] xts fuzz testing and lack of ciphertext stealing support

2019-08-09 Thread Pascal Van Leeuwen
> -Original Message- > From: Horia Geanta > Sent: Thursday, August 8, 2019 4:50 PM > To: Pascal Van Leeuwen ; Ard Biesheuvel > > Cc: Milan Broz ; Herbert Xu > ; dm- > de...@redhat.com; linux-cry...@vger.kernel.org > Subject: Re: [dm-devel] xts fuzz testing and lack of ciphertext

Re: [dm-devel] xts fuzz testing and lack of ciphertext stealing support

2019-08-09 Thread Horia Geanta
On 8/9/2019 9:45 AM, Ard Biesheuvel wrote: > On Fri, 9 Aug 2019 at 05:48, Herbert Xu wrote: >> >> On Thu, Aug 08, 2019 at 06:01:49PM +, Horia Geanta wrote: >>> >>> -- >8 -- >>> >>> Subject: [PATCH] crypto: testmgr - Add additional AES-XTS vectors for >>> covering >>> CTS (part II) >> >>

Re: [dm-devel] xts fuzz testing and lack of ciphertext stealing support

2019-08-09 Thread Ard Biesheuvel
On Fri, 9 Aug 2019 at 05:48, Herbert Xu wrote: > > On Thu, Aug 08, 2019 at 06:01:49PM +, Horia Geanta wrote: > > > > -- >8 -- > > > > Subject: [PATCH] crypto: testmgr - Add additional AES-XTS vectors for > > covering > > CTS (part II) > > Patchwork doesn't like it when you do this and it'll