Re: [dm-devel] [PATCH V8 01/11] block: clone nr_integrity_segments and write_hint in blk_rq_prep_clone

2020-04-24 Thread Martin K. Petersen
Ming, > So far blk_rq_prep_clone() is only used for setup one underlying > cloned request from dm-rq request. block intetrity can be enabled for > both dm-rq and the underlying queues, so it is reasonable to clone > rq's nr_integrity_segments. Also write_hint is from bio, it should > have been c

Re: [dm-devel] [PATCH V8 02/11] block: add helper for copying request

2020-04-24 Thread Martin K. Petersen
Ming, > Add one new helper of blk_rq_copy_request() to copy request, and the > helper will be used in this patch for re-submitting request, so make > it as a block layer internal helper. Reviewed-by: Martin K. Petersen -- Martin K. Petersen Oracle Linux Engineering -- dm-devel mailing

Re: [dm-devel] 'multipath add path' returns ok but the path is missing in the topology

2020-04-24 Thread Martin Wilck
On Fri, 2020-04-24 at 15:18 +0200, Gioh Kim wrote: > > I would like to inform you of what I found out. > 1. 'multipathd add path sdx' is executed > 2. Adding thd sdx also creates a map. > 3. The multipathd daemon waits for the change uevent from kernel. > 4. Another sd device sdy is added with 'mu

Re: [dm-devel] [PATCH V8 02/11] block: add helper for copying request

2020-04-24 Thread Hannes Reinecke
On 4/24/20 12:23 PM, Ming Lei wrote: Add one new helper of blk_rq_copy_request() to copy request, and the helper will be used in this patch for re-submitting request, so make it as a block layer internal helper. Cc: John Garry Cc: Bart Van Assche Cc: Hannes Reinecke Cc: Christoph Hellwig Cc:

Re: [dm-devel] [PATCH V8 01/11] block: clone nr_integrity_segments and write_hint in blk_rq_prep_clone

2020-04-24 Thread Hannes Reinecke
On 4/24/20 12:23 PM, Ming Lei wrote: So far blk_rq_prep_clone() is only used for setup one underlying cloned request from dm-rq request. block intetrity can be enabled for both dm-rq and the underlying queues, so it is reasonable to clone rq's nr_integrity_segments. Also write_hint is from bio, i

Re: [dm-devel] [PATCH V8 02/11] block: add helper for copying request

2020-04-24 Thread Christoph Hellwig
On Fri, Apr 24, 2020 at 06:23:42PM +0800, Ming Lei wrote: > Add one new helper of blk_rq_copy_request() to copy request, and the helper > will be used in this patch for re-submitting request, so make it as a block > layer internal helper. Looks good, Reviewed-by: Christoph Hellwig -- dm-devel

Re: [dm-devel] [PATCH V8 01/11] block: clone nr_integrity_segments and write_hint in blk_rq_prep_clone

2020-04-24 Thread Christoph Hellwig
On Fri, Apr 24, 2020 at 06:23:41PM +0800, Ming Lei wrote: > So far blk_rq_prep_clone() is only used for setup one underlying cloned > request from dm-rq request. block intetrity can be enabled for both dm-rq > and the underlying queues, so it is reasonable to clone rq's > nr_integrity_segments. Als

[dm-devel] [PATCH V8 01/11] block: clone nr_integrity_segments and write_hint in blk_rq_prep_clone

2020-04-24 Thread Ming Lei
So far blk_rq_prep_clone() is only used for setup one underlying cloned request from dm-rq request. block intetrity can be enabled for both dm-rq and the underlying queues, so it is reasonable to clone rq's nr_integrity_segments. Also write_hint is from bio, it should have been cloned too. So clon

[dm-devel] [PATCH V8 02/11] block: add helper for copying request

2020-04-24 Thread Ming Lei
Add one new helper of blk_rq_copy_request() to copy request, and the helper will be used in this patch for re-submitting request, so make it as a block layer internal helper. Cc: John Garry Cc: Bart Van Assche Cc: Hannes Reinecke Cc: Christoph Hellwig Cc: Thomas Gleixner Cc: Mike Snitzer Cc:

Re: [dm-devel] dm-crypt: support using encrypted keys

2020-04-24 Thread Dmitry Baryshkov
Hello, чт, 23 апр. 2020 г. в 09:47, Milan Broz : > > On 22/04/2020 23:40, Mike Snitzer wrote: > > On Wed, Apr 22 2020 at 12:47pm -0400, > > Milan Broz wrote: > > > >> On 21/04/2020 20:27, Mike Snitzer wrote: > >>> On Mon, Apr 20 2020 at 9:46P -0400, > >>> Dmitry Baryshkov wrote: > >>> > Fr

Re: [dm-devel] 'multipath add path' returns ok but the path is missing in the topology

2020-04-24 Thread Gioh Kim
Hi Martin, On Wed, Apr 22, 2020 at 12:05 PM Martin Wilck wrote: > > Hello Gioh, > > On Wed, 2020-04-22 at 10:40 +0200, Gioh Kim wrote: > > Hi, > > > > I would like to report a bug. > > I am using network storage via SRP/SRPT over Infiniband. > > When a new sd device is created by SRP, I execute '

Re: [dm-devel] 'multipath add path' returns ok but the path is missing in the topology

2020-04-24 Thread Gioh Kim
Hi Martin, On Wed, Apr 22, 2020 at 5:40 PM Martin Wilck wrote: > > On Wed, 2020-04-22 at 16:00 +0200, Gioh Kim wrote: > > > > One question. > > Is it possible for multipathd to generate an event for removing a > > map? > > I am looking into the source code, ev_add_path and some functions > > rela

Re: [dm-devel] dm-crypt: support using encrypted keys

2020-04-24 Thread Dmitry Baryshkov
Hello, вт, 21 апр. 2020 г. в 21:59, Mike Snitzer : > > On Tue, Apr 21 2020 at 2:32P -0400, > Dmitry Baryshkov wrote: > > > вт, 21 апр. 2020 г. в 21:27, Mike Snitzer : > > > > > > On Mon, Apr 20 2020 at 9:46P -0400, > > > Dmitry Baryshkov wrote: > > > > > > > From: Dmitry Baryshkov > > > > > >

Re: [dm-devel] [RFC PATCH v3 05/12] fs: add security blob and hooks for block_device

2020-04-24 Thread Casey Schaufler
On 4/22/2020 9:42 AM, James Morris wrote: > On Wed, 15 Apr 2020, deven.de...@linux.microsoft.com wrote: > >> From: Deven Bowers >> >> Add a security blob and associated allocation, deallocation and set hooks >> for a block_device structure. >> >> Signed-off-by: Deven Bowers > Is there any feedbac