Re: [dm-devel] [PATCH V2] md: don't unregister sync_thread with reconfig_mutex held

On 12/10/21 10:16 PM, Donald Buczek wrote: Dear Guoqing, On 13.02.21 01:49, Guoqing Jiang wrote: Unregister sync_thread doesn't need to hold reconfig_mutex since it doesn't reconfigure array. And it could cause deadlock problem for raid5 as follows: 1. process A tried to reap sync thread

Re: [dm-devel] Random high CPU utilization in blk-mq with the none scheduler

On Tue, Dec 14, 2021 at 12:31:23AM +, Dexuan Cui wrote: > > From: Ming Lei > > Sent: Sunday, December 12, 2021 11:38 PM > > Ming, thanks so much for the detailed analysis! > > > From the log: > > > > 1) dm-mpath: > > - queue depth: 2048 > > - busy: 848, and 62 of them are in sw queue, so

[dm-devel] [PATCH 11/17] dm integrity: Use struct_group() to zero struct journal_sector

In preparation for FORTIFY_SOURCE performing compile-time and run-time field bounds checking for memset(), avoid intentionally writing across neighboring fields. Add struct_group() to mark region of struct journal_sector that should be initialized to zero. Cc: Alasdair Kergon Cc: Mike Snitzer

Re: [PATCH 5/5] dax: always use _copy_mc_to_iter in dax_copy_to_iter

On Mon, Dec 13, 2021 at 12:20 AM Christoph Hellwig wrote: > > On Sun, Dec 12, 2021 at 06:48:05AM -0800, Dan Williams wrote: > > On Fri, Dec 10, 2021 at 6:05 AM Vivek Goyal wrote: > > > > > > On Thu, Dec 09, 2021 at 07:38:28AM +0100, Christoph Hellwig wrote: > > > > While using the MC-safe copy

Re: [PATCH 4/5] dax: remove the copy_from_iter and copy_to_iter methods

On Sun, Dec 12, 2021 at 06:44:26AM -0800, Dan Williams wrote: > On Fri, Dec 10, 2021 at 6:17 AM Vivek Goyal wrote: > > > > On Thu, Dec 09, 2021 at 07:38:27AM +0100, Christoph Hellwig wrote: > > > These methods indirect the actual DAX read/write path. In the end pmem > > > uses magic flush and mc

Re: [dm-devel] [PATCH] multipathd: handle fpin events

Hello Martin, That is exactly the reason why we would need to modularise this. Access characteristics between different transport protocols can differ significantly and thus are susceptible to different indicators, tolerances and other variations that would need a different config setup. You

Re: [PATCH 3/5] dax: remove the DAXDEV_F_SYNC flag

> Remove the DAXDEV_F_SYNC flag and thus the flags argument to alloc_dax and > just let the drivers call set_dax_synchronous directly. > > Signed-off-by: Christoph Hellwig > --- > drivers/dax/bus.c| 3 ++- > drivers/dax/super.c | 6 +- > drivers/md/dm.c | 2

Re: [PATCH 1/5] uio: remove copy_from_iter_flushcache() and copy_mc_to_iter()

On Sun, Dec 12, 2021 at 06:22:20AM -0800, Dan Williams wrote: > > - * Use the 'no check' versions of copy_from_iter_flushcache() and > > - * copy_mc_to_iter() to bypass HARDENED_USERCOPY overhead. Bounds > > + * Use the 'no check' versions of _copy_from_iter_flushcache() and > > + *

Re: [PATCH 4/5] dax: remove the copy_from_iter and copy_to_iter methods

On Sun, Dec 12, 2021 at 06:39:16AM -0800, Dan Williams wrote: > > /* flag to check if device supports synchronous flush */ > > DAXDEV_SYNC, > > + /* do not use uncached operations to write data */ > > + DAXDEV_CACHED, > > + /* do not use mcsafe operations to read

Re: [PATCH 4/5] dax: remove the copy_from_iter and copy_to_iter methods

On Sun, Dec 12, 2021 at 06:44:26AM -0800, Dan Williams wrote: > On Fri, Dec 10, 2021 at 6:17 AM Vivek Goyal wrote: > > Going forward, I am wondering should virtiofs use flushcache version as > > well. What if host filesystem is using DAX and mapping persistent memory > > pfn directly into qemu

Re: [PATCH 5/5] dax: always use _copy_mc_to_iter in dax_copy_to_iter

On Sun, Dec 12, 2021 at 06:48:05AM -0800, Dan Williams wrote: > On Fri, Dec 10, 2021 at 6:05 AM Vivek Goyal wrote: > > > > On Thu, Dec 09, 2021 at 07:38:28AM +0100, Christoph Hellwig wrote: > > > While using the MC-safe copy routines is rather pointless on a virtual > > > device > > > like