Re: [dm-devel] [PATCH v2 03/10] block: Add copy offload support infrastructure

2022-02-08 Thread Dan Carpenter
Hi Nitesh, url: https://github.com/0day-ci/linux/commits/Nitesh-Shetty/block-make-bio_map_kern-non-static/20220207-231407 base: https://git.kernel.org/pub/scm/linux/kernel/git/axboe/linux-block.git for-next config: i386-randconfig-m021-20220207

Re: [dm-devel] [PATCH v2 04/10] block: Introduce a new ioctl for copy

2022-02-08 Thread kernel test robot
Hi Nitesh, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on axboe-block/for-next] [also build test WARNING on next-20220208] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base

Re: [dm-devel] [PATCH v2 05/10] block: add emulation for copy

2022-02-08 Thread kernel test robot
://download.01.org/0day-ci/archive/20220208/202202081132.axckivgv-...@intel.com/config) compiler: nios2-linux-gcc (GCC) 11.2.0 reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross

Re: [dm-devel] Can not remove device. No files open, no processes attached. Forced to reboot server.

2022-02-08 Thread Roger Heflin
On Mon, Feb 7, 2022 at 3:35 AM Aidan Walton wrote: > > Hi, > I've been chasing a problem now for a few weeks. I have a flaky SATA > controller that fails unpredictably and upon doing so all drives > attached are disconnected by the kernel. I have 2 discs on this > controller which are the

Re: [dm-devel] [PATCH v2 07/10] nvmet: add copy command support for bdev and file ns

2022-02-08 Thread kernel test robot
-block.git for-next config: arm64-randconfig-r031-20220207 (https://download.01.org/0day-ci/archive/20220208/202202080346.u4ubccis-...@intel.com/config) compiler: clang version 15.0.0 (https://github.com/llvm/llvm-project 0d8850ae2cae85d49bea6ae0799fa41c7202c05c) reproduce (this is a W=1 build

Re: [dm-devel] [PATCH v2 03/10] block: Add copy offload support infrastructure

2022-02-08 Thread kernel test robot
://download.01.org/0day-ci/archive/20220208/202202080650.48c9ps00-...@intel.com/config) compiler: nios2-linux-gcc (GCC) 11.2.0 reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross

Re: [dm-devel] [PATCH] kpartx.rules: skip MD devices

2022-02-08 Thread Benjamin Marzinski
On Mon, Feb 07, 2022 at 06:18:19PM +0100, mwi...@suse.com wrote: > From: Martin Wilck > > With the mdadm metadata format v1.0 (and DDF), the MD superblock is at the end > of the device, keeping the partition table at the beginning. This may cause > wrong partition mappings to be created by

Re: [dm-devel] [PATCH v2 03/10] block: Add copy offload support infrastructure

2022-02-08 Thread kernel test robot
(https://download.01.org/0day-ci/archive/20220208/202202080735.lyaee5bq-...@intel.com/config) compiler: clang version 15.0.0 (https://github.com/llvm/llvm-project 0d8850ae2cae85d49bea6ae0799fa41c7202c05c) reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests

Re: [dm-devel] [PATCH v2 5/6] multipath: Makefile: modules-load.d file for SCSI device handlers

2022-02-08 Thread Benjamin Marzinski
On Fri, Feb 04, 2022 at 08:30:36AM +0100, mwi...@suse.com wrote: > From: Martin Wilck > > The kernel's autoload mechanism for SCSI device handlers doesn't > work during SCSI device probing. While it's possible to load and > attach device handlers after probing, it has disadvantages: the >

[dm-devel] [PATCH v2 02/10] block: Introduce queue limits for copy-offload support

2022-02-08 Thread Nitesh Shetty
Add device limits as sysfs entries, - copy_offload (READ_WRITE) - max_copy_sectors (READ_ONLY) - max_copy_ranges_sectors (READ_ONLY) - max_copy_nr_ranges (READ_ONLY) copy_offload(= 0), is disabled by default. This needs to be enabled if copy-offload needs to be

Re: [dm-devel] [PATCH v2 07/10] nvmet: add copy command support for bdev and file ns

2022-02-08 Thread kernel test robot
-block.git for-next config: microblaze-buildonly-randconfig-r003-20220207 (https://download.01.org/0day-ci/archive/20220208/202202080206.j6kilcey-...@intel.com/config) compiler: microblaze-linux-gcc (GCC) 11.2.0 reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel

[dm-devel] [PATCH v2 03/10] block: Add copy offload support infrastructure

2022-02-08 Thread Nitesh Shetty
Introduce blkdev_issue_copy which supports source and destination bdevs, and a array of (source, destination and copy length) tuples. Introduce REQ_COP copy offload operation flag. Create a read-write bio pair with a token as payload and submitted to the device in order. the read request populates

[dm-devel] [PATCH v2 09/10] dm: Enable copy offload for dm-linear target

2022-02-08 Thread Nitesh Shetty
Setting copy_supported flag to enable offload. Signed-off-by: Nitesh Shetty --- drivers/md/dm-linear.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/md/dm-linear.c b/drivers/md/dm-linear.c index 1b97a11d7151..8910728bc8df 100644 --- a/drivers/md/dm-linear.c +++

[dm-devel] [PATCH v2 00/10] Add Copy offload support

2022-02-08 Thread Nitesh Shetty
The patch series covers the points discussed in November 2021 virtual call [LSF/MM/BFP TOPIC] Storage: Copy Offload[0]. We have covered the Initial agreed requirements in this patchset. Patchset borrows Mikulas's token based approach for 2 bdev implementation. This is on top of our previous

[dm-devel] [PATCH v2 01/10] block: make bio_map_kern() non static

2022-02-08 Thread Nitesh Shetty
From: SelvaKumar S Make bio_map_kern() non static Signed-off-by: SelvaKumar S Signed-off-by: Nitesh Shetty --- block/blk-map.c| 2 +- include/linux/blkdev.h | 2 ++ 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/block/blk-map.c b/block/blk-map.c index

Re: [dm-devel] Can not remove device. No files open, no processes attached. Forced to reboot server.

2022-02-08 Thread Zdenek Kabelac
Dne 06. 02. 22 v 16:16 Aidan Walton napsal(a): Hi, I've been chasing a problem now for a few weeks. I have a flaky SATA controller that fails unpredictably and upon doing so all drives attached are disconnected by the kernel. I have 2 discs on this controller which are the components of a RAID1

[dm-devel] [PATCH v2 08/10] dm: Add support for copy offload.

2022-02-08 Thread Nitesh Shetty
Before enabling copy for dm target, check if underlaying devices and dm target support copy. Avoid split happening inside dm target. Fail early if the request needs split, currently spliting copy request is not supported Signed-off-by: Nitesh Shetty --- drivers/md/dm-table.c | 43

[dm-devel] [PATCH v2 06/10] nvme: add copy support

2022-02-08 Thread Nitesh Shetty
From: SelvaKumar S Add support for Copy command For device supporting native copy, nvme driver receives read and write request with BLK_COPY op flags. For read request the nvme driver populates the payload with source information. For write request the driver converts it to nvme copy command

[dm-devel] [PATCH v2 05/10] block: add emulation for copy

2022-02-08 Thread Nitesh Shetty
For the devices which does not support copy, copy emulation is added. Copy-emulation is implemented by reading from source ranges into memory and writing to the corresponding destination synchronously. TODO: Optimise emulation. Signed-off-by: Nitesh Shetty --- block/blk-lib.c | 119

[dm-devel] [PATCH v2 07/10] nvmet: add copy command support for bdev and file ns

2022-02-08 Thread Nitesh Shetty
From: Arnav Dawn Add support for handling target command on target. For bdev-ns we call into blkdev_issue_copy, which the block layer completes by a offloaded copy request to backend bdev or by emulating the request. For file-ns we call vfs_copy_file_range to service our request. Currently

[dm-devel] [PATCH v2 04/10] block: Introduce a new ioctl for copy

2022-02-08 Thread Nitesh Shetty
Add new BLKCOPY ioctl that offloads copying of one or more sources ranges to one or more destination in a device. COPY ioctl accepts a 'copy_range' structure that contains no of range, a reserved field , followed by an array of ranges. Each source range is represented by 'range_entry' that

[dm-devel] [PATCH v2 10/10] dm kcopyd: use copy offload support

2022-02-08 Thread Nitesh Shetty
From: SelvaKumar S Introduce copy_jobs to use copy-offload, if supported by underlying devices otherwise fall back to existing method. run_copy_jobs() calls block layer copy offload API, if both source and destination request queue are same and support copy offload. On successful completion,

Re: [dm-devel] Thin pool performance when allocating lots of blocks

2022-02-08 Thread Zdenek Kabelac
Dne 08. 02. 22 v 22:02 Demi Marie Obenour napsal(a): On 2/8/22 15:37, Zdenek Kabelac wrote: Dne 08. 02. 22 v 20:00 Demi Marie Obenour napsal(a): Are thin volumes (which start as snapshots of a blank volume) efficient for building virtual machine images? Given the nature of this workload

Re: [dm-devel] Thin pool performance when allocating lots of blocks

2022-02-08 Thread Zdenek Kabelac
Dne 08. 02. 22 v 20:00 Demi Marie Obenour napsal(a): Are thin volumes (which start as snapshots of a blank volume) efficient for building virtual machine images? Given the nature of this workload (writing to lots of new, possibly-small files, then copying data from them to a huge disk image), I

Re: [dm-devel] [LSF/MM/BFP ATTEND] [LSF/MM/BFP TOPIC] Storage: Copy Offload

2022-02-08 Thread Nitesh Shetty
Chaitanya, I would like to join the conversation. Thanks, Nitesh On Sun, Feb 6, 2022 at 7:29 PM Javier González wrote: > > On 27.01.2022 07:14, Chaitanya Kulkarni wrote: > >Hi, > > > >* Background :- > >--- > > > >Copy offload

Re: [dm-devel] [LSF/MM/BFP ATTEND] [LSF/MM/BFP TOPIC] Storage: Copy Offload

2022-02-08 Thread David Disseldorp
On Thu, 27 Jan 2022 07:14:13 +, Chaitanya Kulkarni wrote: > Hi, > > * Background :- > --- > > Copy offload is a feature that allows file-systems or storage devices > to be instructed to copy files/logical blocks without

Re: [dm-devel] [PATCH] libmultipath: hwtable: use ALUA for all LIO targets

2022-02-08 Thread Benjamin Marzinski
On Wed, Feb 02, 2022 at 12:50:25PM +0100, mwi...@suse.com wrote: > From: Martin Wilck > > LIO supports ALUA for all backends. Use it by default. > > Signed-off-by: Martin Wilck Reviewed-by: Benjamin Marzinski > --- > libmultipath/hwtable.c | 2 +- > 1 file changed, 1 insertion(+), 1