Re: [dm-devel] [PATCH v3] virtio_blk: add VIRTIO_BLK_F_LIFETIME feature support

2022-12-06 Thread Chaitanya Kulkarni
Bart, On 12/6/22 10:43, Bart Van Assche wrote: > On 12/5/22 08:20, Alvaro Karsz wrote: >> +/* Get lifetime information struct for each request */ >> +struct virtio_blk_lifetime { >> +    /* >> + * specifies the percentage of reserved blocks that are consumed. >> + * optional values

Re: [dm-devel] [RFC] block: Change the granularity of io ticks from ms to ns

2022-12-06 Thread Ming Lei
On Wed, Dec 07, 2022 at 10:19:08AM +0800, Yu Kuai wrote: > Hi, > > 在 2022/12/07 2:15, Gulam Mohamed 写道: > > Use ktime to change the granularity of IO accounting in block layer from > > milli-seconds to nano-seconds to get the proper latency values for the > > devices whose latency is in

Re: [RFC] block: Change the granularity of io ticks from ms to ns

2022-12-06 Thread Yu Kuai
Hi, 在 2022/12/07 2:15, Gulam Mohamed 写道: Use ktime to change the granularity of IO accounting in block layer from milli-seconds to nano-seconds to get the proper latency values for the devices whose latency is in micro-seconds. After changing the granularity to nano-seconds the iostat command,

Re: [dm-devel] [PATCH v2] libmultipath: is_path_valid(): check if device is in use

2022-12-06 Thread Benjamin Marzinski
On Sat, Dec 03, 2022 at 12:43:38AM +0100, mwi...@suse.com wrote: > From: Martin Wilck > > To check whether we will be able to add a given device can be part > of a multipath map, we have two tests in check_path_valid(): > released_to_systemd() and the O_EXCL test. The former isn't helpful > if

Re: [RFC] block: Change the granularity of io ticks from ms to ns

2022-12-06 Thread Paul Menzel
Dear Gulam, Thank you for the patch. Am 06.12.22 um 19:15 schrieb Gulam Mohamed: Use ktime to change the granularity of IO accounting in block layer from milli-seconds to nano-seconds to get the proper latency values for the devices whose latency is in micro-seconds. After changing the

Re: [dm-devel] [PATCH] block: remove bio_set_op_attrs

2022-12-06 Thread Bart Van Assche
On 12/6/22 06:40, Christoph Hellwig wrote: This macro is obsolete, so replace the last few uses with open coded bi_opf assignments. For the entire patch: Reviewed-by: Bart Van Assche -- dm-devel mailing list dm-devel@redhat.com https://listman.redhat.com/mailman/listinfo/dm-devel

Re: [dm-devel] [PATCH v3] virtio_blk: add VIRTIO_BLK_F_LIFETIME feature support

2022-12-06 Thread Bart Van Assche
On 12/5/22 08:20, Alvaro Karsz wrote: +/* Get lifetime information struct for each request */ +struct virtio_blk_lifetime { + /* +* specifies the percentage of reserved blocks that are consumed. +* optional values following virtio spec: +* 0 - undefined +* 1

[RFC] block: Change the granularity of io ticks from ms to ns

2022-12-06 Thread Gulam Mohamed
Use ktime to change the granularity of IO accounting in block layer from milli-seconds to nano-seconds to get the proper latency values for the devices whose latency is in micro-seconds. After changing the granularity to nano-seconds the iostat command, which was showing incorrect values for

[dm-devel] [PATCH] block: remove bio_set_op_attrs

2022-12-06 Thread Christoph Hellwig
This macro is obsolete, so replace the last few uses with open coded bi_opf assignments. Signed-off-by: Christoph Hellwig --- drivers/md/bcache/movinggc.c | 2 +- drivers/md/bcache/request.c | 2 +- drivers/md/bcache/writeback.c | 4 ++-- drivers/md/dm-thin.c | 2 +-

Re: [dm-devel] [PATCH] block: remove bio_set_op_attrs

2022-12-06 Thread Coly Li
> 2022年12月6日 22:40,Christoph Hellwig 写道: > > This macro is obsolete, so replace the last few uses with open coded > bi_opf assignments. > > Signed-off-by: Christoph Hellwig Acked-by: Coly Li mailto:col...@suse.de>> BTW, may I ask why bio_set_op_attrs() is removed. Quite long time ago it

Re: [dm-devel] [PATCH] block: remove bio_set_op_attrs

2022-12-06 Thread Coly Li
> 2022年12月6日 22:49,Christoph Hellwig 写道: > > On Tue, Dec 06, 2022 at 10:46:31PM +0800, Coly Li wrote: >> BTW, may I ask why bio_set_op_attrs() is removed. Quite long time ago it was >> added to avoid open code, and now we remove it to use open coded >> assignments. What is the motivation for

Re: [dm-devel] [PATCH] block: remove bio_set_op_attrs

2022-12-06 Thread Christoph Hellwig
On Tue, Dec 06, 2022 at 10:46:31PM +0800, Coly Li wrote: > BTW, may I ask why bio_set_op_attrs() is removed. Quite long time ago it was > added to avoid open code, and now we remove it to use open coded assignments. > What is the motivation for now? It was added when the flags encoding was a