[dm-devel] [PATCH 1/1] dm: remove unnecessary (void*) conversions

2023-02-16 Thread XU pengfei
Pointer variables of void * type do not require type cast. Signed-off-by: XU pengfei --- drivers/md/dm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/md/dm.c b/drivers/md/dm.c index b424a6ee27ba..669f2821376a 100644 --- a/drivers/md/dm.c +++ b/drivers/md/dm.c @@

Re: [dm-devel] On allowing remounting the partition containing dm-mapped boot disk as read-write

2023-02-16 Thread Ganapathi Kamath
Firstly, thankyou for your reply, However, I still think you are mistaken. "There is no double re-mounting of the filesystem". I try again, but in case my writing isn't convincing. Let's agree to disagree, until I have more conclusive proof, either to what confirm what you say, or what I say.  

Re: [dm-devel] [v2 PATCH 0/5] Introduce mempool pages bulk allocator and use it in dm-crypt

2023-02-16 Thread Yang Shi
On Thu, Feb 16, 2023 at 9:45 AM Mikulas Patocka wrote: > > > > On Wed, 15 Feb 2023, Yang Shi wrote: > > > On Wed, Feb 15, 2023 at 4:23 AM Mikulas Patocka wrote: > > > > > > > > > > > > On Tue, 14 Feb 2023, Yang Shi wrote: > > > > > > > > > > > Changelog: > > > > RFC -> v2: > > > > * Added

Re: [dm-devel] A hang bug of dm on s390x

2023-02-16 Thread Pingfan Liu
Hi Ming, Thank you for looking into this. let me loop in Alasdair, Mike and Zdenek for further comment on LVM stuff Thanks, Pingfan On Thu, Feb 16, 2023 at 8:08 AM Ming Lei wrote: > > On Wed, Feb 15, 2023 at 07:23:40PM +0800, Pingfan Liu wrote: > > Hi guys, > > > > I encountered a hang

Re: [dm-devel] blk-mq: enforce op-specific segment limits in blk_insert_cloned_request

2023-02-16 Thread Mike Snitzer
On Thu, Feb 16 2023 at 2:27P -0500, Uday Shankar wrote: > On Wed, Feb 15, 2023 at 10:09:36PM -0800, Christoph Hellwig wrote: > > I'd just remove the debug check entirely > > Older kernels have these checks in a separate function called > blk_cloned_rq_check_limits, which carries the following

[dm-devel] [PATCH v2] dm-crypt: allocate compound pages if possible

2023-02-16 Thread Mikulas Patocka
It was reported that allocating pages for the write buffer in dm-crypt causes measurable overhead [1]. This patch changes dm-crypt to allocate compound pages if they are available. If not, we fall back to the mempool. [1] https://listman.redhat.com/archives/dm-devel/2023-February/053284.html

Re: [dm-devel] [PATCH] dm-crypt: allocate compound pages if possible

2023-02-16 Thread Mikulas Patocka
On Thu, 16 Feb 2023, Matthew Wilcox wrote: > > - len = (remaining_size > PAGE_SIZE) ? PAGE_SIZE : remaining_size; > > - > > - bio_add_page(clone, page, len, 0); > > +have_pages: > > + page->compound_order = order; > > No. You'll corrupt the next page if page is

Re: [dm-devel] [PATCH] blk-mq: enforce op-specific segment limits in blk_insert_cloned_request

2023-02-16 Thread Uday Shankar
On Wed, Feb 15, 2023 at 10:09:36PM -0800, Christoph Hellwig wrote: > I'd just remove the debug check entirely Older kernels have these checks in a separate function called blk_cloned_rq_check_limits, which carries the following comment: /** * blk_cloned_rq_check_limits - Helper function to

Re: [dm-devel] [PATCH] dm-crypt: allocate compound pages if possible

2023-02-16 Thread Matthew Wilcox
On Thu, Feb 16, 2023 at 12:47:08PM -0500, Mikulas Patocka wrote: > + while (order > 0) { > + page = alloc_pages(gfp_mask > + | __GFP_NOMEMALLOC | __GFP_NORETRY | > __GFP_NOWARN, order); ... | __GFP_COMP > page =

[dm-devel] [PATCH] dm-crypt: allocate compound pages if possible

2023-02-16 Thread Mikulas Patocka
It was reported that allocating pages for the write buffer in dm-crypt causes measurable overhead [1]. This patch changes dm-crypt to allocate compound pages if they are available. If not, we fall back to the mempool. [1] https://listman.redhat.com/archives/dm-devel/2023-February/053284.html

Re: [dm-devel] [v2 PATCH 0/5] Introduce mempool pages bulk allocator and use it in dm-crypt

2023-02-16 Thread Mikulas Patocka
On Wed, 15 Feb 2023, Yang Shi wrote: > On Wed, Feb 15, 2023 at 4:23 AM Mikulas Patocka wrote: > > > > > > > > On Tue, 14 Feb 2023, Yang Shi wrote: > > > > > > > > Changelog: > > > RFC -> v2: > > > * Added callback variant for page bulk allocator and mempool bulk > > > allocator > > >

Re: [dm-devel] A hang bug of dm on s390x

2023-02-16 Thread Mike Snitzer
[Top-posting but please don't...] I've staged this fix for 6.3 inclusion and marked it for stable@: https://git.kernel.org/pub/scm/linux/kernel/git/device-mapper/linux-dm.git/commit/?h=dm-6.3=0ca44fcef241768fd25ee763b3d203b9852f269b Ming, I also staged this similar fix (not reasoned through

Re: [dm-devel] [PATCH] blk-mq: enforce op-specific segment limits in blk_insert_cloned_request

2023-02-16 Thread kernel test robot
Hi Uday, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on 6bea9ac7c6481c09eb2b61d7cd844fc64a526e3e] url: https://github.com/intel-lab-lkp/linux/commits/Uday-Shankar/blk-mq-enforce-op-specific-segment-limits-in-blk_insert_cloned_request/20230216-041718 base

Re: [dm-devel] A hang bug of dm on s390x

2023-02-16 Thread Zdenek Kabelac
Dne 16. 02. 23 v 9:30 Pingfan Liu napsal(a): Hi Ming, Thank you for looking into this. let me loop in Alasdair, Mike and Zdenek for further comment on LVM stuff Thanks, Pingfan Hi From lvm2 POV - couple clarifications - to let thin-pool auto-extend - user has to configure:

Re: [dm-devel] On allowing remounting the partition containing dm-mapped boot disk as read-write

2023-02-16 Thread Roger Heflin
Besides caching at the dm layer, there is caching at the filesystem layer (files, directories and other stuff). The caching at the DM layer is not the issue. If rootfs mounts the dm-device someplace as a (ntfs)filesystem(readonly), and then later you also mount that same (ntfs)filesystem

Re: [dm-devel] On allowing remounting the partition containing dm-mapped boot disk as read-write

2023-02-16 Thread Ganapathi Kamath
Firstly, thankyou for your reply. I'm not a kernel expert, so I value what you say. but as I raised the issue I felt I had to defend the usefulness, userbase and the need. > Typically double mounts are done via bind mounts (not really double > mounted just the device showing someplace else).  

[dm-devel] A hang bug of dm on s390x

2023-02-16 Thread Pingfan Liu
Hi guys, I encountered a hang issue on a s390x system. The tested kernel is not preemptible and booting with "nr_cpus=1" The test steps: umount /home lvremove /dev/rhel_s390x-kvm-011/home ## uncomment "snapshot_autoextend_threshold = 70" and "snapshot_autoextend_percent

Re: [dm-devel] [v2 PATCH 0/5] Introduce mempool pages bulk allocator and use it in dm-crypt

2023-02-16 Thread Yang Shi
On Wed, Feb 15, 2023 at 4:23 AM Mikulas Patocka wrote: > > > > On Tue, 14 Feb 2023, Yang Shi wrote: > > > > > Changelog: > > RFC -> v2: > > * Added callback variant for page bulk allocator and mempool bulk > > allocator > > per Mel Gorman. > > * Used the callback version in dm-crypt

Re: [dm-devel] RAID4 with no striping mode request

2023-02-16 Thread Kyle Sanderson
> On Wed, Feb 15, 2023 at 3:44 AM Roger Heflin wrote: > > I think he is wanting the parity across the data blocks on the > separate filesystems (some sort of parity across fs[1-8]/block0 to > parity/block0). Correct. > On Wed, Feb 15, 2023 at 3:44 AM Roger Heflin wrote: > it is not clear to me