Re: [dm-devel] [PATCH -next v3 00/25] md: synchronize io with array reconfiguration

2023-10-06 Thread Yu Kuai
Hi, 在 2023/10/07 10:40, Song Liu 写道: Can you take a look about this new cover letter? I don't have time right now to look into all the details, but it looks great at first glance. We can still edit it a little bit when applying the patchset, but that may not be necessary. Yeah, it's not

Re: [dm-devel] [PATCH -next v3 00/25] md: synchronize io with array reconfiguration

2023-10-06 Thread Song Liu
On Fri, Oct 6, 2023 at 7:32 PM Yu Kuai wrote: > > Hi, > > 在 2023/10/05 11:55, Song Liu 写道: > > On Wed, Oct 4, 2023 at 8:42 PM Yu Kuai wrote: > >> > >> Hi, > >> > >> 在 2023/09/29 3:15, Song Liu 写道: > >>> Hi Kuai, > >>> > >>> Thanks for the patchset! > >>> > >>> A few high level

Re: [dm-devel] [PATCH -next v3 00/25] md: synchronize io with array reconfiguration

2023-10-06 Thread Yu Kuai
Hi, 在 2023/10/05 11:55, Song Liu 写道: On Wed, Oct 4, 2023 at 8:42 PM Yu Kuai wrote: Hi, 在 2023/09/29 3:15, Song Liu 写道: Hi Kuai, Thanks for the patchset! A few high level questions/suggestions: Thanks a lot for these! 1. This is a big change that needs a lot of explanation. While you

[dm-devel] [PATCH v8 2/5] block: Introduce provisioning primitives

2023-10-06 Thread Sarthak Kukreti
Introduce block request REQ_OP_PROVISION. The intent of this request is to request underlying storage to preallocate disk space for the given block range. Block devices that support this capability will export a provision limit within their request queues. This patch also adds the capability to

[dm-devel] [PATCH RFC] dm thin: Add support for online trim to dm-thinpool

2023-10-06 Thread Sarthak Kukreti
Currently, dm-thinpool only supports offline trim: there is a userspace tool called `thin_trim` (part of `thin-provisioning-tools`), that will look up all the unmapped regions within the thinpool and issue discards to these regions. However, this can take up a lot of time, specially on larger

Re: [dm-devel] [PATCH v7 0/5] Introduce provisioning primitives

2023-10-06 Thread Sarthak Kukreti
On Fri, Jun 9, 2023 at 1:31 PM Mike Snitzer wrote: > > On Wed, Jun 07 2023 at 7:27P -0400, > Mike Snitzer wrote: > > > On Mon, Jun 05 2023 at 5:14P -0400, > > Sarthak Kukreti wrote: > > > > > On Sat, Jun 3, 2023 at 8:57 AM Mike Snitzer wrote: > > > > > > > > We all just need to focus on your

Re: [dm-devel] [PATCH v7 5/5] loop: Add support for provision requests

2023-10-06 Thread Sarthak Kukreti
On Mon, May 22, 2023 at 6:22 PM Darrick J. Wong wrote: > > On Mon, May 22, 2023 at 03:09:55PM -0700, Sarthak Kukreti wrote: > > On Mon, May 22, 2023 at 9:37 AM Darrick J. Wong wrote: > > > > > > If someone calls fallocate(UNSHARE_RANGE) on a loop bdev, shouldn't > > > there be a way to pass that

[dm-devel] [PATCH v8 5/5] block: Pass unshare intent via REQ_OP_PROVISION

2023-10-06 Thread Sarthak Kukreti
Allow REQ_OP_PROVISION to pass in an extra REQ_UNSHARE bit to annotate unshare requests to underlying layers. Layers that support FALLOC_FL_UNSHARE will be able to use this as an indicator of which fallocate() mode to use. Suggested-by: Darrick J. Wong Signed-off-by: Sarthak Kukreti ---

[dm-devel] [PATCH v8 1/5] block: Don't invalidate pagecache for invalid falloc modes

2023-10-06 Thread Sarthak Kukreti
Only call truncate_bdev_range() if the fallocate mode is supported. This fixes a bug where data in the pagecache could be invalidated if the fallocate() was called on the block device with an invalid mode. Fixes: 25f4c41415e5 ("block: implement (some of) fallocate for block devices") Cc:

[dm-devel] [PATCH v8 4/5] dm: Add block provisioning support

2023-10-06 Thread Sarthak Kukreti
Add block provisioning support for device-mapper targets. dm-crypt and dm-linear will, by default, passthrough REQ_OP_PROVISION requests to the underlying device, if supported. Signed-off-by: Sarthak Kukreti Signed-off-by: Mike Snitzer --- drivers/md/dm-crypt.c | 4 +++-

[dm-devel] [PATCH v8 3/5] loop: Add support for provision requests

2023-10-06 Thread Sarthak Kukreti
Add support for provision requests to loopback devices. Loop devices will configure provision support based on whether the underlying block device/file can support the provision request and upon receiving a provision bio, will map it to the backing device/storage. For loop devices over files, a

[dm-devel] [PATCH v8 0/5] Introduce provisioning primitives

2023-10-06 Thread Sarthak Kukreti
Hi, This patch series is version 8 of the patch series to introduce block-level provisioning mechanism (original [1]), which is useful for provisioning space across thinly provisioned storage architectures (loop devices backed by sparse files, dm-thin devices, virtio-blk). This series has

[dm-devel] [git pull] device mapper fixes for 6.6-rc5

2023-10-06 Thread Mike Snitzer
Hi Linus, The following changes since commit ce9ecca0238b140b88f43859b211c9fdfd8e5b70: Linux 6.6-rc2 (2023-09-17 14:40:24 -0700) are available in the Git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/device-mapper/linux-dm.git tags/for-6.6/dm-fixes-2 for you to fetch

Re: [dm-devel] dm crypt: Fix reqsize in crypt_iv_eboiv_gen

2023-10-06 Thread Linux regression tracking (Thorsten Leemhuis)
On 06.10.23 04:33, Herbert Xu wrote: > On Thu, Oct 05, 2023 at 10:26:14PM -0400, Mike Snitzer wrote: BTW, Herbert, thx for taking care of this quickly! >> Sure, please do. Shouldn't your header Cc: stable given that the >> Fixes commit implies v6.5 needs this fix? > > Sure I'll add it although

Re: [dm-devel] [PATCH] dm crypt: Fix reqsize in crypt_iv_eboiv_gen

2023-10-06 Thread Tatu Heikkilä
On Fri, Oct 06, 2023 at 09:41:55 +0800, Herbert Xu wrote: On Fri, Oct 06, 2023 at 08:04:18AM +0700, Bagas Sanjaya wrote: > > > Git bisect lead me to: > > # first bad commit: [e3023094dffb41540330fb0c74cd3a019cd525c2] dm crypt: > > Avoid using MAX_CIPHER_BLOCKSIZE > > > > If I git revert

[dm-devel] (Bisected) Accessing opened Bitlocker partition leads to memory fault and kernel panic on Imac8, 1

2023-10-06 Thread Tatu Heikkilä
Hello, I think you and the lists are right recipients, forgive me if not, I've never reported kernel bugs before. Naively this seems a crypto issue and Herbert Xu from crypto maintainers made the buggy commit, but it edits drivers/md/dm_crypt.c maintained by dm-devel people per MAINTAINERS, so I'm

Re: [dm-devel] (Bisected) Accessing opened Bitlocker partition leads to memory fault and kernel panic on Imac8, 1

2023-10-06 Thread Bagas Sanjaya
On Thu, Oct 05, 2023 at 08:15:43PM +0300, Tatu Heikkilä wrote: > Hello, > I think you and the lists are right recipients, forgive me if not, I've > never reported kernel bugs before. Naively this seems a crypto issue and > Herbert Xu from crypto maintainers made the buggy commit, but it edits >

[dm-devel] (Bisected) Accessing opened Bitlocker partition leads to memory fault and kernel panic on Imac8, 1

2023-10-06 Thread Tatu Heikkilä
Hello, I think you and the lists are right recipients, forgive me if not, I've never reported kernel bugs before. Naively this seems a crypto issue and Herbert Xu from crypto maintainers made the buggy commit, but it edits drivers/md/dm_crypt.c maintained by dm-devel people per MAINTAINERS, so