Re: [dm-devel] [PATCH 0/2] multipathd: Add 'sysfs' prioritizer

On Fri, Jun 03, 2016 at 10:34:20AM +0200, Hannes Reinecke wrote: > Hi all, > > hardly necessary to send an entire patchset, but there you go. > I've now modified the sysfs prioritizer to generate the same > priority the alua one would do, including the 'exclusive_pref_bit' > setting. > So this

Re: [dm-devel] [PATCH] multipathd: update defaults

On Fri, Jun 03, 2016 at 09:14:32AM +0200, Hannes Reinecke wrote: > For years I've been telling our customers to use the 'tur' checker > as the current default 'directio' will cause spurious path failures > under high load. > > And for several versions (years, even) the linux kernel has the

[dm-devel] [PATCH 4/7] kpartx.rules: respect skip_kpartx flag

Check if DM_SUBSYSTEM_UDEV_FLAG1 is set, and if so, don't run kpartx. If the event was not generated by device-mapper, just use the existing value of DM_SUBSYSTEM_UDEV_FLAG1. Signed-off-by: Benjamin Marzinski <bmarz...@redhat.com> --- kpartx/kpartx.rules | 2 ++ 1 file changed, 2 inse

[dm-devel] [PATCH 3/7] libmultipath: add skip_kpartx option

the remove, and if not, sets the DM_SUBSYSTEM_UDEV_FLAG1 on the resume after failure, so that no partitions will be generated. Signed-off-by: Benjamin Marzinski <bmarz...@redhat.com> --- libmultipath/config.c | 2 ++ libmultipath/config.h | 3 +++ libmultipath/co

[dm-devel] [PATCH 0/7] multpath patch sync

This series is a resend of my previous "handler fixes" patch, along with some bug fixes, a new default configuration, and a new attempt to make multipath able to skip kpartx handling on devices. Benjamin Marzinski (7): multipathd: handler fixes libmultipath: remove calls to dm_ude

[dm-devel] [PATCH 6/7] libmultipath: add Huawei Storage default config

Add a default device config for the Huawei XSG1 arrary. This config comes from Huawei. Signed-off-by: Benjamin Marzinski <bmarz...@redhat.com> --- libmultipath/hwtable.c | 9 + 1 file changed, 9 insertions(+) diff --git a/libmultipath/hwtable.c b/libmultipath/hwtable.c index 8

[dm-devel] [PATCH 5/7] multipath: validate devmap names

are not allowed to have a "/" in them, multipath now checks the identifier for this before assuming that is is a device alias, and if there is a "/", it errors out with a helpful message. Signed-off-by: Benjamin Marzinski <bmarz...@redhat.com> --- libmultipath/alias.c

Re: [dm-devel] [LSF/MM ATTEND] multipath redesign and dm blk-mq issues

On Fri, Jan 29, 2016 at 07:59:09AM +0100, Hannes Reinecke wrote: > On 01/28/2016 10:23 PM, Benjamin Marzinski wrote: > > I'd like to attend LSF/MM 2016 to participate in any discussions about > > redesigning how device-mapper multipath operates. I spend a significant > >

Re: [dm-devel] [PATCH]multipath-tools: prevent unnecessary reinstate of stand-by paths with implicit tpgs mode and no active array paths.

On Sat, Feb 20, 2016 at 08:23:29PM +, Shiva Krishna wrote: I understand your problem, but this isn't the right patch to fix it. For one this check + if (newstate != PATH_GHOST || pp->mpp->nr_active > 0 || + pp->tpgs != TPGS_IMPLICIT) { is pretty problematic.

Re: [dm-devel] [PATCH]multipath-tools: prevent unnecessary reinstate of stand-by paths with implicit tpgs mode and no active array paths.

On Fri, Feb 26, 2016 at 12:32:51AM +, Shiva Krishna wrote: > > > On 2/25/16, 12:49 PM, "Benjamin Marzinski" <bmarz...@redhat.com> wrote: > > >On Sat, Feb 20, 2016 at 08:23:29PM +, Shiva Krishna wrote: > > > >I understand your problem, but th

Re: [dm-devel] [PATCH V2]multipath-tools: prevent unnecessary reinstate of stand-by paths with implicit tpgs mode and no active array paths

On Fri, Feb 26, 2016 at 02:25:08AM +, Shiva Krishna wrote: > --- > libmultipath/propsel.c |2 +- > libmultipath/structs.h |1 + > multipathd/main.c | 19 --- > 3 files changed, 18 insertions(+), 4 deletions(-) > > diff --git a/libmultipath/propsel.c

Re: [dm-devel] dm-multipath low performance with blk-mq

On Mon, Jan 25, 2016 at 04:40:16PM -0500, Mike Snitzer wrote: > On Tue, Jan 19 2016 at 5:45P -0500, > Mike Snitzer wrote: > > > On Mon, Jan 18 2016 at 7:04am -0500, > > Sagi Grimberg wrote: > > Would still appreciate answers to my 2 questions

Re: [dm-devel] dm-multipath low performance with blk-mq

On Tue, Jan 26, 2016 at 11:03:24AM -0500, Mike Snitzer wrote: > > Christoph, any chance you could rebase your 'nvme-loop.2' on v4.5-rc1? > > Or point me to a branch that is more current... Failing that, you could try using the null_blk device directly. It doesn't provide enough information for

[dm-devel] [PATCH v2 02/18] retrigger uevents to try and get the uid through udev

uld already be taken care of by the blacklists, so it would be always a good idea to recheck devices on change events. What would be ideal is if udev would let us know when it had problems or timed out when processing a uevent, so we would know if retiggering the uevent would be useful. Signed-off-by

[dm-devel] [PATCH v2 00/18] Multipath patch sync

essage and re-enable reloads as if it had received the uevent. I also added a new patch that adds a new keyword to the weightedpath prioritizer, so that you can refer to paths in a persistent way. Benjamin Marzinski (18): multipathd: use /run instead of /var/run retrigger uevents to try and get

[dm-devel] [PATCH v2 15/18] multipath: check partitions unused before removing

If kpartx partition devices are in-use, multipath will not be able to perform a non-deferred remove of the multipath device. So, before starting the remove, multipath should verify that none of the partition devices are currently in-use. Signed-off-by: Benjamin Marzinski <bmarz...@redhat.

[dm-devel] [PATCH v2 04/18] Add libmpathcmd library and use it internally

. Signed-off-by: Benjamin Marzinski <bmarz...@redhat.com> --- Makefile | 1 + Makefile.inc | 2 + libmpathcmd/Makefile | 30 +++ libmpathcmd/mpath_cmd.c | 178 +++ libmpathcmd/mpath

[dm-devel] [PATCH v2 09/18] libmultipath: check correct function for define

fixes the Makefile define. Signed-off-by: Benjamin Marzinski <bmarz...@redhat.com> --- libmultipath/Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libmultipath/Makefile b/libmultipath/Makefile index 11750c2..1ee968e 100644 --- a/libmultipath/Makefile +++ b/libmul

[dm-devel] [PATCH v2 06/18] libmultipath: fix PAD and PRINT macros

The PAD and PRINT macros are multi-line macros that aren't enclosed in braces. This means that if they are used as single line code blocks with no braces, they won't work correctly. This is currently happening with the PAD macro, but should be fixed in both. Signed-off-by: Benjamin Marzinski

Re: [dm-devel] [PATCH v2 10/18] multipathd: delay reloads during creation

On Fri, Apr 08, 2016 at 10:36:07AM +0200, Zdenek Kabelac wrote: > However now the multipathd *kills* this assumption - since the current udev > rules implementation for multipath devices targets only for the initial scan > and all subsequent RESUMES are supposed to be ignored as it's believed the

[dm-devel] [PATCH v2 12/18] kpartx: verify partition devices

it, causing all sorts of problems. This patch makes kpartx check the uuid to verify that the device it is modifying really is a partition device for the correct dm device. Signed-off-by: Benjamin Marzinski <bmarz...@redhat.com> --- kpartx/devmapper.c | 17 ++--- kpartx/devmapper.

[dm-devel] [PATCH v2 18/18] multipath: add wwn keyword to weightedpath prio

with the iscsi target name of iqn.2009-10.com.redhat.msp.lab.ask-06 (which multipath has always treated as the same as the FC Target WWNN) to a priority of 10 - and all other paths to a priority of 0 Signed-off-by: Benjamin Marzinski <bmarz...@redhat.com> --- libmultipath/print.c

[dm-devel] [PATCH v2 16/18] multipathd.service: remove blk-availability Requires

multipathd.service can start up and run just fine without blk-availability.service. It is only necessary to coordinate shutdown order in certain multipath setups (over iscsi for instance). Thus, instead of "Requires", multipathd.service should use "Wants" Signed-off-by: Benja

[dm-devel] [PATCH 11/17] multipath: Fix minor text issues

The multipath.conf man page gave the incorrect default for queue_without_daemon. The multipath usage output listed the -p option twice. And multipath was misspelled in an mpathpersist error message. This patch fixes these issues. Signed-off-by: Benjamin Marzinski <bmarz...@redhat.

[dm-devel] [PATCH 01/17] multipathd: use /run instead of /var/run

always be available before multipathd is started, so multipath should just write there directly, instead of through the symlink. If /var/run is not a symlink, continue using it. Signed-off-by: Benjamin Marzinski <bmarz...@redhat.com> --- Makefile.inc

[dm-devel] [PATCH 00/17] Multipath patch sync

of the patches are new. Please apply. Thanks. Benjamin Marzinski (17): multipathd: use /run instead of /var/run retrigger uevents to try and get the uid through udev Fix issues with user_friendly_names initramfs bindings Add libmpathcmd library and use it internally libmultipath: add

[dm-devel] [PATCH 06/17] libmultipath: fix PAD and PRINT macros

The PAD and PRINT macros are multi-line macros that aren't enclosed in braces. This means that if they are used as single line code blocks with no braces, they won't work correctly. This is currently happening with the PAD macro, but should be fixed in both. Signed-off-by: Benjamin Marzinski

[dm-devel] [PATCH 08/17] multipathd: fail if pidfile can't be created

multipathd if the create fails. Signed-off-by: Benjamin Marzinski <bmarz...@redhat.com> --- multipathd/main.c | 18 +- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/multipathd/main.c b/multipathd/main.c index 8f4fb58..06876b9 100644 --- a/multipathd/main.c +++ b/m

Re: [dm-devel] [PATCH 10/17] multipathd: delay reloads during creation

On Tue, Mar 29, 2016 at 10:02:41AM -0400, John Stoffel wrote: > >>>>> "Benjamin" == Benjamin Marzinski <bmarz...@redhat.com> writes: > > Benjamin> lvm needs PV devices to not be suspended while the udev > Benjamin> rules are running, for them to be

Re: [dm-devel] multipath-0.5.0 still provides broken udev rules

On Mon, Apr 25, 2016 at 02:56:35PM +0200, Christophe Varoqui wrote: >Hi, >Those example udev rules are indeed unmaintained and should be removed not >to confuse distributors. >Distributors can't be asked to agree on a common udev ruleset. Ben, >Hannes, Xosé, Peter are you ok

Re: [dm-devel] multipath-0.5.0 still provides broken udev rules

On Tue, Apr 26, 2016 at 07:53:48AM +0200, Hannes Reinecke wrote: > On 04/25/2016 10:14 PM, Xose Vazquez Perez wrote: > > On 04/25/2016 02:56 PM, Christophe Varoqui wrote: > > > >> Those example udev rules are indeed unmaintained and should be > >> removed not to confuse distributors. > >> > >>

Re: [dm-devel] multipath-0.5.0 still provides broken udev rules

On Thu, Apr 28, 2016 at 08:23:44AM +0200, Hannes Reinecke wrote: > On 04/28/2016 12:46 AM, Benjamin Marzinski wrote: > > Like I said, Red Hat doesn't use them. I'll post our multipath.rules > > shortly. > > > Which would be cool. > I was actually hoping to me

Re: [dm-devel] multipath-0.5.0 still provides broken udev rules

On Thu, Apr 28, 2016 at 08:23:44AM +0200, Hannes Reinecke wrote: > On 04/28/2016 12:46 AM, Benjamin Marzinski wrote: > > Aside from dropping the socket, it checks that /etc/multipath.conf > > exists, and that the kernel wasn't started with "nompath". Also it runs >

[dm-devel] [PATCH] multipathd: handler fixes

the vecs->lock when it calls pthread_mutex_timedlock, we can't call unlock() on it, because unlocking a mutex you haven't locked causes undefined behviour. So we need to only execute the handler if didn't timeout trying to acquire the lock. Signed-off-by: Benjamin Marzinski <bmarz...@redh

Re: [dm-devel] multipathd: Add 'sysfs' prioritizer

On Mon, May 23, 2016 at 12:20:28PM +0200, Hannes Reinecke wrote: > Recent kernels have an 'access_state' attribute which allows > us to read the asymmetric access state directly from sysfs. Neat. Just some thoughts. I'm not sure if you want to add a prioritizer option to be able to change what

Re: [dm-devel] multipathd: move 'filter_devnode' under vector lock

On Wed, May 11, 2016 at 12:35:41PM +0200, Hannes Reinecke wrote: > Ben Marzinski pointed out that filter_devnode() is used > without any lock or configuration settings in uev_trigger(), > and hence might be invalid when processing events during > reconfiguration. > So move it into the individual

Re: [dm-devel] [PATCH 20/57] multipathd: Do not update the paths vec when removing paths

On Wed, Apr 27, 2016 at 01:10:21PM +0200, Hannes Reinecke wrote: > When we remove a path it's totally pointless to add it to > the path list first; it'll be removed on the next step anyway. > And we should be cleaning up the comments while we're at it. This one causes problems. The easiest way to

Re: [dm-devel] [PATCH 55/57] multipathd: asynchronous configuration

On Wed, Apr 27, 2016 at 01:10:56PM +0200, Hannes Reinecke wrote: > For initial configuration multipathd waits until it has synchronized > with the existing setup. On larger systems this takes up quite > some time (I've measured 80 seconds on a system with 1024 paths) > causing systemd to stall and

Re: [dm-devel] [PATCH 55/57] multipathd: asynchronous configuration

On Wed, Apr 27, 2016 at 01:10:56PM +0200, Hannes Reinecke wrote: Oh, I did have one other thought. If you're not changing the signal mask in uevent_listen, can't you just use poll? Otherwise people are going to try and figure out what's going on with the signals that they're missing (at least

Re: [dm-devel] [PATCH 49/57] multipathd: do not flush maps on startup

On Wed, Apr 27, 2016 at 01:10:50PM +0200, Hannes Reinecke wrote: > When the daemon is started prior to udev the paths are not present > (yet). However, the maps themselves will be read from device-mapper. > This causes existing maps to be dropped in coalesce_maps(), only > to be reinstated later

Re: [dm-devel] [PATCH 56/57] multipathd: push down lock in checkerloop()

On Wed, Apr 27, 2016 at 01:10:57PM +0200, Hannes Reinecke wrote: > Instead of grabbing the lock at the start of the checkerloop > and releasing it at the end we should be holding it only > during the time when we actually need it. I'm pretty sure that this can cause crashes if multipathd

Re: [dm-devel] [PATCH 28/57] libmultipath: use a shared lock to co-operate with udev

On Tue, May 03, 2016 at 04:31:19PM +0100, Germano Percossi wrote: > Hi, > > Sorry for jumping in the middle of patch review > > On 05/03/2016 03:27 PM, Benjamin Marzinski wrote: > >On Tue, May 03, 2016 at 07:57:01AM +0200, Hannes Reinecke wrote: > >>On 05/02/201

Re: [dm-devel] [PATCH 36/57] libmultipath: pass in 'cookie' as argument for dm_addmap()

On Tue, May 03, 2016 at 11:31:19AM +0200, Hannes Reinecke wrote: > On 05/03/2016 12:23 AM, Benjamin Marzinski wrote: > > On Wed, Apr 27, 2016 at 01:10:37PM +0200, Hannes Reinecke wrote: > >> Instead of generating the cookie internally we should be > >> passing

Re: [dm-devel] [PATCH 36/57] libmultipath: pass in 'cookie' as argument for dm_addmap()

On Tue, May 03, 2016 at 04:43:01PM +0200, Hannes Reinecke wrote: > On 05/03/2016 04:39 PM, Benjamin Marzinski wrote: > > On Tue, May 03, 2016 at 11:31:19AM +0200, Hannes Reinecke wrote: > >> On 05/03/2016 12:23 AM, Benjamin Marzinski wrote: > >>> On Wed, Apr 27, 20

Re: [dm-devel] [PATCH 28/57] libmultipath: use a shared lock to co-operate with udev

On Tue, May 03, 2016 at 09:27:32AM -0500, Benjamin Marzinski wrote: > On Tue, May 03, 2016 at 07:57:01AM +0200, Hannes Reinecke wrote: > > On 05/02/2016 06:26 PM, Benjamin Marzinski wrote: > > > On Wed, Apr 27, 2016 at 01:10:29PM +0200, Hannes Reinecke wrote: > > >&

Re: [dm-devel] [PATCH 56/57] multipathd: push down lock in checkerloop()

On Tue, May 03, 2016 at 05:17:34PM -0500, Benjamin Marzinski wrote: > On Wed, Apr 27, 2016 at 01:10:57PM +0200, Hannes Reinecke wrote: > > Instead of grabbing the lock at the start of the checkerloop > > and releasing it at the end we should be holding it only > > during the

Re: [dm-devel] [PATCH 2/6] libmultipath: pass in 'cookie' as argument for dm_addmap()

On Wed, May 04, 2016 at 07:57:26AM +0200, Hannes Reinecke wrote: > Instead of generating the cookie internally we should be > passing in the cookie to dm_addmap(). Like I said in my comment to the last patch, you should never reuse a cookie value once you've waited for it. The only reason that

Re: [dm-devel] [PATCH 6/6] libmultipath: fixup dm_rename to complete cookie on failure

On Wed, May 04, 2016 at 07:57:30AM +0200, Hannes Reinecke wrote: > >From my understanding we should be calling udev_complete() on > a cookie if dm_task_set_cookie() failed. I was wrong when I said that this will sometimes be helpful to us. It is true that it won't hurt things. But that is because

Re: [dm-devel] [PATCH 5/6] devmapper: do not flush I/O for DM_DEVICE_CREATE

On Wed, May 04, 2016 at 07:57:29AM +0200, Hannes Reinecke wrote: > DM_DEVICE_CREATE loads a new table, so there cannot be any > I/O pending. Hence we should be setting the 'no flush' > and 'skip lockfs' flag to avoid delays during creation. ACK -Ben > > Signed-off-by: Hannes Reinecke

Re: [dm-devel] [PATCH 1/6] libmultipath: pass in cookie as argument for dm_simplecmd()

On Wed, May 04, 2016 at 07:57:25AM +0200, Hannes Reinecke wrote: > Instead of generating the cookie internally we should be passing > it in as an argument; that will allow for cookie reuse. While this one doesn't break anything, it seems unhelpful. We are always dealing with the cookies inside

Re: [dm-devel] [PATCH 6/6] libmultipath: fixup dm_rename to complete cookie on failure

On Fri, May 06, 2016 at 10:59:01PM +0100, Alasdair G Kergon wrote: > The library functions and return states are supposed to be well-defined. > > If you think you've found a cookie leak on an error path within a library > function, we can investigate that and fix the library if need be. In

Re: [dm-devel] [PATCH 22/57] multipath: use option '-i' when called from udev

On Wed, Apr 27, 2016 at 01:10:23PM +0200, Hannes Reinecke wrote: > multipath should be using the option '-i' to ignore the wwids > file when called from udev. Otherwise we might run into a race > condition with systemd and the system might not boot up correctly. The race condition being? Are you

Re: [dm-devel] [PATCH 20/57] multipathd: Do not update the paths vec when removing paths

On Mon, May 02, 2016 at 07:48:50AM +0200, Hannes Reinecke wrote: > On 04/30/2016 12:39 AM, Benjamin Marzinski wrote: > > On Wed, Apr 27, 2016 at 01:10:21PM +0200, Hannes Reinecke wrote: > >> When we remove a path it's totally pointless to add it to > >> the path l

Re: [dm-devel] [PATCH 19/57] multipathd: Do not print misleading message 'not found in pathvec'

On Wed, Apr 27, 2016 at 01:10:20PM +0200, Hannes Reinecke wrote: > When looking up a path in the existing configuration it is perfectly > possible for the path not to be present. > This should not generate a message as it might be errorneously > interpreted as an error. > Do you feel really

Re: [dm-devel] [PATCH 23/57] multipath: remove warning 'failed to get wwid'

On Wed, Apr 27, 2016 at 01:10:24PM +0200, Hannes Reinecke wrote: Again. I'd prefer leaving the messages in either at a higher log level or with less alarming text. -Ben > Signed-off-by: Hannes Reinecke > --- > multipath/main.c | 1 - > 1 file changed, 1 deletion(-) > > diff

Re: [dm-devel] [PATCH 28/57] libmultipath: use a shared lock to co-operate with udev

On Wed, Apr 27, 2016 at 01:10:29PM +0200, Hannes Reinecke wrote: > udev since v214 is placing a shared lock on the device node > whenever it's processing the event. This introduces a race > condition with multipathd, as multipathd is processing the > event for the block device at the same time as

Re: [dm-devel] [PATCH 36/57] libmultipath: pass in 'cookie' as argument for dm_addmap()

On Wed, Apr 27, 2016 at 01:10:37PM +0200, Hannes Reinecke wrote: > Instead of generating the cookie internally we should be > passing in the cookie to dm_addmap(). These look like they could actually cause problems. With dm_addmap_create and dm_addmap_reload, you could be in a situation where you

Re: [dm-devel] [PATCH 37/57] Remove 'udev_sync' argument from dm_simplecmd()

On Wed, Apr 27, 2016 at 01:10:38PM +0200, Hannes Reinecke wrote: > The 'udev_sync' attribute is pointless without a cookie, so we > can as well use the existence of the 'cookie' argument for > the same function. ACK. But I do worry that dm_simplecmd is still going to confuse someone later. Right

Re: [dm-devel] [PATCH 22/57] multipath: use option '-i' when called from udev

g version of the SUSE rules file really benefits nobody. I'm in favor of this going it. -Ben >Thanks, >Christophe >On Tue, May 3, 2016 at 7:44 AM, Hannes Reinecke <[1]h...@suse.de> wrote: > > On 05/02/2016 05:31 PM, Benjamin Marzinski wrote: > > On W

Re: [dm-devel] [PATCH 53/57] multipathd: implement 'show map $map format $fmt'

On Wed, Apr 27, 2016 at 01:10:54PM +0200, Hannes Reinecke wrote: > Similar to the existing 'show map $map topology', but allowing > formatted content. This touches on a patch I've thought about writing, but never got around to. The issue is that with show_maps_topology() we call

Re: [dm-devel] [PATCH 4/6] libmultipath: Fixup 'DM_DEVICE_RELOAD' handling

On Mon, May 09, 2016 at 12:26:36PM +0200, Hannes Reinecke wrote: > On 05/06/2016 10:12 PM, Benjamin Marzinski wrote: > > On Wed, May 04, 2016 at 07:57:28AM +0200, Hannes Reinecke wrote: > >> libdevmapper has the 'quirk' that DM_DEVICE_CREATE is translated > >> internall

Re: [dm-devel] [PATCH 4/7] devmapper: wait for udev in dm_simplecmd_noflush()

On Mon, May 09, 2016 at 12:53:02PM +0200, Hannes Reinecke wrote: > When calling dm_simplecmd_noflush() with udev_flags set we > need to set the 'need_sync' flag otherwise the udev flags > will never be set. The other possibility here would be to temporarily disable udev sync support, and then

Re: [dm-devel] [PATCHv2 0/7] multipathd 'cookie' handling rework

On Mon, May 09, 2016 at 12:52:58PM +0200, Hannes Reinecke wrote: > Hi all, > > here's now the second attempt to fixup the 'cookie' handling > in multipath-tools. > I've removed the patch to pass in a cookie as an argument > for dm_addmap_reload() and dm_simplecmd(). > And I've removed all

Re: [dm-devel] [PATCH 0/6] Delete attributes with default values

On Sat, Jul 09, 2016 at 10:17:05AM +0200, Christophe Varoqui wrote: >I'll wait for comments from distribution maintainers on this patchset. >Because, though we have already deleted the checker_name settings when >equal to the default value, it should be clear that with this patchset >

Re: [dm-devel] [PATCH] multipathd: restore paths after reconfigure

On Thu, Jul 21, 2016 at 09:29:37AM -0700, Bart Van Assche wrote: > On 07/01/2016 02:46 PM, Benjamin Marzinski wrote: > >multipathd has code to finish gathering the information of paths that > >were not active at the time they were discovered. When the checker loop > >

[dm-devel] [PATCH] multipathd: fix typo that breaks failure path

There wasn't supposed to be a semicolon after the "else" when checking paths in checkerloop(). Signed-off-by: Benjamin Marzinski <bmarz...@redhat.com> --- multipathd/main.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/multipathd/main.c b/multipathd/main

Re: [dm-devel] dm-mq and end_clone_request()

On Wed, Jul 27, 2016 at 10:08:28AM -0400, Mike Snitzer wrote: > On Tue, Jul 26 2016 at 6:51pm -0400, > Bart Van Assche wrote: > > > On 07/25/2016 06:15 PM, Mike Snitzer wrote: > > > Please try this patch to see if it fixes your issue, thanks. > > > > > > diff --git

Re: [dm-devel] [PATCH V7 2/4] multipath-tools: New way to limit the IPC command length.

On Fri, Aug 12, 2016 at 08:12:38PM +0800, Gris Ge wrote: Perhaps a better way would be to keep your v6 code, and just make the client ignore the SIGPIPE signals. Personally, I'm fine with always ignoring them, since the writes will still fail with EPIPE, and the multipathd client code should be

Re: [dm-devel] [PATCH V6 1/3] multipath-tools: New way to limit the IPC command length.

On Tue, Jul 12, 2016 at 02:50:36PM +0800, Gris Ge wrote: The only thing that I wonder about with this patch is, when previously the multipath client code would have failed with EPIPE, and (at least in some cases) spit out a semi-useful message, the program will now terminate because of the

Re: [dm-devel] [PATCH V6 0/3] Introducing multipath C API

On Tue, Jul 12, 2016 at 02:50:35PM +0800, Gris Ge wrote: ACK, with my comment on patch 1/3 -Ben > Changes since V5: > * Fix commit message typo of patch 1/3: > 'EINVA vs EINVAL' and 'dedicate vs dedicated' > * Use $(LN) and $(RM) in Makefile in patch 3/3. > * Rebased to current

Re: [dm-devel] Subject: [PATCH 1/1] multipath-tools: fix dm- device filtering

On Fri, Jul 08, 2016 at 08:55:38AM +0200, Christophe Varoqui wrote: ACK -Ben >Hannes, Ben, do you ack this one ? >On Thu, Jun 23, 2016 at 11:06 PM, Dragan Stancevic ><[1]dragan.stance...@canonical.com> wrote: > > Hi Christophe, > can you please take a look at the attached

Re: [dm-devel] [PATCH] multipathd: fix waiter_attr resource leak

On Fri, Jul 08, 2016 at 09:59:18AM +0200, Christophe Varoqui wrote: ACK -Ben >Ben, Hannes, I'd appreciate your ack on this patch. >Thanks. >On Wed, Jul 6, 2016 at 10:08 AM, <[1]zhang.ka...@zte.com.cn> wrote: > > As a global variable waiter_attr of thread attribute was set up

Re: [dm-devel] [Patch] multipath-tools: Check if multipathd is running or not and print a warning

On Thu, Jul 28, 2016 at 04:35:21PM +0200, Hannes Reinecke wrote: > On 07/28/2016 01:48 PM, Milan P. Gandhi wrote: > > Hello, > > > > With this patch dm-multipath commands e.g. multipath -v2, > > multipath -ll etc. now checks if there are multipath > > device maps created, and multipathd service

[dm-devel] [PATCH] multipathd: restore paths after reconfigure

that if you reconfigure multipathd while paths are down, they will no longer be usable. This patch makes sure that check_path will actually rerun pathinfo to finish setting up the path, so that after the path comes back up, it will be usable again. Signed-off-by: Benjamin Marzinski <bm

Re: [dm-devel] [PATCH 02/26] Use 'mptable' as argument for find_mpe() and get_mpe_wwid()

On Mon, Jun 20, 2016 at 10:08:49AM +0200, Hannes Reinecke wrote: > Signed-off-by: Hannes Reinecke > --- > libmultipath/config.c | 8 > libmultipath/config.h | 4 ++-- > libmultipath/configure.c | 2 +- > libmultipath/propsel.c | 2 +- >

Re: [dm-devel] [PATCH 00/26] Userspace-RCU for config accesses

On Mon, Jun 20, 2016 at 10:08:47AM +0200, Hannes Reinecke wrote: > Hi all, ACK on all patches besides 2 and 17 (which I've commented on). -Ben > > as Benjamin Marzinski pointed out the 'config' structure is > not protected, but it will be re-allocated whenever we do a >

Re: [dm-devel] deterministic io throughput in multipath

On Thu, Feb 02, 2017 at 06:02:57PM +, Muneendra Kumar M wrote: > Hi Ben, > Thanks for the review. > So can I push my changes as mentioned by you in the below mail using git. Sure. -Ben > > Regards, > Muneendra. > > > -Original Message- > From: Be

Re: [dm-devel] unable to send mails to christophe.varo...@opensvc.com using git

the patch formatting. -Ben > > Regads, > Muneendra. > > > -Original Message- > From: Muneendra Kumar M > Sent: Friday, February 03, 2017 11:55 PM > To: 'Benjamin Marzinski' <bmarz...@redhat.com> > Cc: dm-devel@redhat.com > Subject: RE: [dm-d

Re: [dm-devel] unable to send mails to christophe.varo...@opensvc.com using git

I'm not sure about why you can't send a mail to Christophe. -Ben > Regards, > Muneendra. > > -Original Message- > From: Benjamin Marzinski [mailto:bmarz...@redhat.com] > Sent: Friday, February 03, 2017 9:22 PM > To: Muneendra Kumar M <mmand...@brocade.com> >

Re: [dm-devel] deterministic io throughput in multipath

was failed for. Perhaps it would be easier to show the kind of changes I would make with a patch. What do you think about this? I haven't done much testing on it at all, but these are the changes I would make. Signed-off-by: Benjamin Marzinski <bmarz...@redhat.com> --- libmultipath/config.c

Re: [dm-devel] deterministic io throughput in multipath

f.5 | 57 > + > multipathd/main.c | 83 > +++ > 11 files changed, 281 insertions(+), 34 deletions(-) > > Regards, > Muneendra. >

Re: [dm-devel] deterministic io throughput in multipath

--- >  >  >Regards, >Muneendra. >  >_____ > From: Muneendra Kumar M >Sent: Tuesday, January 17, 2017 4:13 PM >To: 'Benjamin Marzinski' <bmarz...@re

Re: [dm-devel] deterministic io throughput in multipath

rst need to set up your git name and email -Ben > Regards, > Muneendra. > > > > -Original Message- > From: Benjamin Marzinski [mailto:bmarz...@redhat.com] > Sent: Wednesday, January 25, 2017 2:59 PM > To: Muneendra Kumar M <mmand...@brocade.com> > Cc: dm-deve

Re: [dm-devel] [PATCH 1/2] Don't blacklist nvme

On Wed, Feb 15, 2017 at 06:56:17AM -0800, Christoph Hellwig wrote: > On Tue, Feb 14, 2017 at 04:19:13PM -0500, Keith Busch wrote: > > These devices are mulitpath capable, and have been able to stack with > > dm-mpath since kernel 4.2. > > Can we make this conditional on something? I have native

Re: [dm-devel] [PATCH 2/2] Fill NVMe specific path info

On Tue, Feb 14, 2017 at 04:19:14PM -0500, Keith Busch wrote: > Signed-off-by: Keith Busch > --- > Pat of this is dependent on udev updates. Pull request sent to systemd here: > > https://github.com/systemd/systemd/pull/5348 > > Can always add that line by hand in the

Re: [dm-devel] [PATCH] multipath-tools: improve processing efficiency for addition and deletion of multipath devices

On Fri, Feb 17, 2017 at 10:48:44AM +0100, Martin Wilck wrote: > On Fri, 2017-02-17 at 00:21 -0600, Benjamin Marzinski wrote: > > On Thu, Feb 16, 2017 at 11:38:36PM -0600, Benjamin Marzinski wrote: > > > > > + > > > > > +bool > > > > > +merge_

Re: [dm-devel] 答复: Re: [PATCH] multipath-tools: improve processing efficiency for addition and deletion of multipath devices

On Fri, Feb 17, 2017 at 11:24:10AM +0800, tang.jun...@zte.com.cn wrote: >Hello Martin, > >Thanks for your responsible, > >＞ I'd like the following better for this check. It uses much less cycles. > >＞  static bool >＞ can_discard_by_devpath(const char *devpath) > >＞ This 

Re: [dm-devel] [PATCH] multipath-tools: improve processing efficiency for addition and deletion of multipath devices

On Thu, Feb 16, 2017 at 10:17:35PM +0100, Martin Wilck wrote: > Hello Tang, > > I'm sorry to reply so late. Thanks a lot for your work, I agree with > Ben that the patch is in pretty good shape now. But I have some > remarks left, please see below. > > > +bool > > +uevent_can_discard(struct

Re: [dm-devel] [PATCH] multipath-tools: improve processing efficiency for addition and deletion of multipath devices

On Thu, Feb 16, 2017 at 11:38:36PM -0600, Benjamin Marzinski wrote: Quite possibly, I shouldn't try responding to email at 11:30 PM. It appears that my brain has already given up for the day. > On Thu, Feb 16, 2017 at 10:17:35PM +0100, Martin Wilck wrote: > > Hello Tang, > >

Re: [dm-devel] [PATCHv2] Fill NVMe specific path info

ACK -Ben On Tue, Feb 21, 2017 at 05:12:31PM -0500, Keith Busch wrote: > Signed-off-by: Keith Busch > --- > v1->v2: > Removed explicitly setting the wwid path information. We get that with > through exported udev attributes. > > Added default retain_hwhandler to off

[dm-devel] [PATCH v2 3/7] libmultipath: cleanup orphan device states

After a path device is orphaned, multipathd stops checking its state. However, multipathd show state still shows its old state. It should display "undef unknown" instead. Signed-off-by: Benjamin Marzinski <bmarz...@redhat.com> --- libmultipath/print.c | 4 ++-- 1 file changed, 2

[dm-devel] [PATCH v2 4/7] multipathd: don't update priority of failed paths

Multipathd shouldn't be updating the priority of failed paths in the checkerloop. The current avoids this in almost all cases, but not all. Close the loophole. Signed-off-by: Benjamin Marzinski <bmarz...@redhat.com> --- multipathd/main.c | 3 ++- 1 file changed, 2 insertions(+), 1 de

[dm-devel] [PATCH v2 6/7] multipathd: allow resetting stats

This patch adds two multipathd interactive commands: multipathd reset maps stats and multipathd reset map stats to reset the statistics that are shown with the "show stats" commands. Signed-off-by: Benjamin Marzinski <bmarz...@redhat.com> --- multipathd/cli.c |

[dm-devel] [PATCH v2 7/7] fix udev rules for failed multipath devices

. and disables the other rules. Cc: Peter Rajnoha <prajn...@redhat.com> Signed-off-by: Benjamin Marzinski <bmarz...@redhat.com> --- libmultipath/devmapper.c| 3 +- libmultipath/devmapper.h| 6 multipath/11-dm-mpath.rules | 67 +++---

[dm-devel] [PATCH v2 5/7] multipathd: add messages on delayed path addition

When multipath delays adding a path because the device is waiting for udev to finish initialization, it now logs a message, so the users know what happened to the path. Signed-off-by: Benjamin Marzinski <bmarz...@redhat.com> --- multipathd/main.c | 3 +++ 1 file changed, 3 insertions(+)

[dm-devel] [PATCH v2 0/7] misc patches

y previous version didn't handle coldplug events correctly. Benjamin Marzinski (7): kpartx: don't keep creating recursive partitions libmultipath: add detect_checker option libmultipath: cleanup orphan device states multipathd: don't update priority of failed paths multipathd: ad

[dm-devel] [PATCH v2 1/7] kpartx: don't keep creating recursive partitions

If the dos partition table is corrupted, kpartx can just keep creating the same partitions until it runs out of partition numbers. This check catches the recursion. Signed-off-by: Cedric Buissart <cbuis...@redhat.com> Signed-off-by: Benjamin Marzinski <bmarz...@redhat.com> --- kpar

[dm-devel] [PATCH v2 2/7] libmultipath: add detect_checker option

have been told). It is set on by default just like detect_prio and retain_attached_hw_handler. Cc: Hannes Reinecke <h...@suse.de> Signed-off-by: Benjamin Marzinski <bmarz...@redhat.com> --- libmultipath/config.c | 3 +++ libmultipath/config.h | 2 ++ libmultipath/defaul

[dm-devel] [PATCH 6/7] multipathd: allow resetting stats

This patch adds two multipathd interactive commands: multipathd reset maps stats and multipathd reset map stats to reset the statistics that are shown with the "show stats" commands. Signed-off-by: Benjamin Marzinski <bmarz...@redhat.com> --- multipathd/cli.c |

[dm-devel] [PATCH 2/7] libmultipath: add detect_checker option

have been told). It is set on by default just like detect_prio and retain_attached_hw_handler. Signed-off-by: Benjamin Marzinski <bmarz...@redhat.com> --- libmultipath/config.c | 3 +++ libmultipath/config.h | 2 ++ libmultipath/defaults.h| 1 + libmultipath/dict.c

  1   2   3   4   5   6   7   8   9   10   >