Re: [dm-devel] dm-multipath low performance with blk-mq

On 01/27/2016 11:16 AM, Mike Snitzer wrote: On Wed, Jan 27 2016 at 12:51pm -0500, Jens Axboe <ax...@kernel.dk> wrote: On 01/27/2016 10:48 AM, Mike Snitzer wrote: BTW, I _cannot_ get null_blk to come even close to your reported 1500K+ IOPs on 2 "fast" systems I have a

Re: [dm-devel] dm stripe: add DAX support

45f4c4 https://git.kernel.org/cgit/linux/kernel/git/device-mapper/linux-dm.git/commit/?h=for-next=51d1a5abcd0e88cb4528f35643245ea59cf234f1 Feel free to pick them up from patchwork or cherry-pick from linux-dm.git Added for 4.8, thanks! -- Jens Axboe -- dm-devel mailing list dm-devel@redhat.com https://ww

Re: [dm-devel] [PATCH next] Btrfs: fix comparison in __btrfs_map_block()

On 07/15/2016 09:03 AM, Vincent Stehlé wrote: Add missing comparison to op in expression, which was forgotten when doing the REQ_OP transition. Thanks, added to the 4.8 branch. -- Jens Axboe -- dm-devel mailing list dm-devel@redhat.com https://www.redhat.com/mailman/listinfo/dm-devel

Re: [dm-devel] bug: using smp_processor_id() in preemptible code in rr_select_path()

On 08/05/2016 09:42 AM, Mike Snitzer wrote: On Fri, Aug 05 2016 at 11:33P -0400, Jens Axboe <ax...@kernel.dk> wrote: On 08/05/2016 09:27 AM, Mike Snitzer wrote: On Wed, Aug 03 2016 at 11:35am -0400, Benjamin Block <bbl...@linux.vnet.ibm.com> wrote: Hej Mike, when running a

Re: [dm-devel] bug: using smp_processor_id() in preemptible code in rr_select_path()

On 08/05/2016 10:06 AM, Mike Snitzer wrote: On Fri, Aug 05 2016 at 11:54am -0400, Jens Axboe <ax...@kernel.dk> wrote: On 08/05/2016 09:42 AM, Mike Snitzer wrote: On Fri, Aug 05 2016 at 11:33P -0400, Jens Axboe <ax...@kernel.dk> wrote: On 08/05/2016 09:27 AM, Mike Snitzer wrote:

Re: [dm-devel] bug: using smp_processor_id() in preemptible code in rr_select_path()

On 08/08/2016 10:32 AM, Benjamin Block wrote: On 12:06 Fri 05 Aug , Mike Snitzer wrote: On Fri, Aug 05 2016 at 11:54am -0400, Jens Axboe <ax...@kernel.dk> wrote: On 08/05/2016 09:42 AM, Mike Snitzer wrote: On Fri, Aug 05 2016 at 11:33P -0400, Jens Axboe <ax...@kernel.dk> wr

Re: [dm-devel] [PATCH v4] dm: don't allow ioctls to targets that don't map to whole devices

> As the SCSI ioctl code is now optional, we really don't want to > drag it in for DM, and the exception is not very useful anyway. > > Signed-off-by: Christoph Hellwig <h...@lst.de> > Acked-by: Mike Snitzer <snit...@redhat.com> Added, with the acks/reviews from Johann

Re: [dm-devel] split scsi passthrough fields out of struct request V2

On 01/31/2017 01:55 PM, Bart Van Assche wrote: > On Tue, 2017-01-31 at 13:34 -0800, Bart Van Assche wrote: >> On Mon, 2017-01-30 at 17:38 -0800, Jens Axboe wrote: >>> That's a known bug in mainline. Pull it into 4.10-rc6, >>> or use my for-next where everything is alread

Re: [dm-devel] split scsi passthrough fields out of struct request

same clone and map method as the blk-mq version. I'd like to get this in sooner rather than later, so I'll spend some time reviewing and testing it start this week. I'm assuming you are targeting 4.11 with this change, right? -- Jens Axboe -- dm-devel mailing list dm-devel@redhat.com https://www.redhat.com/mailman/listinfo/dm-devel

Re: [dm-devel] split scsi passthrough fields out of struct request V2

On 01/26/2017 06:22 PM, Jens Axboe wrote: > On 01/26/2017 06:15 PM, Bart Van Assche wrote: >> On Thu, 2017-01-26 at 17:41 -0700, Jens Axboe wrote: >>> On 01/26/2017 05:38 PM, Bart Van Assche wrote: >>>> I see similar behavior with the blk-mq-sched branch of >>&g

Re: [dm-devel] split scsi passthrough fields out of struct request V2

On 01/26/2017 11:40 PM, Jens Axboe wrote: > On 01/26/2017 06:22 PM, Jens Axboe wrote: >> On 01/26/2017 06:15 PM, Bart Van Assche wrote: >>> On Thu, 2017-01-26 at 17:41 -0700, Jens Axboe wrote: >>>> On 01/26/2017 05:38 PM, Bart Van Assche wrote: >>>>>

Re: [dm-devel] split scsi passthrough fields out of struct request V2

On 01/27/2017 09:17 AM, Christoph Hellwig wrote: > On Fri, Jan 27, 2017 at 09:11:14AM -0700, Jens Axboe wrote: >> I've queued this up for 4.11. Since some of the patches had dependencies >> on changes in master since for-4.11/block was forked, they are sitting >> in a separate

Re: [dm-devel] split scsi passthrough fields out of struct request V2

On 01/27/2017 09:23 AM, Christoph Hellwig wrote: > On Fri, Jan 27, 2017 at 09:21:46AM -0700, Jens Axboe wrote: >> On 01/27/2017 09:17 AM, Christoph Hellwig wrote: >>> On Fri, Jan 27, 2017 at 09:11:14AM -0700, Jens Axboe wrote: >>>> I've queued this up for 4.11.

Re: [dm-devel] split scsi passthrough fields out of struct request V2

On 01/27/2017 09:52 AM, Bart Van Assche wrote: > On Fri, 2017-01-27 at 01:04 -0700, Jens Axboe wrote: >> The previous patch had a bug if you didn't use a scheduler, here's a >> version that should work fine in both cases. I've also updated the >> above mentioned branch,

Re: [dm-devel] split scsi passthrough fields out of struct request V2

On 01/27/2017 09:42 AM, Christoph Hellwig wrote: > On Fri, Jan 27, 2017 at 09:38:40AM -0700, Jens Axboe wrote: >>> Ok, I'll repost what I have right now, which is on top of a merge >>> of your block/for-4.11/next and your for-next from this morning >>> my time. >&g

Re: [dm-devel] [PATCH 05/18] block: allow specifying size for extra command data

h and Martin, > > How about using the function names alloc_full_request() / free_full_request() > together with a comment that mentions that cmd_size is set by the LLD? Since we use pdu in other places, how about alloc_request_pdu() or alloc_request_with_pdu()? And since it's all queued up, any bike s

Re: [dm-devel] split scsi passthrough fields out of struct request V2

On 01/26/2017 11:52 AM, Bart Van Assche wrote: > On Thu, 2017-01-26 at 11:44 -0700, Jens Axboe wrote: >> I think this may be my bug - does the below help? > > Hello Jens, > > What tree has that patch been generated against? It does not apply > cleanly on top of Chri

Re: [dm-devel] split scsi passthrough fields out of struct request V2

UA); struct blk_plug *plug; unsigned int request_count = 0; - struct blk_mq_alloc_data data; + struct blk_mq_alloc_data data = { 0, }; struct request *rq; blk_qc_t cookie; unsigned int wb_acct; -- Jens Axboe -- dm-devel mailing list dm-devel@redhat.com https://www.redhat.com/mailman/listinfo/dm-devel

Re: [dm-devel] split scsi passthrough fields out of struct request V2

On 01/26/2017 11:59 AM, h...@lst.de wrote: > On Thu, Jan 26, 2017 at 11:57:36AM -0700, Jens Axboe wrote: >> It's against my for-4.11/block, which you were running under Christoph's >> patches. Maybe he's using an older version? In any case, should be >> pretty trivial for yo

Re: [dm-devel] [PATCH 15/16] block: split scsi_request out of struct request

; > Jens, any opinion on just removing the printout of the SCSI CDB > for blktrace? Kill it with fire, I don't think there's much value to having it there to begin with. -- Jens Axboe -- dm-devel mailing list dm-devel@redhat.com https://www.redhat.com/mailman/listinfo/dm-devel

Re: [dm-devel] [PATCH 05/18] block: allow specifying size for extra command data

On 01/27/2017 10:30 AM, Bart Van Assche wrote: > On Fri, 2017-01-27 at 10:26 -0700, Jens Axboe wrote: >> On 01/27/2017 10:21 AM, Bart Van Assche wrote: >>> On Fri, 2017-01-27 at 17:12 +0100, Christoph Hellwig wrote: >>>> On Wed, Jan 25, 2017 at 10:15:55PM -

Re: [dm-devel] split scsi passthrough fields out of struct request V2

> On Jan 30, 2017, at 5:12 PM, Bart Van Assche <bart.vanass...@sandisk.com> > wrote: > >> On Fri, 2017-01-27 at 09:56 -0700, Jens Axboe wrote: >>> On 01/27/2017 09:52 AM, Bart Van Assche wrote: >>> [ 215.724452] general protection fault:

Re: [dm-devel] split scsi passthrough fields out of struct request V2

On 01/30/2017 05:38 PM, Jens Axboe wrote: > > >> On Jan 30, 2017, at 5:12 PM, Bart Van Assche <bart.vanass...@sandisk.com> >> wrote: >> >>> On Fri, 2017-01-27 at 09:56 -0700, Jens Axboe wrote: >>>> On 01/27/2017 09:52 AM, Bart Van Assche wrote:

Re: [dm-devel] split scsi passthrough fields out of struct request V2

On 01/26/2017 01:47 PM, Bart Van Assche wrote: > On 01/26/2017 11:01 AM, Jens Axboe wrote: >> On 01/26/2017 11:59 AM, h...@lst.de wrote: >>> On Thu, Jan 26, 2017 at 11:57:36AM -0700, Jens Axboe wrote: >>>> It's against my for-4.11/block, which you were running under C

Re: [dm-devel] split scsi passthrough fields out of struct request V2

On 01/26/2017 02:01 PM, Bart Van Assche wrote: > On Thu, 2017-01-26 at 13:54 -0700, Jens Axboe wrote: >> Your call path has blk_get_request() in it, I don't have >> that in my tree. Is it passing in the right mask? > > Hello Jens, > > There is only one blk_get_requ

Re: [dm-devel] split scsi passthrough fields out of struct request V2

On 01/26/2017 06:15 PM, Bart Van Assche wrote: > On Thu, 2017-01-26 at 17:41 -0700, Jens Axboe wrote: >> On 01/26/2017 05:38 PM, Bart Van Assche wrote: >>> I see similar behavior with the blk-mq-sched branch of >>> git://git.kernel.dk/linux-block.git (git commit ID

Re: [dm-devel] split scsi passthrough fields out of struct request V2

On 01/26/2017 04:50 PM, Jens Axboe wrote: > On 01/26/2017 04:47 PM, Bart Van Assche wrote: >> On Thu, 2017-01-26 at 16:26 -0700, Jens Axboe wrote: >>> What device is stuck? Is it running with an mq scheduler attached, or >>> with "none"? >>> >>&

Re: [dm-devel] split scsi passthrough fields out of struct request V2

On 01/26/2017 04:14 PM, Bart Van Assche wrote: > On Thu, 2017-01-26 at 14:51 -0700, Jens Axboe wrote: >> That is exactly what it means, looks like that one path doesn't handle >> that. You'd have to exhaust the pool with atomic allocs for this to >> trigger, we don't do that

Re: [dm-devel] split scsi passthrough fields out of struct request V2

On 01/26/2017 04:47 PM, Bart Van Assche wrote: > On Thu, 2017-01-26 at 16:26 -0700, Jens Axboe wrote: >> What device is stuck? Is it running with an mq scheduler attached, or >> with "none"? >> >> Would also be great to see the output of /sys/block/*/mq/*

Re: [dm-devel] split scsi passthrough fields out of struct request V2

*q, rq = __blk_mq_alloc_request(data, op); } else { rq = __blk_mq_alloc_request(data, op); - data->hctx->tags->rqs[rq->tag] = rq; + if (rq) + data->hctx->tags->rqs[rq->tag] = rq; } if (rq) { -- Jens Axboe -- dm-devel mailing list dm-devel@redhat.com https://www.redhat.com/mailman/listinfo/dm-devel

Re: [dm-devel] [PATCH 01/16] block: fix elevator init check

keep the helper but just make it take the opf and fix up the other locations too. The fact that PREFLUSH|FUA is the magic to check for is somewhat tribal knowledge. -- Jens Axboe -- dm-devel mailing list dm-devel@redhat.com https://www.redhat.com/mailman/listinfo/dm-devel

Re: [dm-devel] [patch] block: add blktrace C events for bio-based drivers

rking the bi_flags non-atomically. I probably prefer the latter. -- Jens Axboe -- dm-devel mailing list dm-devel@redhat.com https://www.redhat.com/mailman/listinfo/dm-devel

Re: [dm-devel] kernel oops with blk-mq-sched latest

On 01/17/2017 04:47 AM, Jens Axboe wrote: > On 01/17/2017 12:57 AM, Hannes Reinecke wrote: >> Hi Jens, >> >> I gave your latest patchset from >> >> git.kernel.dk/linux-block blk-mq-sched >> >> I see a kernel oops when shutting down: >> >>

Re: [dm-devel] kernel oops with blk-mq-sched latest

lv_drain_elevator(struct request_queue *q) { static int printed; + if (WARN_ON_ONCE(q->mq_ops)) + return; + lockdep_assert_held(q->queue_lock); while (q->elevator->type->ops.sq.elevator_dispatch_fn(q, 1)) -- Jens Axboe -- dm-devel mailing list dm-devel@redhat.com https://www.redhat.com/mailman/listinfo/dm-devel

Re: [dm-devel] kernel oops with blk-mq-sched latest

s slightly better than sq performance, though. What is the test case? Full details please, from hardware to what you are running. As I've mentioned before, I don't necessarily think your performance issues are related to scheduling. Would be nice to get to the bottom of it, though. And for that

Re: [dm-devel] bug: using smp_processor_id() in preemptible code in rr_select_path()

0dd9 the round-robin path selector is now using percpu data (pointer) and a percpu_counter. I'm really not sure how else to access this percpu data. Cc'ing LKML, linux-block, Jens and hch to cast a wider net in the hopes of getting an answer to how to fix this. From a quick look, looks like you

Re: [dm-devel] [PATCH 1/3] blk-mq: introduce blk_mq_delay_kick_requeue_list()

fer processing requeued requests while it doesn't make sense to immediately requeue them (e.g. when all paths in a DM multipath have failed). Looks fine to me, sans the missing jiffies conversion that Bart pointed out. -- Jens Axboe -- dm-devel mailing list dm-devel@redhat.com https://www.redhat.com/mail

Re: [dm-devel] [PATCH v2 1/6] blk-mq: introduce blk_mq_delay_kick_requeue_list()

ave the interface as taking msecs, but do msecs_to_jiffies() before calling into kblockd_schedule_delayed_work(). -- Jens Axboe -- dm-devel mailing list dm-devel@redhat.com https://www.redhat.com/mailman/listinfo/dm-devel

Re: [dm-devel] [PATCH v3 1/6] blk-mq: introduce blk_mq_delay_kick_requeue_list()

fer processing requeued requests while it doesn't make sense to immediately requeue them (e.g. when all paths in a DM multipath have failed). Applied for 4.9. -- Jens Axboe -- dm-devel mailing list dm-devel@redhat.com https://www.redhat.com/mailman/listinfo/dm-devel

Re: [dm-devel] dm-crypt: Fix error with too large bios

nlimited I/O request and splits it to several bios. When bio size limitations are gone, we could simplify dm-io too. The patch from Ming Lei was applied for 4.8 the other day. -- Jens Axboe -- dm-devel mailing list dm-devel@redhat.com https://www.redhat.com/mailman/listinfo/dm-devel

Re: [dm-devel] [PATCH v2] block: disallow changing max_sectors_kb on a request stacking device

be smaller (or equal to) the max size of the lower level. -- Jens Axboe -- dm-devel mailing list dm-devel@redhat.com https://www.redhat.com/mailman/listinfo/dm-devel

Re: [dm-devel] [PATCH 00/12] block: cleanup direct access to bvec table

ose. I've added the series, except 6-8, the dm parts. I updated some of the descriptions/subjects to read a little better. -- Jens Axboe -- dm-devel mailing list dm-devel@redhat.com https://www.redhat.com/mailman/listinfo/dm-devel

Re: [dm-devel] [PATCH 15/15] block: split scsi_request out of struct request

nt sense_len; > - unsigned int resid_len; /* residual count */ > - void *sense; Oh yes, my mouth is watering. I've wanted to kill off ->cmd and friends with fire for years. On the block front, I think the solution is fine with mimicking the mq solution of carrying an rq payload, and the imp

Re: [dm-devel] [PATCH 1/7] block: use legacy path for flush requests for MQ with a scheduler

On 12/05/2016 03:40 PM, Mike Snitzer wrote: > On Mon, Dec 5, 2016 at 10:07 AM, Jens Axboe <ax...@fb.com> wrote: >> >> On 12/05/2016 06:05 AM, Christoph Hellwig wrote: >>> On Fri, Dec 02, 2016 at 08:15:15PM -0700, Jens Axboe wrote: >>>> No fun

Re: [dm-devel] [PATCH 02/25] block: remove the blk_execute_rq return value

gt;> the value of the "error" variable I think -EIO should be assigned to that >> variable before the "goto out_put_request" statement is reached. > > You're right! I'll fix it up. Are you respinning this series for 4.12? -- Jens Axboe -- dm-devel mailing list

Re: [dm-devel] kill req->errors V4

th new fields > in the drivers (or an odd hack in a union in struct request for > two bitrotting old drivers). Applied for 4.12, thanks. -- Jens Axboe -- dm-devel mailing list dm-devel@redhat.com https://www.redhat.com/mailman/listinfo/dm-devel

Re: [dm-devel] [PATCH v2 for-4.12] block: fix blk_integrity_register to use template's interval_exp if not 0

on as the merge window opens, so you should not have any delays. -- Jens Axboe -- dm-devel mailing list dm-devel@redhat.com https://www.redhat.com/mailman/listinfo/dm-devel

Re: [dm-devel] [PATCH] block: get rid of blk_integrity_revalidate()

used for (un)registering > the integrity profile with the block layer, move BDI_CAP_STABLE_WRITES > setting there. This way drivers that call blk_integrity_register() and > use integrity infrastructure won't interfere with drivers that don't > but still want stable pages. Applied, thanks. -- Jens Axboe -- dm-devel mailing list dm-devel@redhat.com https://www.redhat.com/mailman/listinfo/dm-devel

Re: [dm-devel] [PATCH v2] blk: improve order of bio handling in generic_make_request()

be done separately and with increased urgency. -- Jens Axboe -- dm-devel mailing list dm-devel@redhat.com https://www.redhat.com/mailman/listinfo/dm-devel

Re: [dm-devel] [PATCH v2] blk: improve order of bio handling in generic_make_request()

On 03/09/2017 09:38 PM, Jens Axboe wrote: > On 03/09/2017 09:32 PM, NeilBrown wrote: >> >> I started looking further at the improvements we can make once >> generic_make_request is fixed, and realised that I had missed an >> important detail in this patch. >> Seve

Re: [dm-devel] [PATCH 0/5] Updates following recent generic_make_request improvement

e_workqueue optional." doesn't change any functionality at all. I have applied the first patch for this series, and added the Fixes tag. We'll let the rest simmer a bit, then aim for 4.12 for those. -- Jens Axboe -- dm-devel mailing list dm-devel@redhat.com https://www.redhat.com/mailman/listinfo/dm-devel

Re: [dm-devel] [PATCH 0/2] Trace completion of all bios

d. Added for 4.12. I hand applied 2/2, since it did not apply directly to the 4.12 branch. -- Jens Axboe -- dm-devel mailing list dm-devel@redhat.com https://www.redhat.com/mailman/listinfo/dm-devel

Re: [dm-devel] always use REQ_OP_WRITE_ZEROES for zeroing offload V2

ta, and also switches WRITE SAME > based zeroing in SCSI to this new method. > > The series is against the block for-next tree. Added for 4.12, thanks Christoph. -- Jens Axboe -- dm-devel mailing list dm-devel@redhat.com https://www.redhat.com/mailman/listinfo/dm-devel

Re: [dm-devel] [PATCH 1/9] QUEUE_FLAG_NOWAIT to indicate device supports nowait

On 08/10/2017 08:25 AM, Jan Kara wrote: > On Thu 10-08-17 06:49:53, Goldwyn Rodrigues wrote: >> On 08/09/2017 09:17 PM, Jens Axboe wrote: >>> On 08/09/2017 08:07 PM, Goldwyn Rodrigues wrote: >>>>>>>>>> No, from a multi-device point of view, this is i

Re: [dm-devel] two small integrity cleanups

On 08/09/2017 09:48 AM, Christoph Hellwig wrote: > Found these while coming up with the fixes just sent. Added for 4.14. -- Jens Axboe -- dm-devel mailing list dm-devel@redhat.com https://www.redhat.com/mailman/listinfo/dm-devel

Re: [dm-devel] [PATCH] block: Make blk_mq_delay_kick_requeue_list() rerun the queue at a quiet time

his function such that the queue is run once > per path change event instead of once per request that is requeued. Looks good to me, will add for this series. Thanks Bart. -- Jens Axboe -- dm-devel mailing list dm-devel@redhat.com https://www.redhat.com/mailman/listinfo/dm-devel

Re: [dm-devel] [PATCH 1/9] QUEUE_FLAG_NOWAIT to indicate device supports nowait

On 08/10/2017 05:49 AM, Goldwyn Rodrigues wrote: > > > On 08/09/2017 09:17 PM, Jens Axboe wrote: >> On 08/09/2017 08:07 PM, Goldwyn Rodrigues wrote: >>>>>>>>> No, from a multi-device point of view, this is inconsistent. I >>>>>>>

Re: [dm-devel] [PATCH 1/9] QUEUE_FLAG_NOWAIT to indicate device supports nowait

On 08/10/2017 11:15 AM, Goldwyn Rodrigues wrote: > > > On 08/10/2017 09:28 AM, Jens Axboe wrote: >> On 08/10/2017 08:25 AM, Jan Kara wrote: >>> On Thu 10-08-17 06:49:53, Goldwyn Rodrigues wrote: >>>> On 08/09/2017 09:17 PM, Jens Axboe wrote: >>>>&

Re: [dm-devel] [PATCH 1/1] block: Convert hd_struct in_flight from atomic to percpu

On 06/29/2017 10:00 AM, Jens Axboe wrote: > On 06/29/2017 09:58 AM, Jens Axboe wrote: >> On 06/29/2017 02:40 AM, Ming Lei wrote: >>> On Thu, Jun 29, 2017 at 5:49 AM, Jens Axboe <ax...@kernel.dk> wrote: >>>> On 06/28/2017 03:12 PM, Brian King wrote: >>>

Re: [dm-devel] [PATCH 1/1] block: Convert hd_struct in_flight from atomic to percpu

On 06/29/2017 07:20 PM, Ming Lei wrote: > On Fri, Jun 30, 2017 at 2:42 AM, Jens Axboe <ax...@kernel.dk> wrote: >> On 06/29/2017 10:00 AM, Jens Axboe wrote: >>> On 06/29/2017 09:58 AM, Jens Axboe wrote: >>>> On 06/29/2017 02:40 AM, Ming Lei wrote: >>>&

Re: [dm-devel] [PATCH 1/1] block: Convert hd_struct in_flight from atomic to percpu

On 06/28/2017 04:07 PM, Brian King wrote: > On 06/28/2017 04:59 PM, Jens Axboe wrote: >> On 06/28/2017 03:54 PM, Jens Axboe wrote: >>> On 06/28/2017 03:12 PM, Brian King wrote: >>>> -static inline int part_in_flight(struct hd_struct *part) >>>> +static

Re: [dm-devel] [PATCH 1/1] block: Convert hd_struct in_flight from atomic to percpu

On 06/28/2017 03:54 PM, Jens Axboe wrote: > On 06/28/2017 03:12 PM, Brian King wrote: >> -static inline int part_in_flight(struct hd_struct *part) >> +static inline unsigned long part_in_flight(struct hd_struct *part) >> { >> -return atomic_read(>in_flight[0])

Re: [dm-devel] [PATCH 1/1] block: Convert hd_struct in_flight from atomic to percpu

ks about blk-mq on pending issues to fix up. It's just not great as it currently stands, but I don't think per CPU counters is the right way to fix it, at least not for the inflight counter. -- Jens Axboe -- dm-devel mailing list dm-devel@redhat.com https://www.redhat.com/mailman/listinfo/dm-devel

Re: [dm-devel] [PATCH 1/1] block: Convert hd_struct in_flight from atomic to percpu

On 06/30/2017 07:05 AM, Brian King wrote: > On 06/29/2017 09:17 PM, Jens Axboe wrote: >> On 06/29/2017 07:20 PM, Ming Lei wrote: >>> On Fri, Jun 30, 2017 at 2:42 AM, Jens Axboe <ax...@kernel.dk> wrote: >>>> On 06/29/2017 10:00 AM, Jens Axboe wrote: >>&g

Re: [dm-devel] [PATCH 1/1] block: Convert hd_struct in_flight from atomic to percpu

On 06/29/2017 09:58 AM, Jens Axboe wrote: > On 06/29/2017 02:40 AM, Ming Lei wrote: >> On Thu, Jun 29, 2017 at 5:49 AM, Jens Axboe <ax...@kernel.dk> wrote: >>> On 06/28/2017 03:12 PM, Brian King wrote: >>>> This patch converts the in_flight counter in struct h

Re: [dm-devel] [PATCH 1/1] block: Convert hd_struct in_flight from atomic to percpu

On 06/29/2017 02:40 AM, Ming Lei wrote: > On Thu, Jun 29, 2017 at 5:49 AM, Jens Axboe <ax...@kernel.dk> wrote: >> On 06/28/2017 03:12 PM, Brian King wrote: >>> This patch converts the in_flight counter in struct hd_struct from a >>> pair of atomics to a pair of

Re: [dm-devel] [PATCH 1/1] block: Convert hd_struct in_flight from atomic to percpu

On 06/30/2017 08:08 AM, Jens Axboe wrote: > On 06/30/2017 07:05 AM, Brian King wrote: >> On 06/29/2017 09:17 PM, Jens Axboe wrote: >>> On 06/29/2017 07:20 PM, Ming Lei wrote: >>>> On Fri, Jun 30, 2017 at 2:42 AM, Jens Axboe <ax...@kernel.dk> wrote: >>&g

Re: [dm-devel] [PATCH 1/1] block: Convert hd_struct in_flight from atomic to percpu

On 06/30/2017 05:23 PM, Ming Lei wrote: > Hi Bian, > > On Sat, Jul 1, 2017 at 2:33 AM, Brian King <brk...@linux.vnet.ibm.com> wrote: >> On 06/30/2017 09:08 AM, Jens Axboe wrote: >>>>>> Compared with the totally percpu approach, this way might help 1:M or >

Re: [dm-devel] [PATCH 1/1] block: Convert hd_struct in_flight from atomic to percpu

On 06/30/2017 10:17 PM, Jens Axboe wrote: > On 06/30/2017 08:08 AM, Jens Axboe wrote: >> On 06/30/2017 07:05 AM, Brian King wrote: >>> On 06/29/2017 09:17 PM, Jens Axboe wrote: >>>> On 06/29/2017 07:20 PM, Ming Lei wrote: >>>>> On Fri, Jun 30, 2017 a

Re: [dm-devel] [PATCH 1/1] block: Convert hd_struct in_flight from atomic to percpu

On 07/04/2017 02:55 PM, Brian King wrote: > On 07/01/2017 11:43 AM, Jens Axboe wrote: >> Now: >> >> http://git.kernel.dk/cgit/linux-block/commit/?h=mq-inflight=87f73ef2b9edb6834001df8f7cb48c7a116e8cd3 >> >>> And updated the branch here: >>> >&g

Re: [dm-devel] [PATCH 1/9] QUEUE_FLAG_NOWAIT to indicate device supports nowait

32 /* stack device driver supports >> REQ_NOWAIT */ Does this work on 32-bit, where sizeof(unsigned long) == 32? -- Jens Axboe -- dm-devel mailing list dm-devel@redhat.com https://www.redhat.com/mailman/listinfo/dm-devel

Re: [dm-devel] integrity regression fixes for 4.13-rc

f a pull request, but I'll get this in for the next -rc. -- Jens Axboe -- dm-devel mailing list dm-devel@redhat.com https://www.redhat.com/mailman/listinfo/dm-devel

Re: [dm-devel] [PATCH 1/9] QUEUE_FLAG_NOWAIT to indicate device supports nowait

, which will make the -EAGAIN >> only mean 'try again'. > > Don't take it as EAGAIN, but read it as EWOULDBLOCK. Why do you say > the API is hard to use? Do you have a case to back it up? Because it is hard to use, and potentially suboptimal. Let's say you're doing a 1MB write, we hi

Re: [dm-devel] [PATCH 1/9] QUEUE_FLAG_NOWAIT to indicate device supports nowait

On 08/08/2017 02:36 PM, Jens Axboe wrote: > On 08/08/2017 02:32 PM, Shaohua Li wrote: >>> diff --git a/include/linux/blkdev.h b/include/linux/blkdev.h >>> index 25f6a0cb27d3..fae021ebec1b 100644 >>> --- a/include/linux/blkdev.h >>> +++ b/include/linux/

Re: [dm-devel] move bounce limits settings into the drivers

in that area. Looks straight forward and trivial to me, I'll pull it in for 4.13. -- Jens Axboe -- dm-devel mailing list dm-devel@redhat.com https://www.redhat.com/mailman/listinfo/dm-devel

Re: [dm-devel] dedicated error codes for the block layer V3

linux-btrfs last time. If you didn't get them they are available in > the git tree above. Unfortunately there is no easy way to split them > up. Mike, can you take a look at the dm bits in this series? I'd like to get this queued up, but I'd also greatly prefer if the dm patches had sign off from

Re: [dm-devel] dedicated error codes for the block layer V3

On Fri, Jun 09 2017, Mike Snitzer wrote: > On Thu, Jun 08 2017 at 11:42am -0400, > Jens Axboe <ax...@kernel.dk> wrote: > > > On 06/03/2017 01:37 AM, Christoph Hellwig wrote: > > > This series introduces a new blk_status_t error code type for the block > >

Re: [dm-devel] dedicated error codes for the block layer V3

linux-btrfs last time. If you didn't get them they are available in > the git tree above. Unfortunately there is no easy way to split them > up. Added for 4.13, thanks. -- Jens Axboe -- dm-devel mailing list dm-devel@redhat.com https://www.redhat.com/mailman/listinfo/dm-devel

Re: [dm-devel] block: missing break in process_queued_bios()

th: add missing break in process_queued_bios()" > > Also, this should go through Jens and I'll rebase my linux-dm branches > accordingly. Jens, please pick this up. > > Acked-by: Mike Snitzer <snit...@redhat.com> Thanks, I've added it to the 4.13 branch. -- Jens Axboe -- dm-devel mailing list dm-devel@redhat.com https://www.redhat.com/mailman/listinfo/dm-devel

Re: [dm-devel] [PATCH v2] block: directly insert blk-mq request from blk_insert_cloned_request()

On 09/14/2017 10:33 AM, Ming Lei wrote: > On Fri, Sep 15, 2017 at 12:30 AM, Jens Axboe <ax...@kernel.dk> wrote: >> On 09/14/2017 09:57 AM, Ming Lei wrote: >>> On Tue, Sep 12, 2017 at 5:27 AM, Jens Axboe <ax...@kernel.dk> wrote: >>>> On 09/11/2017 03:13 PM

Re: [dm-devel] [PATCH v2] block: directly insert blk-mq request from blk_insert_cloned_request()

On 09/14/2017 09:57 AM, Ming Lei wrote: > On Tue, Sep 12, 2017 at 5:27 AM, Jens Axboe <ax...@kernel.dk> wrote: >> On 09/11/2017 03:13 PM, Mike Snitzer wrote: >>> On Mon, Sep 11 2017 at 4:51pm -0400, >>> Jens Axboe <ax...@kernel.dk> wrote: >>>

Re: [dm-devel] [PATCH] dm mpath: switch IO scheduler of underlying paths to "none" [was: Re: BFQ + dm-mpath]

this patch and reply with your review/feedback. > > Jens, if you're OK with this solution please reply with your Ack and > I'll send it to Linus along with the rest of the handful of DM changes I > have for 4.14. I am not - we used to have this elevator change functionality from inside the kernel, and finally got rid of it when certain drivers killed it. I don't want to be bringing it back. Sounds like we have two issues here. One is that we run into issues with stacking IO schedulers, and the other is that we'd rather not have multiple schedulers in play for a stacked setup. Maybe it'd be cleaner to have the dm-mq side of things not insert through the scheduler, but rather just FIFO on the target end? -- Jens Axboe -- dm-devel mailing list dm-devel@redhat.com https://www.redhat.com/mailman/listinfo/dm-devel

Re: [dm-devel] [PATCH] block: directly insert blk-mq request from blk_insert_cloned_request()

ruct request *rq) > +{ > + struct blk_mq_ctx *ctx = rq->mq_ctx; > + struct blk_mq_hw_ctx *hctx = blk_mq_map_queue(rq->q, ctx->cpu); > + > + blk_mq_queue_io(hctx, ctx, rq); > + blk_mq_run_hw_queue(hctx, false); > +} Would probably be cleaner as blk_mq_i

Re: [dm-devel] dm mpath: switch IO scheduler of underlying paths to "none" [was: Re: BFQ + dm-mpath]

On 09/08/2017 01:58 PM, Mike Snitzer wrote: > On Fri, Sep 08 2017 at 1:07pm -0400, > Mike Snitzer <snit...@redhat.com> wrote: > >> On Fri, Sep 08 2017 at 12:48pm -0400, >> Jens Axboe <ax...@kernel.dk> wrote: >> >>>> Please see the following unt

Re: [dm-devel] fix an integer overflow in __blkdev_sectors_to_bio_pages

blkdev_sectors_to_bio_pages if sector_t >> is 32-bit. >> >> Signed-off-by: Mikulas Patocka <mpato...@redhat.com> >> Fixes: 615d22a51c04 ("block: Fix __blkdev_issue_zeroout loop") >> >> --- >> block/blk-lib.c |4 ++-- >> 1 file changed, 2 insertions(+), 2 deletions(-) >> >> Index: linux-2.6/block/blk-lib.c >> === >> --- linux-2.6.orig/block/blk-lib.c >> +++ linux-2.6/block/blk-lib.c >> @@ -269,9 +269,9 @@ static int __blkdev_issue_write_zeroes(s >> */ >> static unsigned int __blkdev_sectors_to_bio_pages(sector_t nr_sects) >> { >> -sector_t bytes = (nr_sects << 9) + PAGE_SIZE - 1; >> +sector_t pages = DIV_ROUND_UP_SECTOR_T(nr_sects, PAGE_SIZE / 512); >> >> -return min(bytes >> PAGE_SHIFT, (sector_t)BIO_MAX_PAGES); >> +return min(pages, (sector_t)BIO_MAX_PAGES); >> } >> >> /** >> > > Jens can you pick this up? Yep added, thanks. -- Jens Axboe -- dm-devel mailing list dm-devel@redhat.com https://www.redhat.com/mailman/listinfo/dm-devel

Re: [dm-devel] [PATCH v2] block: directly insert blk-mq request from blk_insert_cloned_request()

On 09/11/2017 03:13 PM, Mike Snitzer wrote: > On Mon, Sep 11 2017 at 4:51pm -0400, > Jens Axboe <ax...@kernel.dk> wrote: > >> On 09/11/2017 10:16 AM, Mike Snitzer wrote: >>> Here is v2 that should obviate the need to rename blk_mq_insert_request >>> (by usi

Re: [dm-devel] [PATCH v2] block: directly insert blk-mq request from blk_insert_cloned_request()

s of whether the device has a scheduler attached or not. -- Jens Axboe -- dm-devel mailing list dm-devel@redhat.com https://www.redhat.com/mailman/listinfo/dm-devel

Re: [dm-devel] [PATCH v2] block: directly insert blk-mq request from blk_insert_cloned_request()

On 09/11/2017 04:30 PM, Mike Snitzer wrote: > On Mon, Sep 11 2017 at 5:51pm -0400, > Mike Snitzer <snit...@redhat.com> wrote: > >> On Mon, Sep 11 2017 at 5:27pm -0400, >> Jens Axboe <ax...@kernel.dk> wrote: >>> >>> Does the below work for y

Re: [dm-devel] [PATCH V6 4/5] blk-mq-sched: improve dispatching from sw queue

h blk-mq. We can improve this way in the future if we > have better approach. > > What do you think about it? I think it's absolutely horrible, and I already explained why in great detail in an earlier review. tldr is that the fact that only scsi sets ->queue_depth right now is completely randomly related to the fact that only scsi also shares tags. Every driver should set the queue depth, so that signal will go to zero very quickly. -- Jens Axboe -- dm-devel mailing list dm-devel@redhat.com https://www.redhat.com/mailman/listinfo/dm-devel

Re: [dm-devel] [PATCH V6 4/5] blk-mq-sched: improve dispatching from sw queue

hint at, if we do see a lot of requeueing or BUSY in the test case. That would prematurely move requests from the schedulers knowledge and into the hctx->dispatch holding area. It'd be useful to have a standard SATA test run and see if we're missing merging in that case (since merging is what it bo

Re: [dm-devel] [PATCH V6 4/5] blk-mq-sched: improve dispatching from sw queue

On 10/12/2017 09:22 AM, Ming Lei wrote: > On Thu, Oct 12, 2017 at 08:52:12AM -0600, Jens Axboe wrote: >> On 10/12/2017 04:01 AM, Ming Lei wrote: >>> On Tue, Oct 10, 2017 at 11:23:45AM -0700, Omar Sandoval wrote: >>>> On Mon, Oct 09, 2017 at 07:24:23PM +0800, Ming Lei

Re: [dm-devel] [PATCH] md: Convert timers to use timer_setup()

> On Oct 18, 2017, at 9:06 PM, Kees Cook wrote: > >> On Mon, Oct 16, 2017 at 8:06 PM, Michael Lyle wrote: >>> On 10/16/2017 05:01 PM, Kees Cook wrote: >>> In preparation for unconditionally passing the struct timer_list pointer to >>> all timer callbacks,

Re: [dm-devel] [PATCH] brd: remove unused brd_mutex

On 11/10/2017 10:29 AM, Mikulas Patocka wrote: > Remove unused mutex brd_mutex. It is unused since the commit ff26956875c2 > ("brd: remove support for BLKFLSBUF"). Thanks, applied. -- Jens Axboe -- dm-devel mailing list dm-devel@redhat.com https://www.redhat.com/mailman/listinfo/dm-devel

Re: [dm-devel] [PATCH] bio: have bio_kmap_irq return the size of mapped data (fwd)

On 11/08/2017 08:34 AM, Christoph Hellwig wrote: > On Wed, Nov 08, 2017 at 08:20:58AM -0700, Jens Axboe wrote: >> On top of that, there are no users of it at all... > > But Mikulas wants to add one :) I know... > Note that __bio_kmap_atomic has the same issues, only has a sin

Re: [dm-devel] [PATCH] bio: have bio_kmap_irq return the size of mapped data (fwd)

, iter), flags); -} -#define __bio_kunmap_irq(buf, flags) bvec_kunmap_irq(buf, flags) - -#define bio_kmap_irq(bio, flags) \ - __bio_kmap_irq((bio), (bio)->bi_iter, (flags)) -#define bio_kunmap_irq(buf,flags) __bio_kunmap_irq(buf, flags) - /* * BIO list management for use by remapp

Re: [dm-devel] md: Convert timers to use timer_setup()

On 10/24/2017 12:15 PM, Mike Snitzer wrote: > On Wed, Oct 18 2017 at 11:12pm -0400, > Jens Axboe <ax...@kernel.dk> wrote: > >> >>> On Oct 18, 2017, at 9:06 PM, Kees Cook <keesc...@chromium.org> wrote: >>> >>>> On Mon, Oct 16, 2017 at 8:0

Re: [dm-devel] next-20180605 - kernel tried to execute NX-protected page - exploit attempt?

two patches from Jens fixed the issue - this build has been > up for > 20 hours, and has survived a kernel build, an OpenWRT/Lede build, and a > backup, > along with a bunch of other stuff. Thanks for testing - I've sent the pull request to Linus, so hopefully it'll soon be f

Re: [dm-devel] [PATCH 0/3] Provide more fine grained control over multipathing

imes they prevent them from moving forward, since updates are now gated on external dependencies. Moving forward with a new architecture is great, but proper care has to be given to existing users of multipath, regardless of how few they may be. This patchset seems pretty clean and minimalist. Realisticall

Re: [dm-devel] [bisect BUG] dm-crypt percpu counter warnings and invalid kernel paging request at virtual address

[] (do_vfs_ioctl) from [] >> (ksys_ioctl+0x34/0x5c) >> [ 150.455994] [] (ksys_ioctl) from [] >> (ret_fast_syscall+0x0/0x28) >> >> --- >> >> Full log is here: >> https://krzk.eu/#/builders/1/builds/2117/steps/18/logs/serial0 >> >> Bisect could not work reliably because a lot of commits from Kent >> Overstreet just do not compile. Really, non-buildable stuff should not >> be committed... > > Sorry, I do compile test stuff but sometimes I screw up... > > I'll work on getting a test set up. Nevermind that for now, do you have a fix for the issue reported? -- Jens Axboe -- dm-devel mailing list dm-devel@redhat.com https://www.redhat.com/mailman/listinfo/dm-devel

Re: [dm-devel] [PATCH] dm-crypt: fix warning in shutdown path

On 6/2/18 11:45 AM, Kent Overstreet wrote: > The counter for the number of allocated pages includes pages in the > mempool's reserve, so checking that the number of allocated pages is 0 > needs to happen after we exit the mempool. Looks good, but needs a fixes line. I'll add one. -- J

  1   2   3   4   >