Re: [dm-devel] multipath-tools pull request

2021-04-01 Thread Christophe Varoqui
Thank you for this new process. The PR is merged and the version is tagged. On Tue, Mar 30, 2021 at 2:52 PM Martin Wilck wrote: > @All, > > I've created a pull request for multipath-tools: > https://github.com/opensvc/multipath-tools/pull/4 > > Please contact me if you find something wrong or

Re: [dm-devel] multipath-tools: NEW openSUSE github repo

2021-01-25 Thread Christophe Varoqui
I like it very much. I pulled "fixes" today. Thank you for this reorganization of the SuSE repo. Best regards, Christophe. On Mon, Jan 25, 2021 at 4:04 PM Martin Wilck wrote: > On Mon, 2021-01-11 at 12:42 -0600, Benjamin Marzinski wrote: > > On Mon, Jan 11, 2021 at 03:54:01PM +0100, Martin

Re: [dm-devel] Basic Github CI for multipath-tools

2020-12-19 Thread Christophe Varoqui
Sure, nice work. Would you like to create a PR, to merge it upstream ? So we can test if this process makes sense. Regards, Christophe On Sat, Dec 19, 2020 at 1:07 AM Martin Wilck wrote: > Hi Christophe, all, > > I have created a basic CI for multipath-tools on github: > >

Re: [dm-devel] uxsock_timeout default value in man page

2020-12-14 Thread Christophe Varoqui
nvestigate possible enhancements on this ? Christophe On Mon, Dec 14, 2020 at 10:39 AM Martin Wilck wrote: > On Mon, 2020-12-14 at 08:56 +0100, Christophe Varoqui wrote: > > Hello, > > > > a user brought to my attention "multipathd show config | grep > > usoc

[dm-devel] uxsock_timeout default value in man page

2020-12-14 Thread Christophe Varoqui
Hello, a user brought to my attention "multipathd show config | grep usock_timeout" does not agree with the default value stated in the manpage : 4000 instead of 1000. And indeed, ./libmpathcmd/mpath_cmd.h:#define DEFAULT_REPLY_TIMEOUT 4000 Can you confirm this change is valid ? diff --git

[dm-devel] multipath-tool 0.8.5 release

2020-11-12 Thread Christophe Varoqui
The multipath-tool 0.8.5 release is now available. Starting with this release, the project upstream git is now https://github.com/opensvc/multipath-tools This page shows the updated usage and contribution guidelines. The repository at https://git.opensvc.com is also at 0.8.5, but will no longer

[dm-devel] multipath-tools 0.8.4

2020-05-04 Thread Christophe Varoqui
Hi list, the 0.8.4 version is tagged. The backlog is merged up to Martin tests/ patchset from March 3rd (included). Best, Christophe. -- dm-devel mailing list dm-devel@redhat.com https://www.redhat.com/mailman/listinfo/dm-devel

Re: [dm-devel] [PATCH 0/4] multipath-tools unit test fixups

2020-04-29 Thread Christophe Varoqui
Hi Martin, Yes I did notice. I got sidetracked by other projects, but I intent to merge this patch and tag the release this week. Thank you for the notice, Christophe. On Tue, Apr 28, 2020 at 11:54 PM Martin Wilck wrote: > Hello Christophe, > > On Tue, 2020-03-03 at 00:38 +0100, C

Re: [dm-devel] multipath-tools merges

2020-03-07 Thread Christophe Varoqui
Thanks, the delta is committed with your authoring information. Best, Christophe On Fri, Mar 6, 2020 at 5:28 PM Martin Wilck wrote: > Hello Christophe, > > On Tue, 2020-03-03 at 00:35 +0100, Christophe Varoqui wrote: > > Hi Martin, > > > > Thanks for poi

Re: [dm-devel] [PATCH 0/4] multipath-tools unit test fixups

2020-03-02 Thread Christophe Varoqui
Ben, take the time you need for review, I'll wait for this patchset before tagging the next version. Best, Christophe. On Mon, Mar 2, 2020 at 11:20 PM wrote: > From: Martin Wilck > > Hi Christophe, hi Ben, > > as announced in my previous post, here's a set of minor fixups for the > unit

Re: [dm-devel] multipath-tools merges

2020-03-02 Thread Christophe Varoqui
Hi Martin, Thanks for pointing these missing patches. They are now merged. Best, Christophe. On Mon, Mar 2, 2020 at 10:51 PM Martin Wilck wrote: > Hi Christophe, > > On Mon, 2020-03-02 at 11:19 +0100, Christophe Varoqui wrote: > > Hi ben, Martin, > > > > I finally c

Re: [dm-devel] [PATCH resend] ALUA support for PURE FlashArray

2020-03-02 Thread Christophe Varoqui
ome Linux vendors don’t honor the block >limits VPD page of INQUIRY). > > Thanks, > Brian > > Cc: Christophe Varoqui > Cc: DM-DEVEL ML > Signed-off-by: Xose Vazquez Perez > Signed-off-by: Brian Bunker > --- > libmultipath/hwtable.c | 7 ++- > 1 fil

Re: [dm-devel] [PATCH resend] ALUA support for PURE FlashArray

2020-03-02 Thread Christophe Varoqui
ur FC NPIV port migration). > > 3. Maximum sector size of 4MB. Some Linux vendors don’t honor the block > > limits VPD page of INQUIRY). > > > > Thanks, > > Brian > > > > Cc: Christophe Varoqui > > Cc: DM-DEVEL ML > > Signed-off-by: Xose Vaz

[dm-devel] multipath-tools merges

2020-03-02 Thread Christophe Varoqui
Hi ben, Martin, I finally catched up with your changes from october till now. Please review I did not mess up the merges, then i'll commit a version bump. Thanks, Christophe. -- dm-devel mailing list dm-devel@redhat.com https://www.redhat.com/mailman/listinfo/dm-devel

Re: [dm-devel] [multipath-tools] merges

2019-10-02 Thread Christophe Varoqui
Done. Thank you. On Wed, Oct 2, 2019 at 2:56 PM Xose Vazquez Perez wrote: > Hi Christophe, > > 0.8.3 is not tagged: > https://git.opensvc.com/?p=multipath-tools/.git;a=tags > > > Thanks. > -- dm-devel mailing list dm-devel@redhat.com https://www.redhat.com/mailman/listinfo/dm-devel

[dm-devel] [multipath-tools] merges

2019-10-01 Thread Christophe Varoqui
Hi, I merged the patchsets posted and reviewed in past months. Here are the remaining sets needing rebase: * Martin's "enable_foreign" patchset from aug 15 * Chongyun's "san_path_err" optimization patchset from aug 27 I'll bump the version after merging these missing patchs. Petr, do you

Re: [dm-devel] [PATCH] kpartx: recognize DASD on loop devices again

2019-07-08 Thread Christophe Varoqui
Thanks for the review. Martin, can you post a rebased version of this patch ? Thanks, Christophe On Mon, Jul 8, 2019 at 4:27 PM Benjamin Marzinski wrote: > On Fri, Jun 28, 2019 at 07:29:41PM +, Martin Wilck wrote: > > From: Martin Wilck > > > > Since 4d57b868, DASD partition tables are

Re: [dm-devel] [PATCH 0/1] update to v2 Fix false removes

2018-12-11 Thread Christophe Varoqui
FYI, I did receive the v2 patch and wrapping message. Thanks Le mer. 12 déc. 2018 à 00:47, Benjamin Marzinski a écrit : > On Tue, Dec 11, 2018 at 03:23:03PM -0600, Benjamin Marzinski wrote: > > I accidentally didn't include Christophe in my > > > > [PATCH v2 0/1] Fix false removes > >

Re: [dm-devel] [PATCH v2 00/24] multipath-tools: improve logging at -v3

2018-12-07 Thread Christophe Varoqui
Hi Martin, pending patches, except the logging refactoring patchset, are merged. When you'll be ready to send the v3 of this patchset, please send the full set : some of the reviewed v1 patches are missing in my mailbox. Thanks, Christophe On Tue, Dec 4, 2018 at 12:50 AM Benjamin Marzinski

Re: [dm-devel] multipath-tools: Bump version to 0.7.9

2018-11-14 Thread Christophe Varoqui
This commit is now tagged. Thanks. On Wed, Nov 14, 2018 at 7:45 PM Xose Vazquez Perez wrote: > Christophe Varoqui wrote: > > > > https://git.opensvc.com/gitweb.cgi?p=multipath-tools/.git;a=commitdiff;h=5c67a8b5944dd13542e6b44fa2ae9803e0cc4282 > > Untagged: https://git.ope

Re: [dm-devel] [PATCH 0/2] two multipathd fixes

2018-11-14 Thread Christophe Varoqui
Merged. Thanks. On Tue, Nov 13, 2018 at 10:31 PM Martin Wilck wrote: > Hi Christophe, > > Two small fixes, based on my prior submissions which have been > acked by Ben. > > Martin > > Martin Wilck (2): > multipathd: fix irritating "minor number mismatch" message > multipathd: reset

Re: [dm-devel] [PATCH v3 0/7] multipathd: make uxlsnr errors really fatal

2018-11-13 Thread Christophe Varoqui
Merged. Thanks. On Fri, Nov 2, 2018 at 1:24 PM Martin Wilck wrote: > Hi Christophe, > > this series, based on top of the recently submitted > "various multipath-tools patches (v2)" and "checkers overhaul (v3)" > series, fixes a problem that I recently observed: despite > ee01e841 "multipathd:

Re: [dm-devel] [PATCH v5 00/21] libmultipath: checkers overhaul

2018-11-13 Thread Christophe Varoqui
Merged. Thanks. On Fri, Nov 2, 2018 at 1:23 PM Martin Wilck wrote: > Hi Christophe, > > This is v5 of my "checkers overhaul" series. Changed wrt v4 > are 03/22, 11/22, and 21/22. I re-post the whole series to > avoid confusion. > > This series starts with a few minor fixes and then attempts >

Re: [dm-devel] [PATCH v2 00/10] various multipath-tools patches

2018-11-13 Thread Christophe Varoqui
Merged. Thanks. On Tue, Oct 23, 2018 at 3:44 PM Martin Wilck wrote: > This is v2 of my series from Oct. 10; starting from 7 as the > other patches have already been merged. > > Changes wrt v2: > 7/10: handle failure of libcheck_init() (Ben). I decided not to > return PATH_TIMEOUT in

Re: [dm-devel] [PATCH 0/8] various multipath-tools patches

2018-10-13 Thread Christophe Varoqui
Martin, The 01 to 06 patchs of this set are now merged. Thanks, Christophe. On Wed, Oct 10, 2018 at 10:05 PM Martin Wilck wrote: > Hi Christophe, > > this series contains some patches I had on my list for > some time, plus some stuff that came up during the discussion > about Ben's last

Re: [dm-devel] [PATCH 0/1] Fix kpart -d regression where matching devices not found

2018-10-09 Thread Christophe Varoqui
Hi Steph, Xose, I have this patch in the queue, no worry. pending a "reviewed-by" though. Best regards, Christophe. On Tue, Oct 9, 2018 at 2:38 PM Xose Vazquez Perez wrote: > Stef Walter wrote: > > You should send(CC:) it also to Christophe. > > > The Lorax project found a regression in

Re: [dm-devel] [PATCH v3 00/19] Misc Multipath patches

2018-10-07 Thread Christophe Varoqui
Hi Ben, this v3 patchset is ready for merge or do you plan a v4 ? Thanks, Christophe On Sat, Sep 22, 2018 at 1:05 AM Benjamin Marzinski wrote: > This batch of patches is a resend of the non-merged pathes from my last > set, along with 2 new ones. It would be really great if we could get > a

Re: [dm-devel] [PATCH 00/32] Misc Multipath patches

2018-08-07 Thread Christophe Varoqui
Hi, The backlog is merged, mostly. Ben, your latest aggregated patchset is merged up to 15/32 included, pending consensus about tur locking with Bart. Would you rather have a release tag at this point or can it wait the merge of your pending patches ? Thanks, Christophe. On Wed, Aug 1, 2018

Re: [dm-devel] [PATCH] multipathd: fix mpp->hwe handling on path removal

2018-07-02 Thread Christophe Varoqui
Right, done. The leftover from your previous v3 patchset is merged too. Thanks, Christophe. On Mon, Jul 2, 2018 at 11:33 AM Martin Wilck wrote: > Christophe, > > without this patch, current upstream multipath _crashes_ on path > removal. Please apply it. If reviewers disagree with this fix, I

Re: [dm-devel] Latest multipath-tools push

2018-06-29 Thread Christophe Varoqui
I expect a new merge the 3rd week of july, then a new tag. Le ven. 29 juin 2018 à 14:36, Martin Wilck a écrit : > Hi Christophe, > > On Fri, 2018-06-29 at 04:37 +0200, Christophe Varoqui wrote: > > Thanks for pointing out the missed patch. > > It is now merged. >

Re: [dm-devel] Latest multipath-tools push

2018-06-28 Thread Christophe Varoqui
Thanks for pointing out the missed patch. It is now merged. Sorry I did not communicate enough on the last merge ... I was in a pre-vacation rush to empty the patch queue. On Sun, Jun 24, 2018 at 9:01 PM Martin Wilck wrote: > Hello Christophe, > > Sorry, I've missed your last push. I'll

Re: [dm-devel] [PATCH] multipath-tools: fix help for hds prio

2018-06-21 Thread Christophe Varoqui
Done, thanks. On Thu, Jun 21, 2018 at 10:59 AM Xose Vazquez Perez wrote: > Hi Christophe, > > This one is missing. > > Thank you. > > On 05/21/2018 10:03 PM, Xose Vazquez Perez wrote: > > Cc: Christophe Varoqui > > Cc: DM-DEV ML > > Signed-off-by: Xos

Re: [dm-devel] [release] multipath-tools 0.7.7

2018-05-15 Thread Christophe Varoqui
Martin, Xose, Those patches are now merged. Thanks for the notification. On Tue, May 15, 2018 at 12:10 PM, Martin Wilck <martin.wi...@suse.com> wrote: > Hello Christophe, > > Christophe Varoqui <christophe.varo...@opensvc.com> wrote on 05/11/18 > 10:57 AM: > >

Re: [dm-devel] [PATCH] libmultipath: fix error parsing "find_multipaths strict"

2018-05-15 Thread Christophe Varoqui
Merged, thanks. On Tue, May 15, 2018 at 2:32 PM, Martin Wilck wrote: > If "find_multipaths strict" is set in multipath.conf, the error message > "illegal value for find_multipaths: strict" is printed. This causes no > functional problem, as "strict" happens to be the default,

Re: [dm-devel] [PATCH] multipath-tools: configure hitachi ams2000 and hus100 as full active arrays

2018-05-15 Thread Christophe Varoqui
; > Cc: Matthias Rudolph <matthias.rudo...@hitachivantara.com> > Cc: Christophe Varoqui <christophe.varo...@opensvc.com> > Cc: DM-DEV ML <dm-devel@redhat.com> > Signed-off-by: Xose Vazquez Perez <xose.vazq...@gmail.com> > --- > libmultipath/hwtable.c | 10 --

Re: [dm-devel] [release] multipath-tools 0.7.7

2018-05-11 Thread Christophe Varoqui
Thanks, the tag is now pushed. and the first 3 patches are merged. you can rebase the last one. Best regards, Christophe. On Fri, May 11, 2018 at 1:37 PM, Xose Vazquez Perez <xose.vazq...@gmail.com> wrote: > Christophe Varoqui wrote: > > > I merged the reviewed patches

[dm-devel] [release] multipath-tools 0.7.7

2018-05-11 Thread Christophe Varoqui
Hi, I merged the reviewed patches from March 27th up to now, and released 0.7.7. Thanks, Christophe. -- dm-devel mailing list dm-devel@redhat.com https://www.redhat.com/mailman/listinfo/dm-devel

Re: [dm-devel] [PATCH 1/2] multipath-tools: move COPYING to COPYING.LESSER

2018-04-09 Thread Christophe Varoqui
Martin is right, the LGPL COPYING was added Sun May 1 15:05:22 2005. Every file added to the tree since then and up to Xose patch switching COPYING to GPL, and not explicitely licensed otherwise can be assumed to be covered by the LGPL. It was not intended to relicense any files, nor switch to GPL

Re: [dm-devel] [PATCH 0/4] multipath-tools: important fixes for 0.7.5

2018-03-27 Thread Christophe Varoqui
> > Am Samstag, den 10.03.2018, 08:43 +0100 schrieb Christophe Varoqui: > > The fixes and missing patches series are now merged. > > The version is bumped to 0.7.6. > > could you please create a tag for 0.7.6? Or is it not officially > released yet? > > Cheers,

Re: [dm-devel] [PATCH 0/4] multipath-tools: important fixes for 0.7.5

2018-03-09 Thread Christophe Varoqui
The fixes and missing patches series are now merged. The version is bumped to 0.7.6. Thanks, Christophe. On Thu, Mar 8, 2018 at 5:04 PM, Xose Vazquez Perez wrote: > On 03/08/2018 12:08 AM, Martin Wilck wrote: > > Hi Christophe, > > > > thanks for catching up. This

Re: [dm-devel] [PATCH] multipath-tools: add info about how to get a release directly from gitweb

2018-03-07 Thread Christophe Varoqui
Thanks, applied. On Wed, Mar 7, 2018 at 2:28 PM, Xose Vazquez Perez <xose.vazq...@gmail.com> wrote: > On 01/12/2018 05:56 PM, Xose Vazquez Perez wrote: > > > gitweb is able to extract and serve a release right away. > > This one is missing. > > > Cc: Ch

Re: [dm-devel] [PATCH 0/6] Various multipath-tools patches

2018-03-07 Thread Christophe Varoqui
Hi Bart, I've finally merged the queued patches, so you can rebase this patchset over the new head. Thanks. On Tue, Mar 6, 2018 at 4:25 PM, Benjamin Marzinski wrote: > On Thu, Mar 01, 2018 at 11:29:29AM -0800, Bart Van Assche wrote: > > Hello Christophe, > > > > This

Re: [dm-devel] [RFC PATCH 00/16] multipath path classification

2018-03-07 Thread Christophe Varoqui
Martin, Ben, can you update me on the status of this patchset ? Is it ready for inclusion ? Thanks, Christophe On Fri, Jan 19, 2018 at 1:29 AM, Martin Wilck wrote: > This patch series implements the recommendation in my recent posting > "Multipath path classification

Re: [dm-devel] [PATCH 2/2] libmultipath: don't update path queueing on reload

2018-01-13 Thread Christophe Varoqui
Applied. Thanks On Mon, Dec 18, 2017 at 2:49 PM, Martin Wilck wrote: > On Wed, 2017-12-13 at 12:08 -0600, Benjamin Marzinski wrote: > > With the fix to the features handling code, the multipath device > > should > > already be reloaded with the correct value for

Re: [dm-devel] [PATCH 00/12] Misc fixes

2018-01-13 Thread Christophe Varoqui
Applied. Thanks. On Thu, Dec 7, 2017 at 7:48 PM, Benjamin Marzinski wrote: > The first patch here is just a rebased version of an earlier patch. The > last > patch is fixes for commit 95d594fd6f031e59bb73d04a631b6c592fe26214 > "multipath-tools: intermittent IO error

Re: [dm-devel] [PATCH] multipath-tools: check null path before handle path-failed event

2018-01-13 Thread Christophe Varoqui
Merged. Thanks. On Mon, Dec 4, 2017 at 2:15 PM, Guan Junxiong wrote: > In the hot-plug storage OS, if we tear down the target storage, > there is a race between the path removing from the path list and > handling the path-failed udev event. Therefore, we need to check >

Re: [dm-devel] [PATCH v2] multipath-tools: output more topology info for NVMe discovery

2018-01-13 Thread Christophe Varoqui
Merged. Thanks. On Mon, Dec 4, 2017 at 2:13 PM, Guan Junxiong wrote: > From: Jie Yang > > Assign sg_id.channel to controller id of the NVMe/NVMf target > and assign sg_id.lun to namespace ID of the target. > > Signed-off-by: Jie Yang

Re: [dm-devel] [PATCH 0/4] multipath-tools: libdmmp improvements.

2018-01-13 Thread Christophe Varoqui
Merged. Thanks. On Tue, Nov 21, 2017 at 3:09 PM, Gris Ge wrote: > * Patch 1/4 is a resend. > * Patch 2/4, 3/4, and 4/4 add new functions to libdmmp library. > > Gris Ge (4): > multipathd daemon: Fix incorrect use of CLOCK_MONOTONIC in pthread > multipath-tools: libdmmp:

Re: [dm-devel] [PATCH] multipath-tools: refresh kernel-doc from kernel sources

2018-01-13 Thread Christophe Varoqui
Applied. Thanks. On Fri, Nov 17, 2017 at 5:54 PM, Xose Vazquez Perez <xose.vazq...@gmail.com> wrote: > Cc: Gris Ge <f...@redhat.com> > Cc: Christophe Varoqui <christophe.varo...@opensvc.com> > Cc: device-mapper development <dm-devel@redhat.com> > Signed-o

Re: [dm-devel] [PATCH v2] multipath-tools: add README.alua with instructions to enable ALUA

2018-01-13 Thread Christophe Varoqui
Applied, Thanks. On Tue, Nov 21, 2017 at 7:52 PM, Xose Vazquez Perez <xose.vazq...@gmail.com> wrote: > ALUA is supported in some storage devices, but usually it's disabled by > default. > > Cc: NetApp RDAC team <ng-eseries-upstream-maintain...@netapp.com>

Re: [dm-devel] [PATCH 0/3] Three multipath-tools source code cleanup patches

2018-01-13 Thread Christophe Varoqui
Applied, Thanks. On Tue, Dec 12, 2017 at 1:45 AM, Bart Van Assche wrote: > Hello Christophe, > > The three patches in this series make it easier to compile the > multipath-tools > source code with sparse and address two issues discovered by sparse. Please > consider

Re: [dm-devel] [PATCH] multipath-tools: replace RDAC maintainer with a generic alias

2017-11-15 Thread Christophe Varoqui
art <sean.stew...@netapp.com> > > Cc: NetApp RDAC team <ng-eseries-upstream-maintain...@netapp.com> > > Cc: Christophe Varoqui <christophe.varo...@opensvc.com> > > Cc: device-mapper development <dm-devel@redhat.com> > > Signed-off-by: Xose Vazquez Perez <x

[dm-devel] multipath-tools 0.7.4

2017-11-15 Thread Christophe Varoqui
x doc typo Christophe Varoqui (1): Bump version to 0.7.4 Guan Junxiong (6): multipath-tools: intermittent IO error accounting to improve reliability multipath-tools: discard san_path_err_XXX feature multipath-tools: use direct IO for path latency prioritizer multipath-t

Re: [dm-devel] [PATCH 6/6] multipath: add "ghost_delay" parameter

2017-11-15 Thread Christophe Varoqui
Hi Ben, the patchset is merged until this patch. Can you consider rebasing it ? Thanks, Christophe. On Wed, Nov 8, 2017 at 1:15 AM, Benjamin Marzinski wrote: > If the lower-priority passive paths for a multipath device appear first, > IO can go to them and cause the

Re: [dm-devel] [PATCH 2/2] multipath-tools: output more topology info for NVMe discovery

2017-11-15 Thread Christophe Varoqui
Hi, this patch seems to be orphaned from its patchset. Do you maintain your request for inclusion ? Thanks. On Thu, Oct 12, 2017 at 9:35 AM, y00378701 wrote: > Assign sg_id.channel to controller id of the NVMe/NVMf target > and assign sg_id.lun to namespace ID of the

[dm-devel] multipath-tools 0.7.3

2017-09-20 Thread Christophe Varoqui
mpathpersist: add support for prkeys file Christophe Varoqui (1): Bump version to 0.7.3 Gris Ge (3): multipath-tools: Remove the limitation of IPC command reply length. multipath-tools: libdmmp: Improve timeout mechanism multipath-tools: libdmmp: New function to flush

Re: [dm-devel] multipath-tools 0.7.3

2017-09-20 Thread Christophe Varoqui
multipath: add alternate reservation_key method mpathpersist: add support for prkeys file Christophe Varoqui (1): Bump version to 0.7.3 Gris Ge (3): multipath-tools: Remove the limitation of IPC command reply length. multipath-tools: libdmmp: Improve timeout mechanism

Re: [dm-devel] [PATCH] libmultipath: update 3PARdata builtin config

2017-08-05 Thread Christophe Varoqui
And done. On Sat, Aug 5, 2017 at 1:23 PM, Xose Vazquez Perez <xose.vazq...@gmail.com> wrote: > Christophe Varoqui wrote: > > > (And version bumped to 0.7.2) > > untagged: https://git.opensvc.com/gitweb.cgi?p=multipath-tools/.git;a=tags > -- dm-devel mailing lis

Re: [dm-devel] [PATCH] libmultipath: update 3PARdata builtin config

2017-08-05 Thread Christophe Varoqui
Merged, Thanks. (And version bumped to 0.7.2) On Mon, Jun 26, 2017 at 9:03 PM, Benjamin Marzinski wrote: > This updated config comes from hp. > > Signed-off-by: Benjamin Marzinski > --- > libmultipath/hwtable.c | 2 ++ > 1 file changed, 2

Re: [dm-devel] [PATCH] multipath-tools: beautify path_latency.c code

2017-08-05 Thread Christophe Varoqui
ultipath/prioritizers/path_latency.c source file. So please proceed > with merging Xose's patch. > > Bart. > > On Fri, 2017-08-04 at 19:18 +0200, Christophe Varoqui wrote: > > Bart, > > Do you have pending patches on this file you'd like to submit before I > merge this l'i

Re: [dm-devel] [PATCH] multipath-tools: beautify path_latency.c code

2017-08-04 Thread Christophe Varoqui
> Mainly running scripts/Lindent, from kernel dir, to replace indent spaces > > by tabs. > > Patch missing in last merge. > > > Cc: Yang Feng <philip.y...@huawei.com> > > Cc: Christophe Varoqui <christophe.varo...@opensvc.com> > > Cc: device-mappe

Re: [dm-devel] [PATCH] multipath-tools: check sysfs path state for NVMe/NVMf

2017-08-03 Thread Christophe Varoqui
Merged. Thanks. On Fri, Jul 28, 2017 at 8:54 AM, Guan Junxiong wrote: > Hi Hannes, > > On 2017/7/28 14:12, Hannes Reinecke wrote: > > On 07/28/2017 03:28 AM, Guan Junxiong wrote: > >> The previous code of path_offline checking was only valid for SCSI > >> device. It

Re: [dm-devel] [PATCH] multipath-tools: sync third-party headers with 3.13 upstream

2017-08-03 Thread Christophe Varoqui
Merged. Thanks. On Wed, Jun 21, 2017 at 5:14 PM, Bart Van Assche <bart.vanass...@wdc.com> wrote: > On Wed, 2017-06-21 at 14:26 +0200, Xose Vazquez Perez wrote: > > Cc: Bart Van Assche <bart.vanass...@sandisk.com> > > Cc: Christophe Varoqui <christophe.varo...@open

Re: [dm-devel] [PATCH v2 0/4] libmultipath: Fixes for NVME / NVMEoF

2017-08-03 Thread Christophe Varoqui
This set is now merged. Thanks. On Tue, Jul 18, 2017 at 9:29 AM, Martin Wilck wrote: > Current code fails to set up multipath maps for NVME devices in a > Linux target/Linux host combination. This series enables at least > basic operation. > > Patch 1/4 fixes a crash that

Re: [dm-devel] [PATCH] kpartx.rules: Fix syntax error in skip_kpartx code

2017-08-03 Thread Christophe Varoqui
Merged. Thanks. On Fri, Jun 23, 2017 at 11:57 PM, Martin Wilck wrote: > Fixes: 22736419 "kpartx.rules: respect skip_kpartx flag" > Signed-off-by: Martin Wilck > --- > kpartx/kpartx.rules | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git

Re: [dm-devel] [PATCH v4 00/11] multipath-tools: no_path_retry/queue_if_no_path/hwhandler logic

2017-08-03 Thread Christophe Varoqui
Patch 1 to 9 are now merged. On Thu, Jun 22, 2017 at 4:59 PM, Martin Wilck wrote: > This patch set attempts to sanitize the logic used for consistently > handling > options that can be set both via the "features" string and explicit > multipath.conf > options. This is most

Re: [dm-devel] [PATCH] multipath-tools: delete libdmmp/docs/man directory in make clean

2017-08-03 Thread Christophe Varoqui
Merged. Thanks. On Sat, Jun 24, 2017 at 8:06 PM, Xose Vazquez Perez <xose.vazq...@gmail.com> wrote: > CC: Gris Ge <f...@redhat.com> > Cc: Christophe Varoqui <christophe.varo...@opensvc.com> > Cc: device-mapper development <dm-devel@redhat.com> > Signed-o

Re: [dm-devel] [PATCH] multipath-tools: move up TEMPLATE in hwtable

2017-08-03 Thread Christophe Varoqui
Merged. Thanks. On Fri, Jun 23, 2017 at 11:13 PM, Xose Vazquez Perez <xose.vazq...@gmail.com > wrote: > and the 'MD Series' comment to the right place. > > Cc: Christophe Varoqui <christophe.varo...@opensvc.com> > Cc: device-mapper development <dm-devel@redhat.com>

Re: [dm-devel] [PATCH] multipath-tools: add HPE StoreVirtual 3200 family to hwtable

2017-08-03 Thread Christophe Varoqui
Merged. Thanks. On Fri, Jul 7, 2017 at 3:55 PM, Xose Vazquez Perez <xose.vazq...@gmail.com> wrote: > It's a new LEFTHAND array. > > Cc: Christophe Varoqui <christophe.varo...@opensvc.com> > Cc: device-mapper development <dm-devel@redhat.com> > Signed-off-

Re: [dm-devel] [PATCH] libmultipath: fix unit to seconds in log message for checker timeout

2017-08-03 Thread Christophe Varoqui
Merged, Thanks. On Tue, Jun 27, 2017 at 5:11 PM, Martin Wilck wrote: > checker_timeout is in seconds, not milliseconds, since 905281da > "Specify checker_timeout in seconds". Fix the log messages. > > Signed-off-by: Martin Wilck > --- > libmultipath/propsel.c

Re: [dm-devel] [PATCH] multipath-tools: Replace multipath configuration output

2017-06-21 Thread Christophe Varoqui
Merged, Thanks. On Thu, May 18, 2017 at 2:06 AM, Xose Vazquez Perez <xose.vazq...@gmail.com> wrote: > On 04/18/2017 02:07 AM, Xose Vazquez Perez wrote: > > > Cc: Christophe Varoqui <christophe.varo...@opensvc.com> > > Cc: device-mapper development <dm-devel@re

Re: [dm-devel] [PATCH] multipath-tools: enable libdmmp installation in alternative directory

2017-06-21 Thread Christophe Varoqui
Merged, Thanks. On Thu, May 18, 2017 at 7:05 PM, Benjamin Marzinski wrote: > On Mon, May 15, 2017 at 10:33:25PM +0200, Martin Wilck wrote: > > Fine by me. > > -Ben > > > Introduce a new Makefile variable, usr_prefix, to be used for > > libdmmp and the associated pkgconfig

Re: [dm-devel] [PATCH] multipath-tools: delete vendor name HUASY for Huawei devices

2017-06-21 Thread Christophe Varoqui
And now merged. Thanks. On Sat, May 20, 2017 at 12:31 PM, Christophe Varoqui < christophe.varo...@opensvc.com> wrote: > Thanks for the clarification. > > On Sat, May 20, 2017 at 11:17 AM, Zouming (IT) <zouming.zoum...@huawei.com > > wrote: > >> Hi christophe: >

Re: [dm-devel] [PATCH] multipath-tools: replace hidden tabs by spaces in .vendor

2017-06-21 Thread Christophe Varoqui
Merged, Thanks. On Sat, May 20, 2017 at 3:29 PM, Xose Vazquez Perez <xose.vazq...@gmail.com> wrote: > Cc: Christophe Varoqui <christophe.varo...@opensvc.com> > Cc: device-mapper development <dm-devel@redhat.com> > Signed-off-by: Xose Vazquez Perez <xose.vazq...@gm

Re: [dm-devel] [PATCH] multipath-tools: fix a format warning in multipathd.8

2017-06-21 Thread Christophe Varoqui
Merged, Thanks. On Fri, May 26, 2017 at 6:19 PM, Xose Vazquez Perez <xose.vazq...@gmail.com> wrote: > warning: macro `list' not defined > > Cc: Christophe Varoqui <christophe.varo...@opensvc.com> > Cc: device-mapper development <dm-devel@redhat.com> > Signed-off-

Re: [dm-devel] [PATCH] mpathpersist.8: add missing documentation for -K, -C, -l

2017-06-21 Thread Christophe Varoqui
Merged, Thanks. On Wed, Jun 21, 2017 at 12:43 AM, Benjamin Marzinski wrote: > On Tue, May 23, 2017 at 12:16:43AM +0200, Martin Wilck wrote: > > ACK > > -Ben > > > Furthermore, add a reference to the sg_persist man page. > > --- > > mpathpersist/mpathpersist.8 | 21

Re: [dm-devel] [PATCH] libmpathpersist: use extern struct udev from main program

2017-06-21 Thread Christophe Varoqui
Merged. Thanks. On Wed, Jun 21, 2017 at 12:03 AM, Benjamin Marzinski wrote: > On Sun, Mar 26, 2017 at 03:49:47PM +0200, Martin Wilck wrote: > > Use the global variable "udev" - the internal one is not > > initialized, causing current libudev calls to fail. > > In the main

Re: [dm-devel] [PATCH v6 1/1] multipath-tools: Prioritizer based on a latency algorithm

2017-06-21 Thread Christophe Varoqui
This version is now merged. Thanks. Incremental enhancements can go from there if needed. On Wed, Jun 21, 2017 at 11:40 AM, Yang Feng wrote: > libmultipath/prioritizers: Prioritizer for device mapper multipath, > where the corresponding priority values of specific paths

Re: [dm-devel] [PATCH] multipath-tools: delete vendor name HUASY for Huawei devices

2017-05-20 Thread Christophe Varoqui
> Zou Ming. > > On 2017/5/20 17:02, Christophe Varoqui wrote: > > Hi, > > > > question is, is there arrays in the wild exposing this vendor name ? > > If so, we'll rather keep its defaults for the decade to come. > > > > Best regards, > > C

Re: [dm-devel] [PATCH] multipath-tools: delete vendor name HUASY for Huawei devices

2017-05-20 Thread Christophe Varoqui
Hi, question is, is there arrays in the wild exposing this vendor name ? If so, we'll rather keep its defaults for the decade to come. Best regards, Christophe. On Sat, May 20, 2017 at 10:27 AM, Zou Ming wrote: > For product XSG1,HUASY is obsolete for Huawei

Re: [dm-devel] [PATCH 0/6] small multipath fixes

2017-05-17 Thread Christophe Varoqui
This set is merged. Thanks. On Tue, May 9, 2017 at 6:56 PM, Benjamin Marzinski wrote: > Here are a number of small multipath fixes. These patches are based on > top of my and Martin's previous patch sets. > > Benjamin Marzinski (6): > libmultipath: print alias with

Re: [dm-devel] [PATCH] mpathpersist: fix one more crash possiblity

2017-05-17 Thread Christophe Varoqui
Merged. Thanks. On Sat, May 13, 2017 at 7:44 AM, Benjamin Marzinski wrote: > when mpathpersist goes to rollback reservations, it doesn't do a > rollback (and thus doesn't create a pthread) on paths that didn't > successfully create a reservation in the first place. It also

Re: [dm-devel] [PATCH v2 0/2] Small multipath fixes

2017-05-17 Thread Christophe Varoqui
v2 of this set is merged. Thanks. On Wed, May 17, 2017 at 5:24 PM, Martin Wilck wrote: > Two minor fixes that I found necessary recently. > > Both touch potentially bigger issues - the first one print.c, which > might need some general overhaul at some time in the future, and

Re: [dm-devel] [PATCH v2 00/12] fixes for kpartx -d

2017-05-17 Thread Christophe Varoqui
The set is merged, thanks. On Wed, May 17, 2017 at 7:06 PM, Benjamin Marzinski wrote: > On Mon, May 15, 2017 at 05:37:10PM +0200, Martin Wilck wrote: > > ACK for the set > > -Ben > > > Working on a bug report about kpartx not properly removing > > partitions for loop

Re: [dm-devel] [PATCH 6/7] kpartx: Fix a compiler warning

2017-05-17 Thread Christophe Varoqui
This patch is dropped, due to Martin's 8b9cda51f5c64bc869188ca0b2e1ac0e7eb7c667 patch switching to sys/sysmacros.h Otherwise, the rest of the set is now merged. Thanks. On Wed, May 17, 2017 at 5:43 PM, Bart Van Assche wrote: > Avoid that building against glibc >=

Re: [dm-devel] [PATCH 0/1] Missing RDAC patch

2017-04-14 Thread Christophe Varoqui
Merged, and version bumped to 0.7.1 The tags are now pushed too. On Fri, Apr 14, 2017 at 1:52 AM, Xose Vazquez Perez wrote: > On 04/13/2017 05:39 PM, Martin Wilck wrote: > > > I'm sending this on Hannes' behalf now. Sorry we didn't make it for > 0.7.0. > > You're lucky,

Re: [dm-devel] [PATCH] multipath-tools: replace multipath configuration output

2017-04-14 Thread Christophe Varoqui
Right, pushed now. Thanks, Christophe. On Fri, Apr 14, 2017 at 1:56 AM, Xose Vazquez Perez <xose.vazq...@gmail.com> wrote: > On 04/12/2017 09:35 AM, Christophe Varoqui wrote: > > > Merged, > > No, it's missing. > > > On Sat, Apr 8, 2017 at 3:30 PM, Xose Vazquez

Re: [dm-devel] [PATCH 00/33] multipath-tools fixes from SUSE

2017-04-12 Thread Christophe Varoqui
Hi Martin, The multipath tools version is now bumped to 0.7.0. Best regards, Christophe On Fri, Mar 24, 2017 at 8:44 AM, Martin Wilck <mwi...@suse.com> wrote: > On Thu, 2017-03-23 at 09:30 +0100, Christophe Varoqui wrote: > > The full set is now merged. > > Thanks. > &g

Re: [dm-devel] [PATCH] multipath-tools: replace multipath configuration output

2017-04-12 Thread Christophe Varoqui
Merged, thanks. On Sat, Apr 8, 2017 at 3:30 PM, Xose Vazquez Perez <xose.vazq...@gmail.com> wrote: > Cc: Christophe Varoqui <christophe.varo...@opensvc.com> > Cc: device-mapper development <dm-devel@redhat.com> > Signed-off-by: Xose Vazquez Perez <xose.vazq...@gm

Re: [dm-devel] [PATCH 0/9] misc cleanups and bugfixes

2017-04-12 Thread Christophe Varoqui
Merged, thanks. On Fri, Apr 7, 2017 at 8:16 AM, Benjamin Marzinski wrote: > These patches are all just small cleanup and bugfixes. > > Benjamin Marzinski (9): > libdmmp: minor Makefile cleanup > multipath-tools: remove incdir from Makefiles > libdmmp: don't disconnect

Re: [dm-devel] [PATCH] multipath-tools: arrange compilation options for binaries

2017-03-23 Thread Christophe Varoqui
And reverted: >From http://eli.thegreenplace.net/2013/07/09/library-order-in-static-linking : If object or library AA needs a symbol from library BB, then AA should come *before* library BB in the command-line invocation of the linker. On Thu, Mar 23, 2017 at 9:34 AM, Christophe Varo

Re: [dm-devel] [PATCH] multipath-tools: arrange compilation options for shared libs/objects

2017-03-23 Thread Christophe Varoqui
Merged, Thanks. On Sat, Mar 18, 2017 at 6:45 PM, Xose Vazquez Perez <xose.vazq...@gmail.com> wrote: > Cc: Christophe Varoqui <christophe.varo...@opensvc.com> > Cc: device-mapper development <dm-devel@redhat.com> > Signed-off-by: Xose Vazquez Perez <xose.vazq.

Re: [dm-devel] [PATCH] multipath-tools: arrange compilation options for binaries

2017-03-23 Thread Christophe Varoqui
Merged, Thanks. On Fri, Mar 17, 2017 at 11:40 PM, Xose Vazquez Perez <xose.vazq...@gmail.com > wrote: > Cc: Christophe Varoqui <christophe.varo...@opensvc.com> > Cc: device-mapper development <dm-devel@redhat.com> > Signed-off-by: Xose Vazquez Perez <xose.vazq

Re: [dm-devel] [PATCH] multipath-tools: build objects for libdmmp and libmpathpersist independently

2017-03-23 Thread Christophe Varoqui
dmmp_path.c > cc -O2 -g -pipe -Wall -Wextra -Wformat=2 -Werror=implicit-int > -Werror=implicit-function-declaration -Werror=format-security > -Wno-sign-compare -Wno-unused-parameter -Wno-clobbered > -Wp,-D_FORTIFY_SOURCE=2 -fstack-protector-strong --param=ssp-buffer-size=4 > -fPIC -DLIB

Re: [dm-devel] [PATCH] multipath-tools: add missing "-l" flag for pthread in libdmmp/Makefile

2017-03-23 Thread Christophe Varoqui
Applied. Thanks On Fri, Mar 17, 2017 at 3:15 PM, Xose Vazquez Perez <xose.vazq...@gmail.com> wrote: > Cc: Gris Ge <f...@redhat.com> > Cc: Christophe Varoqui <christophe.varo...@opensvc.com> > Cc: device-mapper development <dm-devel@redhat.com> > Signed-o

Re: [dm-devel] [PATCH] multipath-tools: Remove trailing whitespaces

2017-03-23 Thread Christophe Varoqui
Merged. Thanks. On Fri, Mar 17, 2017 at 1:35 AM, Xose Vazquez Perez <xose.vazq...@gmail.com> wrote: > Cc: Christophe Varoqui <christophe.varo...@opensvc.com> > Cc: device-mapper development <dm-devel@redhat.com> > Signed-off-by: Xose Vazquez Perez <xose.vazq...@gm

Re: [dm-devel] [PATCH 00/33] multipath-tools fixes from SUSE

2017-03-23 Thread Christophe Varoqui
The full set is now merged. Thanks. On Wed, Mar 22, 2017 at 10:29 PM, Christophe Varoqui < christophe.varo...@opensvc.com> wrote: > Pending. > I plan to merge the rest tomorrow. > > Le 22 mars 2017 8:02 PM, "Xose Vazquez Perez" <xose.vazq...@gmail.com> a >

Re: [dm-devel] [PATCH 00/33] multipath-tools fixes from SUSE

2017-03-22 Thread Christophe Varoqui
Pending. I plan to merge the rest tomorrow. Le 22 mars 2017 8:02 PM, "Xose Vazquez Perez" a écrit : > On 02/28/2017 05:22 PM, Martin Wilck wrote: > > > As announced previously, here comes a collection of multipath-tools > patches > > that SUSE is using for SLES12 SP2. >

Re: [dm-devel] [PATCH] multipath-tools: libdmmp: Fix incorrect use of __attribute__

2017-03-16 Thread Christophe Varoqui
Applied Thanks. On Sat, Mar 11, 2017 at 3:12 PM, Gris Ge wrote: > According to https://gcc.gnu.org/onlinedocs/gcc/Type-Attributes.html , > type attributes should be placed immediately after the struct, union or > enum keyword. > > Signed-off-by: Gris Ge > ---

Re: [dm-devel] [PATCH] multipath-tools: clean up libdmmp/Makefile

2017-03-16 Thread Christophe Varoqui
Applied, Thanks. On Mon, Mar 13, 2017 at 5:47 PM, Xose Vazquez Perez <xose.vazq...@gmail.com> wrote: > Replace LDFLAGS with LIBDEPS, build libdmmp shared library without CFLAGS > > Cc: Gris Ge <f...@redhat.com> > Cc: Christophe Varoqui <christophe.varo...@opens

  1   2   3   >