Re: dm-devel has migrated to lists.linux.dev

2023-10-11 Thread Mike Snitzer
[this is also test, to see if new list allows old list to email it] On Fri, Oct 06 2023 at 7:43P -0400, Mike Snitzer wrote: > On Fri, Oct 06 2023 at 7:29P -0400, > Mike Snitzer wrote: > > > Hi, > > > > As a dm-devel@redhat.com subscriber, you have been silentl

[dm-devel] [git pull] device mapper fixes for 6.6-rc5

2023-10-06 Thread Mike Snitzer
(1): dm zoned: free dmz->ddev array in dmz_put_zoned_devices Mike Snitzer (1): MAINTAINERS: update the dm-devel mailing list MAINTAINERS | 4 ++-- drivers/md/dm-zoned-target.c | 15 +++ 2 files changed, 9 insertions(+), 10 deletions(-) -- dm-devel mail

Re: [dm-devel] dm crypt: Fix reqsize in crypt_iv_eboiv_gen

2023-10-05 Thread Mike Snitzer
ze, __alignof__(__le64)); > > req = kmalloc(reqsize + cc->iv_size, GFP_NOIO); > if (!req) Sure, please do. Shouldn't your header Cc: stable given that the Fixes commit implies v6.5 needs this fix? (sorry I missed this the first time I 'Reviewed-by' the original commit) Reviewed-by: Mike Mike Snitzer Thanks, Mike -- dm-devel mailing list dm-devel@redhat.com https://listman.redhat.com/mailman/listinfo/dm-devel

Re: [dm-devel] Sleeping function called from invalid context

2023-09-27 Thread Mike Snitzer
done by the space-map. > > 2 new specific unit tests were added to dm-unit: > >/thinp/fragmentation/thins >/thinp/fragmentation/snapshots > >https://github.com/jthornber/dm-unit/blob/main/src/tests/thinp.rs > > Signed-off-by: Joe Thornbe

Re: [dm-devel] fstrim on raid1 LV with writemostly PV leads to system freeze

2023-09-21 Thread Mike Snitzer
[cc'ing Heinz and the linux-raid mailing list] On Thu, Sep 21 2023 at 4:34P -0400, Kirill Kirilenko wrote: > Hello. > > I created two LVM physical volumes: one on NVMe device and one on SATA SSD. > I added them to a volume group and created a logical RAID1 volume in it. > Then I enabled

Re: [dm-devel] dm-zoned: free dmz->ddev array in dmz_put_zoned_device

2023-09-20 Thread Mike Snitzer
On Wed, Sep 20 2023 at 10:35P -0400, Fedor Pchelkin wrote: > On 23/09/20 04:06PM, Hannes Reinecke wrote: > > On 9/20/23 12:51, Fedor Pchelkin wrote: > > > Commit 4dba12881f88 ("dm zoned: support arbitrary number of devices") > > > made the pointers to additional zoned devices to be stored in a >

[dm-devel] [git pull] device mapper fixes for 6.6-rc2

2023-09-15 Thread Mike Snitzer
Hi Linus, The following changes since commit 0bb80ecc33a8fb5a682236443c1e740d5c917d1d: Linux 6.6-rc1 (2023-09-10 16:28:41 -0700) are available in the Git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/device-mapper/linux-dm.git tags/for-6.6/dm-fixes for you to fetch changes

Re: [dm-devel] DM brokeness with NOWAIT

2023-09-15 Thread Mike Snitzer
syscall_64+0x39/0xb0 > > entry_SYSCALL_64_after_hwframe+0x63/0xcd > > > > which seems to demonstrate a misunderstanding on what REQ_NOWAIT is > > about. In particulary, it seems to assume you can then submit with > > atomic context? DM does an rcu_read_lock() and happily proce

Re: [dm-devel] [device-mapper-dm:for-next 2/4] drivers/md/persistent-data/dm-extent-allocator.c:530:24: error: expected '; ' after expression

2023-09-14 Thread Mike Snitzer
On Thu, Sep 14 2023 at 10:54P -0400, kernel test robot wrote: > tree: > https://git.kernel.org/pub/scm/linux/kernel/git/device-mapper/linux-dm.git > for-next > head: edcabec81f12dfc9b86b05084bba3232efdc5e4e > commit: 59d814674dd66fc64ba229605174bfe0b8e566d5 [2/4] dm persistent data: >

[dm-devel] [PATCH v3 01/39] dm: add documentation for dm-vdo target

2023-09-14 Thread Mike Snitzer
From: Matthew Sakai This adds the admin-guide documentation for dm-vdo. vdo.rst is the guide to using dm-vdo. vdo-design.rst is an overview of the design of dm-vdo. Co-developed-by: J. corwin Coburn Signed-off-by: J. corwin Coburn Signed-off-by: Matthew Sakai Signed-off-by: Mike Snitzer

[dm-devel] [PATCH v3 38/39] dm vdo: add the top-level DM target

2023-09-14 Thread Mike Snitzer
Signed-off-by: Sweet Tea Dorminy Co-developed-by: Bruce Johnston Signed-off-by: Bruce Johnston Co-developed-by: Ken Raeburn Signed-off-by: Ken Raeburn Signed-off-by: Matthew Sakai Signed-off-by: Mike Snitzer --- drivers/md/dm-vdo-target.c | 2982 1 file

[dm-devel] [PATCH v3 37/39] dm vdo: add debugging support

2023-09-14 Thread Mike Snitzer
Sclafani Signed-off-by: Michael Sclafani Co-developed-by: Sweet Tea Dorminy Signed-off-by: Sweet Tea Dorminy Co-developed-by: Bruce Johnston Signed-off-by: Bruce Johnston Co-developed-by: Ken Raeburn Signed-off-by: Ken Raeburn Signed-off-by: Matthew Sakai Signed-off-by: Mike Snitzer --- drivers

[dm-devel] [PATCH v3 35/39] dm vdo: add statistics reporting

2023-09-14 Thread Mike Snitzer
Sakai Signed-off-by: Mike Snitzer --- drivers/md/dm-vdo/message-stats.c | 1215 + drivers/md/dm-vdo/message-stats.h | 13 + drivers/md/dm-vdo/statistics.h| 278 +++ 3 files changed, 1506 insertions(+) create mode 100644 drivers/md/dm-vdo/message-stats.c create

[dm-devel] [PATCH v3 33/39] dm vdo: add the vdo structure itself

2023-09-14 Thread Mike Snitzer
-by: Michael Sclafani Signed-off-by: Michael Sclafani Co-developed-by: Sweet Tea Dorminy Signed-off-by: Sweet Tea Dorminy Signed-off-by: Matthew Sakai Signed-off-by: Mike Snitzer --- drivers/md/dm-vdo/vdo.c | 1845 +++ drivers/md/dm-vdo/vdo.h | 381

[dm-devel] [PATCH v3 34/39] dm vdo: add the on-disk formats and marshalling of vdo structures

2023-09-14 Thread Mike Snitzer
Tea Dorminy Signed-off-by: Matthew Sakai Signed-off-by: Mike Snitzer --- drivers/md/dm-vdo/encodings.c | 1488 + drivers/md/dm-vdo/encodings.h | 1307 + 2 files changed, 2795 insertions(+) create mode 100644 drivers/md/dm-vdo/encodings.c

[dm-devel] [PATCH v3 39/39] dm vdo: enable configuration and building of dm-vdo

2023-09-14 Thread Mike Snitzer
Coburn Co-developed-by: John Wiele Signed-off-by: John Wiele Signed-off-by: Matthew Sakai Signed-off-by: Mike Snitzer --- drivers/md/Kconfig | 16 drivers/md/Makefile | 2 ++ 2 files changed, 18 insertions(+) diff --git a/drivers/md/Kconfig b/drivers/md/Kconfig index

[dm-devel] [PATCH v3 32/39] dm vdo: add repair of damanged vdo volumes

2023-09-14 Thread Mike Snitzer
-by: J. corwin Coburn Co-developed-by: Michael Sclafani Signed-off-by: Michael Sclafani Co-developed-by: Sweet Tea Dorminy Signed-off-by: Sweet Tea Dorminy Signed-off-by: Matthew Sakai Signed-off-by: Mike Snitzer --- drivers/md/dm-vdo/repair.c | 1775

[dm-devel] [PATCH v3 36/39] dm vdo: add sysfs support for setting vdo params and reading stats

2023-09-14 Thread Mike Snitzer
-developed-by: Sweet Tea Dorminy Signed-off-by: Sweet Tea Dorminy Co-developed-by: Bruce Johnston Signed-off-by: Bruce Johnston Signed-off-by: Matthew Sakai Signed-off-by: Mike Snitzer --- drivers/md/dm-vdo/pool-sysfs-stats.c | 2063 ++ drivers/md/dm-vdo/pool-sysfs.c

[dm-devel] [PATCH v3 31/39] dm vdo: add the vdo recovery journal

2023-09-14 Thread Mike Snitzer
Dorminy Signed-off-by: Matthew Sakai Signed-off-by: Mike Snitzer --- drivers/md/dm-vdo/recovery-journal.c | 1772 ++ drivers/md/dm-vdo/recovery-journal.h | 313 + 2 files changed, 2085 insertions(+) create mode 100644 drivers/md/dm-vdo/recovery-journal.c create mo

[dm-devel] [PATCH v3 30/39] dm vdo: implement the vdo block map page cache

2023-09-14 Thread Mike Snitzer
Sclafani Signed-off-by: Michael Sclafani Co-developed-by: Sweet Tea Dorminy Signed-off-by: Sweet Tea Dorminy Signed-off-by: Matthew Sakai Signed-off-by: Mike Snitzer --- drivers/md/dm-vdo/block-map.c | 1231 + drivers/md/dm-vdo/block-map.h | 165 + 2 files

[dm-devel] [PATCH v3 24/39] dm vdo: add the compressed block bin packer

2023-09-14 Thread Mike Snitzer
and writing of compressed blocks when bins fill. Co-developed-by: J. corwin Coburn Signed-off-by: J. corwin Coburn Co-developed-by: Michael Sclafani Signed-off-by: Michael Sclafani Co-developed-by: Sweet Tea Dorminy Signed-off-by: Sweet Tea Dorminy Signed-off-by: Matthew Sakai Signed-off-by: Mike

[dm-devel] [PATCH v3 29/39] dm vdo: add the block map

2023-09-14 Thread Mike Snitzer
-by: Matthew Sakai Signed-off-by: Mike Snitzer --- drivers/md/dm-vdo/block-map.c | 2145 + drivers/md/dm-vdo/block-map.h | 232 2 files changed, 2377 insertions(+) create mode 100644 drivers/md/dm-vdo/block-map.c create mode 100644 drivers/md/dm-vdo/block

[dm-devel] [PATCH v3 27/39] dm vdo: add the block allocators and physical zones

2023-09-14 Thread Mike Snitzer
J. corwin Coburn Signed-off-by: J. corwin Coburn Co-developed-by: Michael Sclafani Signed-off-by: Michael Sclafani Co-developed-by: Sweet Tea Dorminy Signed-off-by: Sweet Tea Dorminy Signed-off-by: Matthew Sakai Signed-off-by: Mike Snitzer --- drivers/md/dm-vdo/physical-zon

[dm-devel] [PATCH v3 28/39] dm vdo: add the slab depot

2023-09-14 Thread Mike Snitzer
-developed-by: Sweet Tea Dorminy Signed-off-by: Sweet Tea Dorminy Signed-off-by: Matthew Sakai Signed-off-by: Mike Snitzer --- drivers/md/dm-vdo/slab-depot.c | 965 + drivers/md/dm-vdo/slab-depot.h | 121 + 2 files changed, 1086 insertions(+) diff --git

[dm-devel] [PATCH v3 25/39] dm vdo: add slab structure, slab journal and reference counters

2023-09-14 Thread Mike Snitzer
Signed-off-by: Mike Snitzer --- drivers/md/dm-vdo/slab-depot.c | 2460 drivers/md/dm-vdo/slab-depot.h | 253 2 files changed, 2713 insertions(+) create mode 100644 drivers/md/dm-vdo/slab-depot.c create mode 100644 drivers/md/dm-vdo/slab-depot.h diff

[dm-devel] [PATCH v3 26/39] dm vdo: add the slab summary

2023-09-14 Thread Mike Snitzer
J. corwin Coburn Co-developed-by: Michael Sclafani Signed-off-by: Michael Sclafani Co-developed-by: Sweet Tea Dorminy Signed-off-by: Sweet Tea Dorminy Signed-off-by: Matthew Sakai Signed-off-by: Mike Snitzer --- drivers/md/dm-vdo/slab-depot.c | 326 + drivers/md/d

[dm-devel] [PATCH v3 23/39] dm vdo: add use of the deduplication index in hash zones

2023-09-14 Thread Mike Snitzer
Dorminy Signed-off-by: Sweet Tea Dorminy Co-developed-by: Bruce Johnston Signed-off-by: Bruce Johnston Co-developed-by: Ken Raeburn Signed-off-by: Ken Raeburn Signed-off-by: Matthew Sakai Signed-off-by: Mike Snitzer --- drivers/md/dm-vdo/dedupe.c | 623

[dm-devel] [PATCH v3 20/39] dm vdo: add flush support

2023-09-14 Thread Mike Snitzer
-by: Sweet Tea Dorminy Signed-off-by: Sweet Tea Dorminy Signed-off-by: Matthew Sakai Signed-off-by: Mike Snitzer --- drivers/md/dm-vdo/flush.c| 563 +++ drivers/md/dm-vdo/flush.h| 44 +++ drivers/md/dm-vdo/logical-zone.c | 378 + drivers

[dm-devel] [PATCH v3 22/39] dm vdo: add hash locks and hash zones

2023-09-14 Thread Mike Snitzer
zone based on a portion of its hash. Co-developed-by: J. corwin Coburn Signed-off-by: J. corwin Coburn Co-developed-by: Michael Sclafani Signed-off-by: Michael Sclafani Co-developed-by: Sweet Tea Dorminy Signed-off-by: Sweet Tea Dorminy Signed-off-by: Matthew Sakai Signed-off-by: Mi

[dm-devel] [PATCH v3 18/39] dm vdo: add vio, the request object for vdo metadata

2023-09-14 Thread Mike Snitzer
-by: Sweet Tea Dorminy Co-developed-by: Bruce Johnston Signed-off-by: Bruce Johnston Co-developed-by: Ken Raeburn Signed-off-by: Ken Raeburn Signed-off-by: Matthew Sakai Signed-off-by: Mike Snitzer --- drivers/md/dm-vdo/vio.c | 525 drivers/md/dm-vdo

[dm-devel] [PATCH v3 21/39] dm vdo: add the io_submitter

2023-09-14 Thread Mike Snitzer
Tea Dorminy Signed-off-by: Sweet Tea Dorminy Co-developed-by: Bruce Johnston Signed-off-by: Bruce Johnston Co-developed-by: Ken Raeburn Signed-off-by: Ken Raeburn Signed-off-by: Matthew Sakai Signed-off-by: Mike Snitzer --- drivers/md/dm-vdo/io-submitter.c | 483

[dm-devel] [PATCH v3 19/39] dm vdo: add data_vio, the request object which services incoming bios

2023-09-14 Thread Mike Snitzer
Dorminy Signed-off-by: Sweet Tea Dorminy Co-developed-by: Bruce Johnston Signed-off-by: Bruce Johnston Co-developed-by: Ken Raeburn Signed-off-by: Ken Raeburn Signed-off-by: Matthew Sakai Signed-off-by: Mike Snitzer --- drivers/md/dm-vdo/data-vio.c | 2076

[dm-devel] [PATCH v3 17/39] dm vdo: add administrative state and action manager

2023-09-14 Thread Mike Snitzer
-developed-by: J. corwin Coburn Signed-off-by: J. corwin Coburn Signed-off-by: Matthew Sakai Signed-off-by: Mike Snitzer --- drivers/md/dm-vdo/action-manager.c | 410 +++ drivers/md/dm-vdo/action-manager.h | 117 +++ drivers/md/dm-vdo/admin-state.c| 512

[dm-devel] [PATCH v3 16/39] dm vdo: implement external deduplication index interface

2023-09-14 Thread Mike Snitzer
Signed-off-by: Matthew Sakai Signed-off-by: Mike Snitzer --- drivers/md/dm-vdo/index-session.c | 815 ++ drivers/md/dm-vdo/index-session.h | 84 +++ drivers/md/dm-vdo/uds-sysfs.c | 185 +++ drivers/md/dm-vdo/uds-sysfs.h | 12 + drivers/md/dm-vdo/uds.h

[dm-devel] [PATCH v3 10/39] dm vdo: add deduplication index storage interface

2023-09-14 Thread Mike Snitzer
. corwin Coburn Signed-off-by: J. corwin Coburn Co-developed-by: Michael Sclafani Signed-off-by: Michael Sclafani Co-developed-by: Thomas Jaskiewicz Signed-off-by: Thomas Jaskiewicz Co-developed-by: John Wiele Signed-off-by: John Wiele Signed-off-by: Matthew Sakai Signed-off-by: Mike Snitzer

[dm-devel] [PATCH v3 15/39] dm vdo: implement top-level deduplication index

2023-09-14 Thread Mike Snitzer
-by: Matthew Sakai Signed-off-by: Mike Snitzer --- drivers/md/dm-vdo/index.c| 1403 ++ drivers/md/dm-vdo/index.h| 83 ++ drivers/md/dm-vdo/sparse-cache.c | 595 + drivers/md/dm-vdo/sparse-cache.h | 49 ++ 4 files changed, 2130 insertions

[dm-devel] [PATCH v3 14/39] dm vdo: implement the chapter volume store

2023-09-14 Thread Mike Snitzer
. corwin Coburn Signed-off-by: J. corwin Coburn Co-developed-by: Michael Sclafani Signed-off-by: Michael Sclafani Co-developed-by: Thomas Jaskiewicz Signed-off-by: Thomas Jaskiewicz Co-developed-by: John Wiele Signed-off-by: John Wiele Signed-off-by: Matthew Sakai Signed-off-by: Mike Snitzer

[dm-devel] [PATCH v3 12/39] dm vdo: implement the volume index

2023-09-14 Thread Mike Snitzer
Signed-off-by: J. corwin Coburn Co-developed-by: Michael Sclafani Signed-off-by: Michael Sclafani Co-developed-by: Thomas Jaskiewicz Signed-off-by: Thomas Jaskiewicz Signed-off-by: Matthew Sakai Signed-off-by: Mike Snitzer --- drivers/md/dm-vdo/volume-index.c | 1277

[dm-devel] [PATCH v3 13/39] dm vdo: implement the open chapter and chapter indexes

2023-09-14 Thread Mike Snitzer
Signed-off-by: J. corwin Coburn Co-developed-by: Michael Sclafani Signed-off-by: Michael Sclafani Co-developed-by: Thomas Jaskiewicz Signed-off-by: Thomas Jaskiewicz Signed-off-by: Matthew Sakai Signed-off-by: Mike Snitzer --- drivers/md/dm-vdo/chapter-index.c | 304

[dm-devel] [PATCH v3 11/39] dm vdo: implement the delta index

2023-09-14 Thread Mike Snitzer
-developed-by: Michael Sclafani Signed-off-by: Michael Sclafani Co-developed-by: Thomas Jaskiewicz Signed-off-by: Thomas Jaskiewicz Signed-off-by: Matthew Sakai Signed-off-by: Mike Snitzer --- drivers/md/dm-vdo/delta-index.c | 2018 +++ drivers/md/dm-vdo/delta

[dm-devel] [PATCH v3 07/39] dm vdo: add specialized request queueing functionality

2023-09-14 Thread Mike Snitzer
-by: Michael Sclafani Co-developed-by: Sweet Tea Dorminy Signed-off-by: Sweet Tea Dorminy Co-developed-by: Ken Raeburn Signed-off-by: Ken Raeburn Signed-off-by: Matthew Sakai Signed-off-by: Mike Snitzer --- drivers/md/dm-vdo/completion.c| 141 +++ drivers/md/dm-vdo/completion.h| 155

[dm-devel] [PATCH v3 09/39] dm vdo: add deduplication configuration structures

2023-09-14 Thread Mike Snitzer
-by: Michael Sclafani Signed-off-by: Michael Sclafani Co-developed-by: Thomas Jaskiewicz Signed-off-by: Thomas Jaskiewicz Co-developed-by: John Wiele Signed-off-by: John Wiele Signed-off-by: Matthew Sakai Signed-off-by: Mike Snitzer --- drivers/md/dm-vdo/config.c | 389

[dm-devel] [PATCH v3 03/39] dm vdo: add memory allocation utilities

2023-09-14 Thread Mike Snitzer
-by: Thomas Jaskiewicz Co-developed-by: Ken Raeburn Signed-off-by: Ken Raeburn Signed-off-by: Matthew Sakai Signed-off-by: Mike Snitzer --- drivers/md/dm-vdo/memory-alloc.c | 447 +++ drivers/md/dm-vdo/memory-alloc.h | 181 + 2 files changed, 628 insertions

[dm-devel] [PATCH v3 05/39] dm vdo: add type declarations, constants, and simple data structures

2023-09-14 Thread Mike Snitzer
of types and structs used to manage the processing of an I/O operation. Co-developed-by: J. corwin Coburn Signed-off-by: J. corwin Coburn Co-developed-by: Michael Sclafani Signed-off-by: Michael Sclafani Signed-off-by: Matthew Sakai Signed-off-by: Mike Snitzer --- drivers/md/dm-vdo

[dm-devel] [PATCH v3 08/39] dm vdo: add basic hash map data structures

2023-09-14 Thread Mike Snitzer
are deduplicated. The priority heap is used to minimize the search time for free blocks. Co-developed-by: J. corwin Coburn Signed-off-by: J. corwin Coburn Co-developed-by: Michael Sclafani Signed-off-by: Michael Sclafani Signed-off-by: Matthew Sakai Signed-off-by: Mike Snitzer --- drivers/md/dm-vdo/int

[dm-devel] [PATCH v3 06/39] dm vdo: add thread and synchronization utilities

2023-09-14 Thread Mike Snitzer
-off-by: Mike Snitzer --- drivers/md/dm-vdo/thread-cond-var.c | 46 +++ drivers/md/dm-vdo/thread-device.c | 35 ++ drivers/md/dm-vdo/thread-device.h | 19 +++ drivers/md/dm-vdo/thread-registry.c | 93 ++ drivers/md/dm-vdo/thread-registry.h | 33 + drivers/md/dm-vdo

[dm-devel] [PATCH v3 04/39] dm vdo: add basic logging and support utilities

2023-09-14 Thread Mike Snitzer
-off-by: Michael Sclafani Co-developed-by: Thomas Jaskiewicz Signed-off-by: Thomas Jaskiewicz Co-developed-by: Ken Raeburn Signed-off-by: Ken Raeburn Signed-off-by: Matthew Sakai Signed-off-by: Mike Snitzer --- drivers/md/dm-vdo/errors.c | 316 +++ drivers/md

[dm-devel] [PATCH v3 00/39] dm: baseline for the VDO target

2023-09-14 Thread Mike Snitzer
Hi, This patchset reflects a baseline of the VDO DM target. It is still very much under active review and development, and will likley continue to be until the end of this year. So while the code isn't yet ready for upstream inclusion it will evolve so that one day it hopefully is, and moving

[dm-devel] [PATCH v3 02/39] dm vdo: add the MurmurHash3 fast hashing algorithm

2023-09-14 Thread Mike Snitzer
in portable persistent data. Co-developed-by: J. corwin Coburn Signed-off-by: J. corwin Coburn Co-developed-by: Ken Raeburn Signed-off-by: Ken Raeburn Co-developed-by: John Wiele Signed-off-by: John Wiele Signed-off-by: Matthew Sakai Signed-off-by: Mike Snitzer --- drivers/md/dm-vdo/murmurhash3.c

Re: [dm-devel] [dm-devel resend] dm mpath: fix UAF in multipath_message()

2023-09-05 Thread Mike Snitzer
ine? > > Thanks. > > 在 2023/8/9 18:44, Mikulas Patocka 写道: > > > > On Tue, 8 Aug 2023, Mikulas Patocka wrote: > > > >> On Wed, 2 Aug 2023, Mike Snitzer wrote: > >> > >>> [Cc'ing Mikulas so he can take a look at this too.] > >>

Re: [dm-devel] [dm-devel resend] dm mpath: fix UAF in multipath_message()

2023-08-02 Thread Mike Snitzer
On Thu, May 18 2023 at 8:11P -0400, lilingfeng (A) wrote: > > 在 2022/10/18 3:56, Mike Snitzer 写道: > > On Mon, Oct 10 2022 at 10:41P -0400, > > Luo Meng wrote: > > > > > From: Luo Meng > > > > > > If dm_get_device() create dd in multipat

[dm-devel] [git pull] device mapper fixes for 6.5-rc4

2023-07-27 Thread Mike Snitzer
Hi Linus, The following changes since commit fdf0eaf11452d72945af31804e2a1048ee1b574c: Linux 6.5-rc2 (2023-07-16 15:10:37 -0700) are available in the Git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/device-mapper/linux-dm.git tags/for-6.5/dm-fixes for you to fetch changes

Re: [dm-devel] [PATCH v2 00/39] Add the dm-vdo deduplication and compression device mapper target.

2023-07-18 Thread Mike Snitzer
er Red Hat acquired Permabit: On Wed, Aug 30 2017 at 11:52P -0400, Mike Snitzer wrote: > The following list covers what Joe and I feel is a good first step at > starting to prepare the permabit kernel code for upstream. This will be > an iterative process but working through these issues

Re: [dm-devel] [PATCH 5.15] dm init: add dm-mod.waitfor to wait for asynchronously probed block devices

2023-07-16 Thread Mike Snitzer
waiting for device PARTLABEL=root-a > ... > > [0.751306] device-mapper: init: all devices available > > [0.751683] device-mapper: verity: sha256 using implementation > "sha256-generic" > > [ 0.759344] device-mapper: ioctl: dm-0 (vroot) is ready > > [

Re: [dm-devel] [PATCH v2] dm-crypt: reexport sysfs of kcryptd workqueue

2023-07-07 Thread Mike Snitzer
this note in his summary patch header for his 6.5 changes: "Alasdair Kergon, Mike Snitzer, DM folks --- I ran fio on top of dm-crypt to compare performance of different configurations. It mostly behaved as expected but please let me know if anything doens't

Re: [dm-devel] [RFC PATCH v10 11/17] dm-verity: consume root hash digest and signature data via LSM hook

2023-07-07 Thread Mike Snitzer
On Wed, Jun 28 2023 at 5:09P -0400, Fan Wu wrote: > From: Deven Bowers > > dm-verity provides a strong guarantee of a block device's integrity. As > a generic way to check the integrity of a block device, it provides > those integrity guarantees to its higher layers, including the filesystem

[dm-devel] [git pull] device mapper changes for 6.5

2023-06-29 Thread Mike Snitzer
tl: Avoid double-fetch of version dm ioctl: Refuse to create device named "control" dm ioctl: Refuse to create device named "." or ".." Li Lingfeng (1): dm thin metadata: Fix ABBA deadlock by resetting dm_bufio_client Li Nan (1): dm: suppor

Re: [dm-devel] [PATCH v2 1/6] device-mapper: Check that target specs are sufficiently aligned

2023-06-22 Thread Mike Snitzer
On Thu, Jun 22 2023 at 3:51P -0400, Demi Marie Obenour wrote: > On Thu, Jun 22, 2023 at 12:28:28PM -0400, Mike Snitzer wrote: > > On Sat, Jun 03 2023 at 10:52P -0400, > > Demi Marie Obenour wrote: > > > > > Otherwise subsequent code will dereference a misaligne

Re: [dm-devel] [PATCH v2 2/6] device-mapper: Avoid pointer arithmetic overflow

2023-06-22 Thread Mike Snitzer
On Sat, Jun 03 2023 at 10:52P -0400, Demi Marie Obenour wrote: > Especially on 32-bit systems, it is possible for the pointer arithmetic > to overflow and cause a userspace pointer to be dereferenced in the > kernel. > > Signed-off-by: Demi Marie Obenour > Fixes: 1da177e4c3f4

Re: [dm-devel] [PATCH v2 1/6] device-mapper: Check that target specs are sufficiently aligned

2023-06-22 Thread Mike Snitzer
On Sat, Jun 03 2023 at 10:52P -0400, Demi Marie Obenour wrote: > Otherwise subsequent code will dereference a misaligned > `struct dm_target_spec *`, which is undefined behavior. > > Signed-off-by: Demi Marie Obenour > Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2") > Cc: sta...@vger.kernel.org > ---

Re: [dm-devel] [PATCH v2 4/6] device-mapper: Avoid double-fetch of version

2023-06-22 Thread Mike Snitzer
On Sat, Jun 03 2023 at 10:52P -0400, Demi Marie Obenour wrote: > The version is fetched once in check_version(), which then does some > validation and then overwrites the version in userspace with the API > version supported by the kernel. copy_params() then fetches the version > from userspace

[dm-devel] [git pull] device mapper fixes for 6.4-rc7

2023-06-15 Thread Mike Snitzer
ap is NULL during suspend or resume dm thin metadata: check fail_io before using data_sm Mike Snitzer (2): dm thin: fix issue_discard to pass GFP_NOIO to __blkdev_issue_discard dm: use op specific max_sectors when splitting abnormal io drivers/md/dm-ioctl.c | 5 + dri

Re: [dm-devel] [PATCH v7 0/5] Introduce provisioning primitives

2023-06-09 Thread Mike Snitzer
On Wed, Jun 07 2023 at 7:27P -0400, Mike Snitzer wrote: > On Mon, Jun 05 2023 at 5:14P -0400, > Sarthak Kukreti wrote: > > > On Sat, Jun 3, 2023 at 8:57 AM Mike Snitzer wrote: > > > > > > We all just need to focus on your proposal and Joe's

Re: [dm-devel] [PATCH v7 2/5] block: Introduce provisioning primitives

2023-06-09 Thread Mike Snitzer
On Thu, May 18 2023 at 6:33P -0400, Sarthak Kukreti wrote: > Introduce block request REQ_OP_PROVISION. The intent of this request > is to request underlying storage to preallocate disk space for the given > block range. Block devices that support this capability will export > a provision limit

Re: [dm-devel] block: fix a crash when bio_for_each_folio_all iterates over an empty bio

2023-06-09 Thread Mike Snitzer
On Tue, Apr 18 2023 at 11:20P -0400, Mike Snitzer wrote: > On Mon, Apr 17 2023 at 3:11P -0400, > Mikulas Patocka wrote: > > > If we use bio_for_each_folio_all on an empty bio, it will access the first > > bio vector unconditionally (it is uninitialized) and it ma

Re: [dm-devel] [PATCH v7 4/5] dm-thin: Add REQ_OP_PROVISION support

2023-06-08 Thread Mike Snitzer
On Thu, Jun 08 2023 at 5:24P -0400, Mike Snitzer wrote: > On Fri, May 19 2023 at 11:23P -0400, > Mike Snitzer wrote: > > > On Thu, May 18 2023 at 6:33P -0400, > > Sarthak Kukreti wrote: > > > > > dm-thinpool uses the provision request to provision &

Re: [dm-devel] [PATCH v7 4/5] dm-thin: Add REQ_OP_PROVISION support

2023-06-08 Thread Mike Snitzer
On Fri, May 19 2023 at 11:23P -0400, Mike Snitzer wrote: > On Thu, May 18 2023 at 6:33P -0400, > Sarthak Kukreti wrote: > > > dm-thinpool uses the provision request to provision > > blocks for a dm-thin device. dm-thinpool currently does not > > pass through REQ

Re: [dm-devel] [PATCH v7 0/5] Introduce provisioning primitives

2023-06-07 Thread Mike Snitzer
On Tue, Jun 06 2023 at 10:01P -0400, Dave Chinner wrote: > On Sat, Jun 03, 2023 at 11:57:48AM -0400, Mike Snitzer wrote: > > On Fri, Jun 02 2023 at 8:52P -0400, > > Dave Chinner wrote: > > > > > Mike, I think you might have misunderstood what I have

Re: [dm-devel] [PATCH v7 0/5] Introduce provisioning primitives

2023-06-07 Thread Mike Snitzer
On Mon, Jun 05 2023 at 5:14P -0400, Sarthak Kukreti wrote: > On Sat, Jun 3, 2023 at 8:57 AM Mike Snitzer wrote: > > > > We all just need to focus on your proposal and Joe's dm-thin > > reservation design... > > > > [Sarthak: FYI, this implies that it doesn'

Re: [dm-devel] [PATCH 3/3] block: fail writes to read-only devices

2023-06-06 Thread Mike Snitzer
use we probably need > to find a workaround for this in device mapper rather than lacking > the core block layer checks. > > Signed-off-by: Christoph Hellwig Reviewed-by: Mike Snitzer -- dm-devel mailing list dm-devel@redhat.com https://listman.redhat.com/mailman/listinfo/dm-devel

Re: [dm-devel] enforce read-only state at the block layer

2023-06-06 Thread Mike Snitzer
On Thu, Jun 01 2023 at 3:28P -0400, Christoph Hellwig wrote: > Hi all, > > I've recently got a report where a file system can write to a read-only > block device, and while I've not found the root cause yet, it is very > clear that we should not prevents writes to read-only at all. > > This

Re: [dm-devel] [PATCH v7 0/5] Introduce provisioning primitives

2023-06-03 Thread Mike Snitzer
On Fri, Jun 02 2023 at 8:52P -0400, Dave Chinner wrote: > On Fri, Jun 02, 2023 at 11:44:27AM -0700, Sarthak Kukreti wrote: > > On Tue, May 30, 2023 at 8:28 AM Mike Snitzer wrote: > > > > > > On Tue, May 30 2023 at 10:55P -0400, > > > Joe Thornber wrote: >

Re: [dm-devel] [PATCH v7 0/5] Introduce provisioning primitives

2023-06-02 Thread Mike Snitzer
On Fri, Jun 02 2023 at 2:44P -0400, Sarthak Kukreti wrote: > On Tue, May 30, 2023 at 8:28 AM Mike Snitzer wrote: > > > > On Tue, May 30 2023 at 10:55P -0400, > > Joe Thornber wrote: > > > > > On Tue, May 30, 2023 at 3:02 PM Mike Snitzer wrote: > > &g

Re: [dm-devel] dm crypt: Avoid using MAX_CIPHER_BLOCKSIZE

2023-06-01 Thread Mike Snitzer
skcipher_request_{alloc,free} is ideal, but dm-crypt is the only non-crypto consumer of MAX_CIPHER_BLOCKSIZE so really not worth standing up yet another interface wrapper. Anyway, this code is certainly better for dm-crypt's needs. I'm happy with you applying this change via your crypto tree. Reviewed-by: Mike Snitzer Thanks. -- dm-devel mailing list dm-devel@redhat.com https://listman.redhat.com/mailman/listinfo/dm-devel

Re: [dm-devel] [PATCH v5 16/20] dm-crypt: check if adding pages to clone bio fails

2023-06-01 Thread Mike Snitzer
On Tue, May 30 2023 at 3:43P -0400, Mikulas Patocka wrote: > > > On Tue, 30 May 2023, Mike Snitzer wrote: > > > On Tue, May 30 2023 at 11:13P -0400, > > Mikulas Patocka wrote: > > > > > Hi > > > > > > I nack this. This just add

Re: [dm-devel] [PATCH v7 1/5] block: Don't invalidate pagecache for invalid falloc modes

2023-05-31 Thread Mike Snitzer
. > > Fixes: 25f4c41415e5 ("block: implement (some of) fallocate for block devices") > Cc: sta...@vger.kernel.org > Reported-by: Darrick J. Wong > Signed-off-by: Sarthak Kukreti Reviewed-by: Mike Snitzer Jens, this one is independent of the rest of the patchset and should be ready

Re: [dm-devel] [PATCH v6 16/20] dm-crypt: check if adding pages to clone bio fails

2023-05-30 Thread Mike Snitzer
On Tue, May 30 2023 at 11:49P -0400, Johannes Thumshirn wrote: > Check if adding pages to clone bio fails and if it does retry with > reclaim. This mirrors the behaviour of page allocation in > crypt_alloc_buffer(). Nope. > This way we can mark bio_add_pages as __must_check. > > Reviewed-by:

Re: [dm-devel] [PATCH v5 16/20] dm-crypt: check if adding pages to clone bio fails

2023-05-30 Thread Mike Snitzer
On Tue, May 30 2023 at 11:13P -0400, Mikulas Patocka wrote: > > > On Tue, 2 May 2023, Johannes Thumshirn wrote: > > > Check if adding pages to clone bio fails and if it does retry with > > reclaim. This mirrors the behaviour of page allocation in > > crypt_alloc_buffer(). > > > > This way we

Re: [dm-devel] [PATCH v7 0/5] Introduce provisioning primitives

2023-05-30 Thread Mike Snitzer
On Tue, May 30 2023 at 10:55P -0400, Joe Thornber wrote: > On Tue, May 30, 2023 at 3:02 PM Mike Snitzer wrote: > > > > > Also Joe, for you proposed dm-thinp design where you distinquish > > between "provision" and "reserve": Would it make s

Re: [dm-devel] [PATCH v7 0/5] Introduce provisioning primitives

2023-05-30 Thread Mike Snitzer
On Tue, May 30 2023 at 3:27P -0400, Joe Thornber wrote: > On Sat, May 27, 2023 at 12:45 AM Dave Chinner wrote: > > > On Fri, May 26, 2023 at 12:04:02PM +0100, Joe Thornber wrote: > > > > > 1) We have an api (ioctl, bio flag, whatever) that lets you > > > reserve/guarantee a region: > > > > >

Re: [dm-devel] [PATCH v7 0/5] Introduce provisioning primitives

2023-05-25 Thread Mike Snitzer
On Thu, May 25 2023 at 7:39P -0400, Dave Chinner wrote: > On Wed, May 24, 2023 at 04:02:49PM -0400, Mike Snitzer wrote: > > On Tue, May 23 2023 at 8:40P -0400, > > Dave Chinner wrote: > > > > > On Tue, May 23, 2023 at 11:26:18AM -0400, Mike Snitzer wrote: >

Re: [dm-devel] [PATCH v7 0/5] Introduce provisioning primitives

2023-05-24 Thread Mike Snitzer
On Tue, May 23 2023 at 8:40P -0400, Dave Chinner wrote: > On Tue, May 23, 2023 at 11:26:18AM -0400, Mike Snitzer wrote: > > On Tue, May 23 2023 at 10:05P -0400, Brian Foster > > wrote: > > > On Mon, May 22, 2023 at 02:27:57PM -0400, Mike Snitzer wrote: > > >

Re: [dm-devel] dm crypt: fix sleep-in-atomic-context bug in kcryptd_crypt_tasklet

2023-05-23 Thread Mike Snitzer
On Tue, May 23 2023 at 3:58P -0400, Duoming Zhou wrote: > In order to improve the IO performance of the dm-crypt > implementation, the commit 39d42fa96ba1 ("dm crypt: > add flags to optionally bypass kcryptd workqueues") > adds tasklet to do the crypto operations. > > The tasklet callback

Re: [dm-devel] dm overlaybd: targets mapping OverlayBD image

2023-05-23 Thread Mike Snitzer
On Fri, May 19 2023 at 6:27P -0400, Du Rui wrote: > OverlayBD is a novel layering block-level image format, which is design > for container, secure container and applicable to virtual machine, > published in USENIX ATC '20 > https://www.usenix.org/system/files/atc20-li-huiba.pdf > > OverlayBD

Re: [dm-devel] [PATCH 20/24] dm: only call early_lookup_bdev from early boot context

2023-05-23 Thread Mike Snitzer
return -EOVERFLOW; > } else { > r = lookup_bdev(path, ); > - if (r) > +#ifndef MODULE > + if (r && system_state < SYSTEM_RUNNING) > r = early_lookup_bdev(path, ); > +#endif >

Re: [dm-devel] [PATCH 18/24] dm: open code dm_get_dev_t in dm_init_init

2023-05-23 Thread Mike Snitzer
On Tue, May 23 2023 at 3:45P -0400, Christoph Hellwig wrote: > dm_init_init is called from early boot code, and thus lookup_bdev > will never succeed. Just open code that call to early_lookup_bdev > instead. > > Signed-off-by: Christoph Hellwig Reviewed-by: Mike Snitze

Re: [dm-devel] [PATCH 17/24] dm-snap: simplify the origin_dev == cow_dev check in snapshot_ctr

2023-05-23 Thread Mike Snitzer
On Tue, May 23 2023 at 3:45P -0400, Christoph Hellwig wrote: > Use the block_device acquired in dm_get_device for the check instead > of doing an extra lookup. > > Signed-off-by: Christoph Hellwig Reviewed-by: Mike Snitzer -- dm-devel mailing list dm-devel@redh

Re: [dm-devel] [PATCH 19/24] dm: remove dm_get_dev_t

2023-05-23 Thread Mike Snitzer
On Tue, May 23 2023 at 3:45P -0400, Christoph Hellwig wrote: > Open code dm_get_dev_t in the only remaining caller, and propagate the > exact error code from lookup_bdev and early_lookup_bdev. > > Signed-off-by: Christoph Hellwig > --- > drivers/md/dm-table.c | 20

Re: [dm-devel] [PATCH v7 0/5] Introduce provisioning primitives

2023-05-23 Thread Mike Snitzer
On Tue, May 23 2023 at 10:05P -0400, Brian Foster wrote: > On Mon, May 22, 2023 at 02:27:57PM -0400, Mike Snitzer wrote: > > On Fri, May 19 2023 at 7:07P -0400, > > Dave Chinner wrote: > > ... > > > e.g. If the device takes a snapshot, it needs to reprovision

Re: [dm-devel] [PATCH v7 0/5] Introduce provisioning primitives

2023-05-22 Thread Mike Snitzer
On Fri, May 19 2023 at 7:07P -0400, Dave Chinner wrote: > On Fri, May 19, 2023 at 10:41:31AM -0400, Mike Snitzer wrote: > > On Fri, May 19 2023 at 12:09P -0400, > > Christoph Hellwig wrote: > > > > > FYI, I really don't think this primitive is a good idea

Re: [dm-devel] [PATCH v7 4/5] dm-thin: Add REQ_OP_PROVISION support

2023-05-19 Thread Mike Snitzer
On Thu, May 18 2023 at 6:33P -0400, Sarthak Kukreti wrote: > dm-thinpool uses the provision request to provision > blocks for a dm-thin device. dm-thinpool currently does not > pass through REQ_OP_PROVISION to underlying devices. > > For shared blocks, provision requests will break sharing and

Re: [dm-devel] [PATCH v7 0/5] Introduce provisioning primitives

2023-05-19 Thread Mike Snitzer
On Fri, May 19 2023 at 12:09P -0400, Christoph Hellwig wrote: > FYI, I really don't think this primitive is a good idea. In the > concept of non-overwritable storage (NAND, SMR drives) the entire > concept of a one-shoot 'provisioning' that will guarantee later writes > are always possible is

Re: [dm-devel] [PATCH v6 4/5] dm-thin: Add REQ_OP_PROVISION support

2023-05-12 Thread Mike Snitzer
On Sat, May 06 2023 at 2:29P -0400, Sarthak Kukreti wrote: > dm-thinpool uses the provision request to provision > blocks for a dm-thin device. dm-thinpool currently does not > pass through REQ_OP_PROVISION to underlying devices. > > For shared blocks, provision requests will break sharing and

Re: [dm-devel] [PATCH v6 4/5] dm-thin: Add REQ_OP_PROVISION support

2023-05-12 Thread Mike Snitzer
On Thu, May 11 2023 at 4:03P -0400, Sarthak Kukreti wrote: > On Tue, May 9, 2023 at 9:58 AM Mike Snitzer wrote: > > > > On Sat, May 06 2023 at 2:29P -0400, > > Sarthak Kukreti wrote: > > > > > dm-thinpool uses the provision request to provision > >

Re: [dm-devel] [PATCH v6 4/5] dm-thin: Add REQ_OP_PROVISION support

2023-05-09 Thread Mike Snitzer
On Sat, May 06 2023 at 2:29P -0400, Sarthak Kukreti wrote: > dm-thinpool uses the provision request to provision > blocks for a dm-thin device. dm-thinpool currently does not > pass through REQ_OP_PROVISION to underlying devices. > > For shared blocks, provision requests will break sharing and

Re: [dm-devel] [PATCH v6 3/5] dm: Add block provisioning support

2023-05-09 Thread Mike Snitzer
y: Sarthak Kukreti Reviewed-by: Mike Snitzer -- dm-devel mailing list dm-devel@redhat.com https://listman.redhat.com/mailman/listinfo/dm-devel

Re: [dm-devel] [PATCH v6 2/5] block: Introduce provisioning primitives

2023-05-09 Thread Mike Snitzer
vision limit within their request queues. > > This patch also adds the capability to call fallocate() in mode 0 > on block devices, which will send REQ_OP_PROVISION to the block > device for the specified range, > > Signed-off-by: Sarthak Kukreti Reviewed-by: Mike Snitzer --

Re: [dm-devel] [PATCH v6 1/5] block: Don't invalidate pagecache for invalid falloc modes

2023-05-09 Thread Mike Snitzer
. > > Fixes: 25f4c41415e5 ("block: implement (some of) fallocate for block devices") > Cc: sta...@vger.kernel.org > Reported-by: Darrick J. Wong > Signed-off-by: Sarthak Kukreti Reviewed-by: Mike Snitzer -- dm-devel mailing list dm-devel@redhat.com https://listman.redhat.com/mailman/listinfo/dm-devel

Re: [dm-devel] [PATCH RFC 01/16] block: Add atomic write operations to request_queue limits

2023-05-08 Thread Mike Snitzer
On Wed, May 3, 2023 at 2:40 PM John Garry wrote: > > From: Himanshu Madhani > > Add the following limits: > - atomic_write_boundary > - atomic_write_max_bytes > - atomic_write_unit_max > - atomic_write_unit_min > > Signed-off-by: Himanshu Madhani > Signed-off-by: John Garry > --- >

Re: [dm-devel] [PATCH v5 4/5] dm-thin: Add REQ_OP_PROVISION support

2023-05-01 Thread Mike Snitzer
On Wed, Apr 19 2023 at 8:48P -0400, Sarthak Kukreti wrote: > dm-thinpool uses the provision request to provision > blocks for a dm-thin device. dm-thinpool currently does not > pass through REQ_OP_PROVISION to underlying devices. > > For shared blocks, provision requests will break sharing and

  1   2   3   4   5   6   7   8   9   10   >