Re: [dm-devel] [PATCH 2/2] multipath-tools/libmultipath: Add args min_avg_latency for path_latency.

2017-07-23 Thread Yang Feng
Dear Martin, Thanks, I got it. Regards, -Yang On 2017/7/21 20:26, Martin Wilck wrote: > Dear Yang, > > On Fri, 2017-07-21 at 11:38 +0800, Yang Feng wrote: >> >> Sorry, I don't find this similar syntax. Could you give a example of >> the >> other prioritizer.

Re: [dm-devel] [PATCH 2/2] multipath-tools/libmultipath: Add args min_avg_latency for path_latency.

2017-07-20 Thread Yang Feng
Dear Martin, Thank you very much for your guidance and reviews. Please find my replys as follows. The up-to-date patch will be sent later. Regards, -Yang On 2017/7/21 2:07, Martin Wilck wrote: > Dear Yang, > > On Thu, 2017-07-20 at 11:36 +0800, Yang Feng wrote: >> Add args

Re: [dm-devel] [PATCH 1/2] multipath-tools/libmultipath: Support for the native NVMe Ioctl command.

2017-07-20 Thread Yang Feng
Dear Martin, Thanks a lot for your reviews. Please find my replys as follows. And the up-to-date patch will be sent later. Regards, -Yang On 2017/7/21 1:50, Martin Wilck wrote: > Dear Yang, > > On Thu, 2017-07-20 at 11:36 +0800, Yang Feng wrote: >> 1. The SCSI-to-NVMe transla

[dm-devel] [PATCH 1/2] multipath-tools/libmultipath: Support for the native NVMe Ioctl command.

2017-07-19 Thread Yang Feng
Read Ioctl command to the nvme device, and send a SG Read Ioctl command to the scsi device. 3. In the tur checker, add support for the native NVMe Keep Alive Ioctl command to the nvme device. Signed-off-by: Yang Feng <philip.y...@huawei.com> Reviewed-by: Martin Wilck <mwi...@suse.com> Rev

[dm-devel] [PATCH 2/2] multipath-tools/libmultipath: Add args min_avg_latency for path_latency.

2017-07-19 Thread Yang Feng
0ms, 50ms], etc. Signed-off-by: Yang Feng <philip.y...@huawei.com> Reviewed-by: Martin Wilck <mwi...@suse.com> Reviewed-by: Xose Vazquez Perez <xose.vazq...@gmail.com> --- libmultipath/prioritizers/path_latency.c | 61 ++-- multipath/multipath.conf

Re: [dm-devel] [PATCH 0/2] multipath-tools/libmultipath: Support for the native NVMe Ioctl command and add args min_avg_latency for path_latency.

2017-07-18 Thread Yang Feng
Hi Xose, Thanks for your reviews The up-to-date patch will be sent later. Regards! -Yang On 2017/7/18 7:00, Xose Vazquez Perez wrote: > On 07/17/2017 04:23 AM, Yang Feng wrote: > >> I think there is a mistake: >> 1. In fact, the tur checker feature has never been remove

Re: [dm-devel] [PATCH 0/2] multipath-tools/libmultipath: Support for the native NVMe Ioctl command and add args min_avg_latency for path_latency.

2017-07-16 Thread Yang Feng
Respect and regards. -Yang On 2017/7/14 18:45, Martin Wilck wrote: > On Fri, 2017-07-14 at 09:47 +0800, Yang Feng wrote: >> Hi Xose, >> >> But tur can not support NVMe device, and if the default checker >> change to ping, >> then it can support NVMe device by a keep

Re: [dm-devel] [PATCH 0/2] multipath-tools/libmultipath: Support for the native NVMe Ioctl command and add args min_avg_latency for path_latency.

2017-07-13 Thread Yang Feng
Hi Xose, But tur can not support NVMe device, and if the default checker change to ping, then it can support NVMe device by a keep alive command and SCSI device by a tur command. Regards! -Yang On 2017/7/14 0:44, Xose Vazquez Perez wrote: > On 07/13/2017 09:51 AM, Yang Feng wr

Re: [dm-devel] [PATCH]prioritizers/path_latency: Fix failure of sg_read to a nvme device

2017-07-13 Thread Yang Feng
Closed and traced by another patch. -Yang On 2017/6/28 12:42, Yang Feng wrote: > Fixed failure of sg_read to a nvme device: > 1. Send sg_read command to a nvme device failed, > because the block size in user-mode is 4096 bytes, > not equal to the bolck size in kernel-mode, who is

[dm-devel] [PATCH 2/2] multipath-tools/libmultipath: Add args min_avg_latency for path_latency.

2017-07-13 Thread Yang Feng
0ms, 50ms], etc. Signed-off-by: Yang Feng <philip.y...@huawei.com> --- libmultipath/prioritizers/path_latency.c | 61 ++-- multipath/multipath.conf.5 | 14 +--- 2 files changed, 52 insertions(+), 23 deletions(-) diff --git a/libmultipath/pri

[dm-devel] [PATCH 0/2] multipath-tools/libmultipath: Support for the native NVMe Ioctl command and add args min_avg_latency for path_latency.

2017-07-13 Thread Yang Feng
10ms], (10ms, 50ms], etc. Yang Feng (1): multipath-tools/libmultipath: Support for the native NVMe Ioctl command and add args min_avg_latency for path_latency. libmultipath/checkers.c | 7 + libmultipath/checkers.h | 6 +- libmultipath/checkers/Makefile

[dm-devel] [PATCH 1/2] multipath-tools/libmultipath: Support for the native NVMe Ioctl command.

2017-07-13 Thread Yang Feng
csi device. Signed-off-by: Yang Feng <philip.y...@huawei.com> --- libmultipath/checkers.c | 7 + libmultipath/checkers.h | 6 +- libmultipath/checkers/Makefile | 6 +- libmultipath/checkers/emc_clariion.c | 4 +- libmultipath/checkers/libsg.c

[dm-devel] [PATCH]prioritizers/path_latency: Fix failure of sg_read to a nvme device

2017-06-27 Thread Yang Feng
s" in the linux-nvme, so using the nvme_read command is a good idea. Signed-off-by: Yang Feng <philip.y...@huawei.com> --- libmultipath/prioritizers/path_latency.c | 78 +++- 1 file changed, 66 insertions(+), 12 deletions(-) diff --git a/libmulti

Re: [dm-devel] [PATCH] multipath-tools: beautify path_latency.c code

2017-06-24 Thread Yang Feng
Hi Xose, Thanks for your work. ACK -Yang On 2017/6/23 0:46, Xose Vazquez Perez wrote: > Mainly running scripts/Lindent, from kernel dir, to replace indent spaces > by tabs. > > Cc: Yang Feng <philip.y...@huawei.com> > Cc: Christophe Varoqui <christophe.varo...@opensvc.

Re: [dm-devel] [PATCH v6 1/1] multipath-tools: Prioritizer based on a latency algorithm

2017-06-21 Thread Yang Feng
Hi Christophe, OK, thanks a lot. Regards, Yang --- On 2017/6/21 18:22, Christophe Varoqui wrote: > This version is now merged. > Thanks. > > Incremental enhancements can go from there if needed. > > On Wed, Jun 21, 2017 at 11:40 AM, Yang Feng <philip.y...@huawei.co

[dm-devel] [PATCH v6 1/1] multipath-tools: Prioritizer based on a latency algorithm

2017-06-21 Thread Yang Feng
| priority rank 7 |...| priority rank 0 | |--|--|--|...|--| Priority Rank Partitioning Signed-off-by: Yang Feng <philip.y...@huawei.com> Reviewed-by: Benjamin Marzinski <bmarz...@redhat.com> Reviewed-by: Martin Wilck <mwi...@suse.com> Reviewed-by: Xos

[dm-devel] [PATCH v6 0/1] multipath-tools: Prioritizer based on a latency algorithm

2017-06-21 Thread Yang Feng
se's reviews. * Add version for GPL, Fix according to Xose's reviews. Changes from v2: * Reorganize the commit comment and patch format. * Added Benjamin, Martin and Xose's Reviewed-by. Changes from v1: * The value of "MIN_IO_NUM" is set 2 from 10. * Fix according to Benjamin,

Re: [dm-devel] [PATCH v5 1/1] multipath-tools: Prioritizer based on a latency algorithm

2017-06-16 Thread Yang Feng
Hi Martin, Thanks for your reviews. Please find my replys. And the patch v6 will be sent later. Regards, Yang --- > >> +#define MAX_LATENCY_INTERVAL10/*unit: s*/ >> +#define MIN_LATENCY_INTERVAL1 /*unit: us, or ms, or s*/ > > Why not use the same unit or both

[dm-devel] [PATCH v5 0/1] multipath-tools: Prioritizer based on a latency algorithm

2017-06-09 Thread Yang Feng
ix according to Xose's reviews. Changes from v2: * Reorganize the commit comment and patch format. * Added Benjamin, Martin and Xose's Reviewed-by. Changes from v1: * The value of "MIN_IO_NUM" is set 2 from 10. * Fix according to Benjamin, Martin and Xose's reviews. Yang Feng (1): multipa

[dm-devel] [PATCH v5 1/1] multipath-tools: Prioritizer based on a latency algorithm

2017-06-09 Thread Yang Feng
rank 3 |...| priority rank x | |--|--|--|...|--| Priority Rank Partitioning Signed-off-by: Yang Feng <philip.y...@huawei.com> Reviewed-by: Benjamin Marzinski <bmarz...@redhat.com> Reviewed-by: Martin Wilck <mwi...@suse.com> Reviewed-by: Xose

Re: [dm-devel] [PATCH v4 0/1] multipath-tools: Prioritizer based on a latency algorithm

2017-06-09 Thread Yang Feng
Hi Martin, Thanks a lot. It's a good idea. The updated patch will be sent later. Regards, -Yang On 2017/6/9 16:05, Martin Wilck wrote: > Hello Yang, > >>> Actually, you're not alone here; several other storage array setups >>> suffer from the same problem. >>> >>> Eg if you have a

Re: [dm-devel] [PATCH v4 0/1] multipath-tools: Prioritizer based on a latency algorithm

2017-06-09 Thread Yang Feng
Hi Hannes, Thanks a lot. Please find my replys as follows. regards. -Yang On 2017/6/8 23:37, Hannes Reinecke wrote: > On 06/06/2017 04:43 AM, Yang Feng wrote: >> This patch value is in the following: >> 1. In the Storage-Backup environment of HyperCluster, includes >> o

[dm-devel] [PATCH v3 0/1] multipath-tools: Prioritizer based on a latency algorithm

2017-06-06 Thread Yang Feng
comment and patch format * Added Benjamin, Martin and Xose's Reviewed-by Changes to v1: * The value of "MIN_IO_NUM" is set 2 from 10 * Fix according to Benjamin, Martin and Xose's reviews. Yang Feng (1): multipath-tools: Prioritizer based on a latency algorithm libmultip

[dm-devel] [PATCH v4 0/1] multipath-tools: Prioritizer based on a latency algorithm

2017-06-05 Thread Yang Feng
10. * Fix according to Benjamin, Martin and Xose's reviews. Yang Feng (1): multipath-tools: Prioritizer based on a latency algorithm libmultipath/prio.h | 1 + libmultipath/prioritizers/Makefile | 4 + libmultipath/prioritizers/path_latency.c | 272 ++

[dm-devel] [PATCH v4 1/1] multipath-tools: Prioritizer based on a latency algorithm

2017-06-05 Thread Yang Feng
rank 3 |...| priority rank x | |--|--|--|...|--| Priority Rank Partitioning Signed-off-by: Yang Feng <philip.y...@huawei.com> Reviewed-by: Benjamin Marzinski <bmarz...@redhat.com> Reviewed-by: Martin Wilck <mwi...@suse.com> Reviewed-by: Xose Vazquez

[dm-devel] [PATCH v3 1/1] multipath-tools: Prioritizer based on a latency algorithm

2017-06-04 Thread Yang Feng
rank 3 |...| priority rank x | |--|--|--|...|--| Priority Rank Partitioning Signed-off-by: Yang Feng <philip.y...@huawei.com> Reviewed-by: Benjamin Marzinski <bmarz...@redhat.com> Reviewed-by: Martin Wilck <mwi...@suse.com> Reviewed-by: Xose Vazquez

Re: [dm-devel] [PATCH] multipath-tools:Prioritizer based on a latency algorithm

2017-05-24 Thread Yang Feng
On 2017/5/25 3:57, Benjamin Marzinski wrote: > On Wed, May 24, 2017 at 10:50:18AM +0800, Yang Feng wrote: >> Hello Christophe, > ACK > > -Ben > Hello Christophe, Any advance for this patch? Thanks,Best! -- dm-devel mailing list dm-devel@redhat.com https://www.redhat.co

Re: [dm-devel] [PATCH] multipath-tools:Prioritizer based on a latency algorithm

2017-05-23 Thread Yang Feng
as follows: --- >From 58d718fdd34550bd9c4a32c6e9a87099c1e45a9f Mon Sep 17 00:00:00 2001 From: Yang Feng <philip.y...@huawei.com> Date: Fri, 19 May 2017 16:09:07 +0800 Subject: [PATCH] libmultipath/prioritizers: Prioritizer for device mapper multipath, where the corresponding priority values of

Re: [dm-devel] [PATCH] multipath-tools:Prioritizer based on a latency algorithm

2017-05-23 Thread Yang Feng
tition different priority ranks. >> +Form: XXs, or XXXus, or XXXms. Unit: Second, or Microsecond, or >> Millisecond. Valid Values: Integer, s [1, 60], ms [1, 1000), us [1, 1000), >> +For example: 10s, or 100us, or 100ms. The default is: 10ms. >> +.TP >> +.I cons_num >>

Re: [dm-devel] [PATCH] multipath-tools:Prioritizer based on a time-delay algorithm

2017-05-23 Thread Yang Feng
Hello Benjamin, How about this patch? Look forward your replies. Thank you very much. Best regards! On 2017/5/19 17:45, Yang Feng wrote: > Hi Benjamin, > > Thank you very much for your comments. > Please find my replys and the up-to-date patch. > Best regards! > >&g

Re: [dm-devel] [PATCH] multipath-tools:Prioritizer based on a latency algorithm

2017-05-23 Thread Yang Feng
Hello Martin, How about this patch? Look forward your replies. Thank you very much. Best regards! On 2017/5/19 16:43, Yang Feng wrote: > Hello Martin, > > Firstly, thank you very much for your comments. > And find my replys and the up-to-date patch. > > Best regards! >

Re: [dm-devel] [PATCH] multipath-tools:Prioritizer based on a time-delay algorithm

2017-05-22 Thread Yang Feng
Hello Benjamin and Christophe, How about this patch? Thanks a lot. Best. On 2017/5/19 17:45, Yang Feng wrote: > Hi Benjamin, > > Thank you very much for your comments. > Please find my replys and the up-to-date patch. > Best regards! > >> >> First, one overall

Re: [dm-devel] [PATCH] multipath-tools:Prioritizer based on a time-delay algorithm

2017-05-19 Thread Yang Feng
;> .RE >> .TP 12 >> +.I delayed > > should be "delayedpath" here? OK, as the following patch. > >> +Needs a value of the form >> +\fI"<delay_interval|cons_num>"\fR >> +.RS >> +.TP 8 >> +.I delay_interval >> +The

Re: [dm-devel] [PATCH] multipath-tools:Prioritizer based on a time-delay algorithm

2017-05-16 Thread Yang Feng
Hello Martin, How about this patch? Thanks a lot, Best regards. On 2017/5/15 18:44, Yang Feng wrote: > Hello Martin, > > Thank you very much for your remarks. I am sorry for late reply, Please find > my answer and the updated patch. > >> Hello Yang, >> >> tha

Re: [dm-devel] [PATCH] multipath-tools:Prioritizer based on a time-delay algorithm

2017-05-15 Thread Yang Feng
Hello Martin, Thank you very much for your remarks. I am sorry for late reply, Please find my answer and the updated patch. > Hello Yang, > > thank you for your work. Please find my remarks below. > > On Mon, 2017-05-08 at 11:58 +0800, Yang Feng wrote: >> Prioriti

[dm-devel] [PATCH] multipath-tools:Prioritizer based on a time-delay algorithm

2017-05-07 Thread Yang Feng
e provided by a time-delay algorithm. And the + * time-delay algorithm is dependent on arguments. + * + * The principle of the algorithm as follows: + * 1. By sending a certain number "cons_num" of read IOs to the current path + *continuously, the IOs' average delay can be calcula