Re: [dm-devel] [PATCH 14/18] scsi: remove __scsi_alloc_queue

[Bart Van Assche]

On Wed, 2017-01-25 at 18:25 +0100, Christoph Hellwig wrote:
> diff --git a/include/scsi/scsi_transport.h b/include/scsi/scsi_transport.h
> index 8129239..b6e07b5 100644
> --- a/include/scsi/scsi_transport.h
> +++ b/include/scsi/scsi_transport.h
> @@ -119,4 +119,6 @@ scsi_transport_device_data(struct scsi_device *sdev)
>   + shost->transportt->device_private_offset;
>  }
>  
> +void __scsi_init_queue(struct Scsi_Host *shost, struct request_queue *q);
> +
>  #endif /* SCSI_TRANSPORT_H */

Hello Christoph,

Since __scsi_init_queue() modifies data in the Scsi_Host structure, have you
considered to add the declaration for this function to ?
If you want to keep this declaration in  please add a
direct include of that header file to drivers/scsi/scsi_lib.c such that the
declaration remains visible to the compiler if someone would minimize the
number of #include directives in SCSI header files.

Thanks,

Bart.

--
dm-devel mailing list
dm-devel@redhat.com
https://www.redhat.com/mailman/listinfo/dm-devel

Re: [dm-devel] [PATCH 14/18] scsi: remove __scsi_alloc_queue

[Martin K. Petersen]

> "Christoph" == Christoph Hellwig  writes:

Christoph> Instead do an internal export of __scsi_init_queue for the
Christoph> transport classes that export BSG nodes.

Acked-by: Martin K. Petersen 

-- 
Martin K. Petersen  Oracle Linux Engineering

--
dm-devel mailing list
dm-devel@redhat.com
https://www.redhat.com/mailman/listinfo/dm-devel