Re: [dm-devel] [PATCH] block: Improve io_opt limit stacking

2020-05-25 Thread Keith Busch
On Fri, May 22, 2020 at 09:36:18AM -0400, Martin K. Petersen wrote: > > >>> + if (t->io_opt & (t->physical_block_size - 1)) > >>> + t->io_opt = lcm(t->io_opt, t->physical_block_size); > > > >> Any comment on this patch ? Note: the patch the patch "nvme: Fix > >> io_opt limit setting" is

Re: [dm-devel] [PATCH] block: Improve io_opt limit stacking

2020-05-22 Thread Martin K. Petersen
>>> + if (t->io_opt & (t->physical_block_size - 1)) >>> + t->io_opt = lcm(t->io_opt, t->physical_block_size); > >> Any comment on this patch ? Note: the patch the patch "nvme: Fix >> io_opt limit setting" is already queued for 5.8. > > Setting io_opt to the physical block size is

Re: [dm-devel] [PATCH] block: Improve io_opt limit stacking

2020-05-22 Thread Martin K. Petersen
Damien, >> +if (t->io_opt & (t->physical_block_size - 1)) >> +t->io_opt = lcm(t->io_opt, t->physical_block_size); > Any comment on this patch ? Note: the patch the patch "nvme: Fix > io_opt limit setting" is already queued for 5.8. Setting io_opt to the physical block size is

Re: [dm-devel] [PATCH] block: Improve io_opt limit stacking

2020-05-22 Thread Damien Le Moal
On 2020/05/14 15:58, Damien Le Moal wrote: > When devices with different physical sector sizes are stacked, the > largest value is used as the stacked device physical sector size. For > the optimal IO size, the lowest common multiple (lcm) of the underlying > devices is used for the stacked