Re: [dm-devel] [PATCH] libmultipath: ensure dev_loss_tmo will be update to MAX_DEV_LOSS_TMO if no_path_retry set to queue

2016-12-07 Thread peng.liang5
Hello, Hannes The kernel didn't limit the dev_loss_tmo if fast_io_fail_tmo is 0. But multipath did. Should I leave it alone and just revert this patch? Thanks. 原始邮件 发件人：HannesReinecke 收件人：＜dm-devel@redhat.com＞ 日 期 ：2016年12月07日 15:04 主 题 ：Re: [dm-devel] [PATCH] libmultipath: ensure

Re: [dm-devel] [PATCH] libmultipath: ensure dev_loss_tmo will be update to MAX_DEV_LOSS_TMO if no_path_retry set to queue

2016-12-07 Thread Benjamin Marzinski
On Wed, Dec 07, 2016 at 02:42:16PM +0800, peng.lia...@zte.com.cn wrote: >Hello, Ben > >Sorry for late to reply. > >Such is the case as you said below. If fast_io_fail_tmo is off we have to >cap > >dev_loss_tmo at 600. So, this patch is a wrong guide and will be cause a > >

Re: [dm-devel] [PATCH] libmultipath: ensure dev_loss_tmo will be update to MAX_DEV_LOSS_TMO if no_path_retry set to queue

2016-12-06 Thread Hannes Reinecke
On 12/07/2016 07:42 AM, peng.lia...@zte.com.cn wrote: > Hello, Ben > > Sorry for late to reply. > > Such is the case as you said below. If fast_io_fail_tmo is off we have > to cap dev_loss_tmo at 600. So, this patch is a wrong guide and will be > cause a kernel error. > Indeed. We've had _far_

Re: [dm-devel] [PATCH] libmultipath: ensure dev_loss_tmo will be update to MAX_DEV_LOSS_TMO if no_path_retry set to queue

2016-12-06 Thread peng.liang5
Hello, Ben Sorry for late to reply. Such is the case as you said below. If fast_io_fail_tmo is off we have to cap dev_loss_tmo at 600. So, this patch is a wrong guide and will be cause a kernel error. And one more question. Should the system limit dev_loss_tmo to 600 if fast_io_fail_tmo set

Re: [dm-devel] [PATCH] libmultipath: ensure dev_loss_tmo will be update to MAX_DEV_LOSS_TMO if no_path_retry set to queue

2016-12-01 Thread Benjamin Marzinski
On Thu, Dec 01, 2016 at 09:06:14AM +0800, peng.lia...@zte.com.cn wrote: >If fast_io_fail_tmo isn't set, it will be use the DEFAULT_FAST_IO_FAIL >in select_fast_io_fail. > >So, multipath will not run the limited of dev_loss_tmo to 600. Yes, but the kernel will. With your patch

Re: [dm-devel] [PATCH] libmultipath: ensure dev_loss_tmo will be update to MAX_DEV_LOSS_TMO if no_path_retry set to queue

2016-11-30 Thread peng.liang5
If fast_io_fail_tmo isn't set, it will be use the DEFAULT_FAST_IO_FAIL in select_fast_io_fail. So, multipath will not run the limited of dev_loss_tmo to 600. And I think using MP_FAST_IO_FAIL_UNSET as the condition is meaningless after multipath run select_fast_io_fail even if it's not set.

Re: [dm-devel] [PATCH] libmultipath: ensure dev_loss_tmo will be update to MAX_DEV_LOSS_TMO if no_path_retry set to queue

2016-11-28 Thread Benjamin Marzinski
On Fri, Nov 25, 2016 at 02:36:04PM +0800, peng.lia...@zte.com.cn wrote: > From: PengLiang > > If no_path_retry set to queue, we should make sure dev_loss_tmo update to > MAX_DEV_LOSS_TMO. > But, it will be limit to 600 if fast_io_fail_tmo set to off or 0 meanwhile.

Re: [dm-devel] [PATCH] libmultipath: ensure dev_loss_tmo will be update to MAX_DEV_LOSS_TMO if no_path_retry set to queue

2016-11-26 Thread Christophe Varoqui
Applied, thanks. On Fri, Nov 25, 2016 at 7:36 AM, wrote: > From: PengLiang > > If no_path_retry set to queue, we should make sure dev_loss_tmo update to > MAX_DEV_LOSS_TMO. > But, it will be limit to 600 if fast_io_fail_tmo set to off or 0

[dm-devel] [PATCH] libmultipath: ensure dev_loss_tmo will be update to MAX_DEV_LOSS_TMO if no_path_retry set to queue

2016-11-24 Thread peng . liang5
From: PengLiang If no_path_retry set to queue, we should make sure dev_loss_tmo update to MAX_DEV_LOSS_TMO. But, it will be limit to 600 if fast_io_fail_tmo set to off or 0 meanwhile. Signed-off-by: PengLiang --- libmultipath/discovery.c | 3