Re: [dm-devel] [PATCH] libmultipath: add comment about resuming

2017-05-22 Thread Martin Wilck 
On Thu, 2017-05-18 at 16:37 -0500, Benjamin Marzinski wrote:
> The reason for the second resume in my commit "libmultipath: fix
> suspended devs from failed reloads" is not obvious from the multipath
> code, so add a comment.

Nice, thank you.

Martin

-- 
Dr. Martin Wilck , Tel. +49 (0)911 74053 2107
SUSE Linux GmbH, GF: Felix Imendörffer, Jane Smithard, Graham Norton
HRB 21284 (AG Nürnberg)

--
dm-devel mailing list
dm-devel@redhat.com
https://www.redhat.com/mailman/listinfo/dm-devel

[dm-devel] [PATCH] libmultipath: add comment about resuming

2017-05-18 Thread Benjamin Marzinski 
The reason for the second resume in my commit "libmultipath: fix
suspended devs from failed reloads" is not obvious from the multipath
code, so add a comment.

Signed-off-by: Benjamin Marzinski 
---
 libmultipath/devmapper.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/libmultipath/devmapper.c b/libmultipath/devmapper.c
index 69b634b..ee83e0f 100644
--- a/libmultipath/devmapper.c
+++ b/libmultipath/devmapper.c
@@ -399,6 +399,9 @@ int dm_addmap_reload(struct multipath *mpp, char *params, 
int flush)
if (r)
return r;
 
+   /* If the resume failed, dm will leave the device suspended, and
+* drop the new table, so doing a second resume will try using
+* the original table */
if (dm_is_suspended(mpp->alias))
dm_simplecmd(DM_DEVICE_RESUME, mpp->alias, !flush, 1,
 udev_flags, 0);
-- 
1.8.3.1

--
dm-devel mailing list
dm-devel@redhat.com
https://www.redhat.com/mailman/listinfo/dm-devel