Re: [dm-devel] [PATCH 20/57] multipathd: Do not update the paths vec when removing paths

2016-05-02 Thread Hannes Reinecke
On 05/02/2016 05:12 PM, Benjamin Marzinski wrote: > On Mon, May 02, 2016 at 07:48:50AM +0200, Hannes Reinecke wrote: >> On 04/30/2016 12:39 AM, Benjamin Marzinski wrote: >>> On Wed, Apr 27, 2016 at 01:10:21PM +0200, Hannes Reinecke wrote: When we remove a path it's totally pointless to add it

Re: [dm-devel] [PATCH 20/57] multipathd: Do not update the paths vec when removing paths

2016-05-02 Thread Benjamin Marzinski
On Mon, May 02, 2016 at 07:48:50AM +0200, Hannes Reinecke wrote: > On 04/30/2016 12:39 AM, Benjamin Marzinski wrote: > > On Wed, Apr 27, 2016 at 01:10:21PM +0200, Hannes Reinecke wrote: > >> When we remove a path it's totally pointless to add it to > >> the path list first; it'll be removed on the

Re: [dm-devel] [PATCH 20/57] multipathd: Do not update the paths vec when removing paths

2016-05-01 Thread Hannes Reinecke
On 04/30/2016 12:39 AM, Benjamin Marzinski wrote: > On Wed, Apr 27, 2016 at 01:10:21PM +0200, Hannes Reinecke wrote: >> When we remove a path it's totally pointless to add it to >> the path list first; it'll be removed on the next step anyway. >> And we should be cleaning up the comments while

Re: [dm-devel] [PATCH 20/57] multipathd: Do not update the paths vec when removing paths

2016-04-29 Thread Benjamin Marzinski
On Wed, Apr 27, 2016 at 01:10:21PM +0200, Hannes Reinecke wrote: > When we remove a path it's totally pointless to add it to > the path list first; it'll be removed on the next step anyway. > And we should be cleaning up the comments while we're at it. This one causes problems. The easiest way to

[dm-devel] [PATCH 20/57] multipathd: Do not update the paths vec when removing paths

2016-04-27 Thread Hannes Reinecke
When we remove a path it's totally pointless to add it to the path list first; it'll be removed on the next step anyway. And we should be cleaning up the comments while we're at it. Signed-off-by: Hannes Reinecke --- multipathd/main.c | 13 ++--- 1 file changed, 6