On Thu, Mar 30, 2017 at 07:15:50PM -0400, Mike Snitzer wrote:
> I got pretty far along with implementing the DM thinp support for
> WRITE_ZEROES in terms of thinp's DISCARD support (more of an
> implementation detail.. or so I thought).
>
> But while discussing this effort with Jeff Moyer he asked
Mike Snitzer writes:
Mike,
> But while discussing this effort with Jeff Moyer he asked: shouldn't the
> zeroed blocks be provisioned? This is a fairly embarassing question not
> to be able to answer in the moment. So I clearly need to learn what the
> overall intent of WRITE_ZEROES actually is
On Thu, Mar 30 2017 at 11:20am -0400,
Martin K. Petersen wrote:
> Mike Snitzer writes:
>
> > I can work on this now. Only question I have is: should DM thinp take
> > care to zero any misaligned head and tail? (I assume so but with all
> > the back and forth between Bart, Paolo and Martin I f
Mike Snitzer writes:
> I can work on this now. Only question I have is: should DM thinp take
> care to zero any misaligned head and tail? (I assume so but with all
> the back and forth between Bart, Paolo and Martin I figured I'd ask
> explicitly).
Yep, let's make sure our semantics match the
On Thu, Mar 30 2017 at 7:44am -0400,
Christoph Hellwig wrote:
> On Thu, Mar 30, 2017 at 12:06:41PM +0200, Lars Ellenberg wrote:
>
> > Will it make an fstrim cause thinly provisioned
> > devices to suddenly be fully allocated?
>
> Not for SCSI devices. Yes for dm-thinp until it implements
> RE
On Thu, Mar 30, 2017 at 12:06:41PM +0200, Lars Ellenberg wrote:
> On Thu, Mar 23, 2017 at 10:33:40AM -0400, Christoph Hellwig wrote:
> > It seems like DRBD assumes its on the wire TRIM request always zeroes data.
> > Use that fact to implement REQ_OP_WRITE_ZEROES.
> >
> > XXX: will need a careful
On Thu, Mar 23, 2017 at 10:33:40AM -0400, Christoph Hellwig wrote:
> It seems like DRBD assumes its on the wire TRIM request always zeroes data.
> Use that fact to implement REQ_OP_WRITE_ZEROES.
>
> XXX: will need a careful audit from the drbd team!
Thanks, this one looks ok to me.
The real ques
It seems like DRBD assumes its on the wire TRIM request always zeroes data.
Use that fact to implement REQ_OP_WRITE_ZEROES.
XXX: will need a careful audit from the drbd team!
Signed-off-by: Christoph Hellwig
---
drivers/block/drbd/drbd_main.c | 3 ++-
drivers/block/drbd/drbd_nl.c | 2