Re: [dm-devel] [PATCH 3/3] block: use a driver-specific handler for the "inflight" value

2018-11-27 Thread Mikulas Patocka
On Fri, 16 Nov 2018, Jens Axboe wrote: > On 11/16/18 6:55 AM, Mike Snitzer wrote: > > On Fri, Nov 16 2018 at 4:11am -0500, > > Christoph Hellwig wrote: > > > >> On Fri, Nov 16, 2018 at 01:04:19AM +0100, Mikulas Patocka wrote: > >>> Device mapper was converted to percpu inflight counters. In

Re: [dm-devel] [PATCH 3/3] block: use a driver-specific handler for the "inflight" value

2018-11-16 Thread Jens Axboe
On 11/16/18 6:55 AM, Mike Snitzer wrote: > On Fri, Nov 16 2018 at 4:11am -0500, > Christoph Hellwig wrote: > >> On Fri, Nov 16, 2018 at 01:04:19AM +0100, Mikulas Patocka wrote: >>> Device mapper was converted to percpu inflight counters. In order to >>> display the correct values in the

Re: [dm-devel] [PATCH 3/3] block: use a driver-specific handler for the "inflight" value

2018-11-16 Thread Mike Snitzer
On Fri, Nov 16 2018 at 4:11am -0500, Christoph Hellwig wrote: > On Fri, Nov 16, 2018 at 01:04:19AM +0100, Mikulas Patocka wrote: > > Device mapper was converted to percpu inflight counters. In order to > > display the correct values in the "inflight" sysfs file and in > > /proc/diskstats, we

Re: [dm-devel] [PATCH 3/3] block: use a driver-specific handler for the "inflight" value

2018-11-16 Thread Christoph Hellwig
On Fri, Nov 16, 2018 at 01:04:19AM +0100, Mikulas Patocka wrote: > Device mapper was converted to percpu inflight counters. In order to > display the correct values in the "inflight" sysfs file and in > /proc/diskstats, we need a custom callback that sums the percpu counters. > > The function

[dm-devel] [PATCH 3/3] block: use a driver-specific handler for the "inflight" value

2018-11-15 Thread Mikulas Patocka
Device mapper was converted to percpu inflight counters. In order to display the correct values in the "inflight" sysfs file and in /proc/diskstats, we need a custom callback that sums the percpu counters. The function part_round_stats calculates the number of in-flight I/Os every jiffy and uses