Re: [dm-devel] [PATCH 36/57] libmultipath: pass in 'cookie' as argument for dm_addmap()

2016-05-03 Thread Benjamin Marzinski
On Tue, May 03, 2016 at 04:43:01PM +0200, Hannes Reinecke wrote: > On 05/03/2016 04:39 PM, Benjamin Marzinski wrote: > > On Tue, May 03, 2016 at 11:31:19AM +0200, Hannes Reinecke wrote: > >> On 05/03/2016 12:23 AM, Benjamin Marzinski wrote: > >>> On Wed, Apr 27, 2016 at 01:10:37PM +0200, Hannes Rei

Re: [dm-devel] [PATCH 36/57] libmultipath: pass in 'cookie' as argument for dm_addmap()

2016-05-03 Thread Hannes Reinecke
On 05/03/2016 04:39 PM, Benjamin Marzinski wrote: > On Tue, May 03, 2016 at 11:31:19AM +0200, Hannes Reinecke wrote: >> On 05/03/2016 12:23 AM, Benjamin Marzinski wrote: >>> On Wed, Apr 27, 2016 at 01:10:37PM +0200, Hannes Reinecke wrote: Instead of generating the cookie internally we should b

Re: [dm-devel] [PATCH 36/57] libmultipath: pass in 'cookie' as argument for dm_addmap()

2016-05-03 Thread Benjamin Marzinski
On Tue, May 03, 2016 at 11:31:19AM +0200, Hannes Reinecke wrote: > On 05/03/2016 12:23 AM, Benjamin Marzinski wrote: > > On Wed, Apr 27, 2016 at 01:10:37PM +0200, Hannes Reinecke wrote: > >> Instead of generating the cookie internally we should be > >> passing in the cookie to dm_addmap(). > > > >

Re: [dm-devel] [PATCH 36/57] libmultipath: pass in 'cookie' as argument for dm_addmap()

2016-05-03 Thread Hannes Reinecke
On 05/03/2016 12:23 AM, Benjamin Marzinski wrote: > On Wed, Apr 27, 2016 at 01:10:37PM +0200, Hannes Reinecke wrote: >> Instead of generating the cookie internally we should be >> passing in the cookie to dm_addmap(). > > These look like they could actually cause problems. With > dm_addmap_create

Re: [dm-devel] [PATCH 36/57] libmultipath: pass in 'cookie' as argument for dm_addmap()

2016-05-02 Thread Hannes Reinecke
On 05/03/2016 12:23 AM, Benjamin Marzinski wrote: > On Wed, Apr 27, 2016 at 01:10:37PM +0200, Hannes Reinecke wrote: >> Instead of generating the cookie internally we should be >> passing in the cookie to dm_addmap(). > > These look like they could actually cause problems. With > dm_addmap_create

Re: [dm-devel] [PATCH 36/57] libmultipath: pass in 'cookie' as argument for dm_addmap()

2016-05-02 Thread Benjamin Marzinski
On Wed, Apr 27, 2016 at 01:10:37PM +0200, Hannes Reinecke wrote: > Instead of generating the cookie internally we should be > passing in the cookie to dm_addmap(). These look like they could actually cause problems. With dm_addmap_create and dm_addmap_reload, you could be in a situation where you

[dm-devel] [PATCH 36/57] libmultipath: pass in 'cookie' as argument for dm_addmap()

2016-04-27 Thread Hannes Reinecke
Instead of generating the cookie internally we should be passing in the cookie to dm_addmap(). Signed-off-by: Hannes Reinecke --- libmultipath/devmapper.c | 23 ++- 1 file changed, 14 insertions(+), 9 deletions(-) diff --git a/libmultipath/devmapper.c b/libmultipath/devmappe