Re: [dm-devel] [PATCH v3 17/20] multipath -u: test if path is busy

2018-04-15 Thread Benjamin Marzinski
On Mon, Apr 02, 2018 at 09:50:48PM +0200, Martin Wilck wrote: > For "find_multipaths smart", check if a path is already in use > before setting DM_MULTIPATH_DEVICE_PATH to 1 or 2 (and thus, > SYSTEMD_READY=0). If we don't do this, a device which has already been > mounted (e.g. during initrd

Re: [dm-devel] [PATCH v3 17/20] multipath -u: test if path is busy

2018-04-13 Thread Martin Wilck
On Fri, 2018-04-13 at 10:53 -0500, Benjamin Marzinski wrote: > On Fri, Apr 13, 2018 at 12:17:54AM +0200, Martin Wilck wrote: > > > > As I said already, I don't understand why you say that. > > > > I can assert that if is_failed_wwid() returns true, multipathd has > > definitely tried and failed

Re: [dm-devel] [PATCH v3 17/20] multipath -u: test if path is busy

2018-04-13 Thread Benjamin Marzinski
On Fri, Apr 13, 2018 at 12:17:54AM +0200, Martin Wilck wrote: > On Thu, 2018-04-12 at 13:41 -0500, Benjamin Marzinski wrote: > > On Mon, Apr 02, 2018 at 09:50:48PM +0200, Martin Wilck wrote: > > > For "find_multipaths smart", check if a path is already in use > > > before setting

Re: [dm-devel] [PATCH v3 17/20] multipath -u: test if path is busy

2018-04-12 Thread Martin Wilck
On Thu, 2018-04-12 at 13:41 -0500, Benjamin Marzinski wrote: > On Mon, Apr 02, 2018 at 09:50:48PM +0200, Martin Wilck wrote: > > For "find_multipaths smart", check if a path is already in use > > before setting DM_MULTIPATH_DEVICE_PATH to 1 or 2 (and thus, > > SYSTEMD_READY=0). If we don't do

[dm-devel] [PATCH v3 17/20] multipath -u: test if path is busy

2018-04-02 Thread Martin Wilck
For "find_multipaths smart", check if a path is already in use before setting DM_MULTIPATH_DEVICE_PATH to 1 or 2 (and thus, SYSTEMD_READY=0). If we don't do this, a device which has already been mounted (e.g. during initrd processing) may be unmounted by systemd, causing havoc to the boot process.